From 5b6ae4da7f0af5c6550ecedcce1de6cab3b38e24 Mon Sep 17 00:00:00 2001
From: chaoguang <13974480+zjuLcg@users.noreply.github.com>
Date: Fri, 3 Apr 2020 16:11:20 -0700
Subject: [PATCH] A simple intergration to put conflictingKeys into
 special-key-space

---
 fdbclient/DatabaseContext.h        |  2 ++
 fdbclient/NativeAPI.actor.cpp      |  2 ++
 fdbclient/ReadYourWrites.actor.cpp |  8 ++++++--
 fdbclient/ReadYourWrites.h         |  4 ++++
 fdbclient/SpecialKeySpace.actor.h  | 12 ++++++++++++
 5 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/fdbclient/DatabaseContext.h b/fdbclient/DatabaseContext.h
index 916ab2997f..69a7a926d9 100644
--- a/fdbclient/DatabaseContext.h
+++ b/fdbclient/DatabaseContext.h
@@ -46,6 +46,7 @@ typedef MultiInterface<ReferencedInterface<StorageServerInterface>> LocationInfo
 typedef MultiInterface<MasterProxyInterface> ProxyInfo;
 
 class SpecialKeySpace; //forward declaration
+class ConflictingKeysImpl;
 class DatabaseContext : public ReferenceCounted<DatabaseContext>, public FastAllocated<DatabaseContext>, NonCopyable {
 public:
 	static DatabaseContext* allocateOnForeignThread() {
@@ -230,6 +231,7 @@ public:
 
 	UniqueOrderedOptionList<FDBTransactionOptions> transactionDefaults;
 	std::shared_ptr<SpecialKeySpace> specialKeySpace;
+	std::shared_ptr<ConflictingKeysImpl> cKImpl;
 };
 
 #endif
diff --git a/fdbclient/NativeAPI.actor.cpp b/fdbclient/NativeAPI.actor.cpp
index 1143217e4a..b65764e2a8 100644
--- a/fdbclient/NativeAPI.actor.cpp
+++ b/fdbclient/NativeAPI.actor.cpp
@@ -541,6 +541,8 @@ DatabaseContext::DatabaseContext(
 	monitorMasterProxiesInfoChange = monitorMasterProxiesChange(clientInfo, &masterProxiesChangeTrigger);
 	clientStatusUpdater.actor = clientStatusUpdateActor(this);
 	specialKeySpace = std::make_shared<SpecialKeySpace>(normalKeys.begin, normalKeys.end);
+	cKImpl = std::make_shared<ConflictingKeysImpl>(conflictingKeys.begin, conflictingKeys.end);
+	specialKeySpace->registerKeyRange(conflictingKeys, cKImpl.get());
 }
 
 DatabaseContext::DatabaseContext( const Error &err ) : deferredError(err), cc("TransactionMetrics"), transactionReadVersions("ReadVersions", cc), 
diff --git a/fdbclient/ReadYourWrites.actor.cpp b/fdbclient/ReadYourWrites.actor.cpp
index dea11a5653..96458afc57 100644
--- a/fdbclient/ReadYourWrites.actor.cpp
+++ b/fdbclient/ReadYourWrites.actor.cpp
@@ -1281,8 +1281,12 @@ Future< Standalone<RangeResultRef> > ReadYourWritesTransaction::getRange(
 	}
 
 	// start with simplest point, special key space are only allowed to query if both begin and end start with \xff\xff
-	if (begin.getKey().startsWith(specialKeys.begin) && end.getKey().startsWith(specialKeys.begin))
-		return getDatabase()->specialKeySpace->getRange(Reference<ReadYourWritesTransaction>(this), begin, end, limits, snapshot, reverse);
+	if (begin.getKey().startsWith(specialKeys.begin) && end.getKey().startsWith(specialKeys.begin)) {
+		Reference<ReadYourWritesTransaction> self = Reference<ReadYourWritesTransaction>(this);
+		auto result = getDatabase()->specialKeySpace->getRange(self, begin, end, limits, snapshot, reverse);
+		self.extractPtr();
+		return result;
+	}
 	
 	// Use special key prefix "\xff\xff/transaction/conflicting_keys/<some_key>",
 	// to retrieve keys which caused latest not_committed(conflicting with another transaction) error.
diff --git a/fdbclient/ReadYourWrites.h b/fdbclient/ReadYourWrites.h
index f4ebd92e4b..4783bb29a2 100644
--- a/fdbclient/ReadYourWrites.h
+++ b/fdbclient/ReadYourWrites.h
@@ -131,6 +131,10 @@ public:
 	Database getDatabase() const {
 		return tr.getDatabase();
 	}
+
+	const Transaction& getTransaction() const {
+		return tr;
+	}
 private:
 	friend class RYWImpl;
 
diff --git a/fdbclient/SpecialKeySpace.actor.h b/fdbclient/SpecialKeySpace.actor.h
index 8327c4356e..dccec9f5c7 100644
--- a/fdbclient/SpecialKeySpace.actor.h
+++ b/fdbclient/SpecialKeySpace.actor.h
@@ -69,5 +69,17 @@ private:
 	KeyRange range;
 };
 
+class ConflictingKeysImpl : public SpecialKeyRangeBaseImpl {
+public:
+	explicit ConflictingKeysImpl(KeyRef start, KeyRef end) : SpecialKeyRangeBaseImpl(start, end) {}
+	virtual Future<Standalone<RangeResultRef>> getRange(Reference<ReadYourWritesTransaction> ryw,
+	                                                    KeyRangeRef kr) const {
+		auto resultFuture = ryw->getTransaction().info.conflictingKeysRYW->getRange(kr, CLIENT_KNOBS->TOO_MANY);
+		// all keys are written to RYW, since GRV is set, the read should happen locally
+		ASSERT(resultFuture.isReady());
+		return resultFuture.getValue();
+	}
+};
+
 #include "flow/unactorcompiler.h"
 #endif