wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

duplicate mutation stream checker did not have a timeout 

duplicate mutation stream did not work properly when multiple ranges exist with the same begin key
This commit is contained in:
Evan Tschannen 2019-10-16 20:17:09 -07:00
parent 5be773f145
commit 587cbefe7f
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fdbserver/Status.actor.cpp
View File

@ -1160,15 +1160,16 @@ ACTOR static Future<Void> logRangeWarningFetcher(Database cx, JsonBuilderArray *
tr.setOption(FDBTransactionOptions::READ_LOCK_AWARE);
tr.setOption(FDBTransactionOptions::READ_SYSTEM_KEYS);
Standalone<RangeResultRef> existingDestUidValues = wait(tr.getRange(KeyRangeRef(destUidLookupPrefix, strinc(destUidLookupPrefix)), CLIENT_KNOBS->TOO_MANY));
std::map<Key,Key> existingRanges;
Standalone<RangeResultRef> existingDestUidValues = wait(timeoutError(tr.getRange(KeyRangeRef(destUidLookupPrefix, strinc(destUidLookupPrefix)), CLIENT_KNOBS->TOO_MANY), 5.0));
std::set<std::pair<Key,Key>> existingRanges;
for(auto it : existingDestUidValues) {
KeyRange range = BinaryReader::fromStringRef<KeyRange>(it.key.removePrefix(destUidLookupPrefix), IncludeVersion());
if(existingRanges.count(range.begin) && existingRanges[range.begin] == range.end) {
messages->push_back(JsonString::makeMessage("duplicate_mutation_streams", format("Backup and DR are not sharing the same stream of mutations for range `%s` - `%s`.", printable(range.begin).c_str(), printable(range.end).c_str()).c_str()));
std::pair<Key,Key> rangePair = std::make_pair(range.begin,range.end);
if(existingRanges.count(rangePair)) {
messages->push_back(JsonString::makeMessage("duplicate_mutation_streams", format("Backup and DR are not sharing the same stream of mutations for `%s` - `%s`", printable(range.begin).c_str(), printable(range.end).c_str()).c_str()));
break;
}
existingRanges[range.begin] = range.end;
existingRanges.insert(rangePair);
}
break;
} catch(Error &e) {