wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fmt::format for key string generation is slow

This commit is contained in:
Junhyun Shim 2022-04-20 10:10:18 +02:00
parent 278009e1c8
commit 50dcde0ca5
3 changed files with 16 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bindings/c/test/mako/mako.cpp
View File

@ -235,7 +235,7 @@ int runOneTransaction(Transaction& tx,
auto needs_commit = false;
transaction_begin:
while (op_iter != OpEnd) {
const auto [op, count, step] = op_iter;
const auto& [op, count, step] = op_iter;
const auto step_kind = opTable[op].stepKind(step);
auto watch_step = Stopwatch(StartAtCtor{});
if (step == 0 /* first step */)

4
bindings/c/test/mako/operations.hpp
View File

@ -126,9 +126,7 @@ force_inline OpIterator getOpBegin(Arguments const& args) noexcept {
}
force_inline OpIterator getOpNext(Arguments const& args, OpIterator current) noexcept {
if (OpEnd == current)
return OpEnd;
auto [op, count, step] = current;
auto& [op, count, step] = current;
assert(op < MAX_OP && !isAbstractOp(op));
if (opTable[op].steps() > step + 1)
return OpIterator{ op, count, step + 1 };

30
bindings/c/test/mako/utils.hpp
View File

@ -99,28 +99,26 @@ void genKeyPrefix(std::basic_string<Char>& str, std::string_view prefix, Argumen
args.prefixpadding ? (args.key_length - args.row_digits - static_cast<int>(prefix.size())) : 0;
assert(padding_len >= 0);
str.reserve(str.size() + padding_len + prefix.size());
fmt::format_to(std::back_inserter(str), "{0:x>{1}}{2}", "", padding_len, prefix);
for (auto i = 0; i < padding_len; i++)
str.push_back('x');
str.append(reinterpret_cast<Char const*>(prefix.data()), prefix.size());
}
/* generate a key for a given key number */
/* prefix is "mako" by default, prefixpadding = 1 means 'x' will be in front rather than trailing the keyname */
template <bool Clear = true, typename Char>
template <typename Char>
void genKey(std::basic_string<Char>& str, std::string_view prefix, Arguments const& args, int num) {
static_assert(sizeof(Char) == 1);
const auto pad_len = args.prefixpadding ? args.key_length - (static_cast<int>(prefix.size()) + args.row_digits) : 0;
assert(pad_len >= 0);
if constexpr (Clear)
str.clear();
str.reserve(str.size() + static_cast<size_t>(args.key_length));
fmt::format_to(std::back_inserter(str),
"{0:x>{1}}{2}{3:0{4}d}{5:x>{6}}",
"",
pad_len,
prefix,
num,
args.row_digits,
"",
args.key_length - pad_len - static_cast<int>(prefix.size()) - args.row_digits);
str.clear();
str.resize(args.key_length, 'x');
const auto prefix_len = static_cast<int>(prefix.size());
auto pos = args.prefixpadding ? (args.key_length - prefix_len - args.row_digits) : 0;
memcpy(&str[pos], prefix.data(), prefix.size());
pos += prefix_len;
for (auto i = 0; i < args.row_digits; i++) {
str[pos + (args.row_digits - i - 1)] = (num % 10) + '0';
num /= 10;
}
}
// invoke user-provided callable when object goes out of scope.