Move DeterministicRandom impl to its own translation unit

This will allow me to recompile faster after making changes, and should
(slightly) speed up overall compilation.

I manually verified that the unseed matched for one test before and
after this change, so I probably didn't screw up the refactor
This commit is contained in:
Andrew Noyes 2019-12-04 13:32:38 -08:00
parent e300cd7573
commit 4f943be21d
4 changed files with 137 additions and 91 deletions

View File

@ -9,6 +9,7 @@ set(FLOW_SRCS
CompressedInt.h
Deque.cpp
Deque.h
DeterministicRandom.cpp
DeterministicRandom.h
Error.cpp
Error.h

View File

@ -0,0 +1,122 @@
/*
* DeterministicRandom.cpp
*
* This source file is part of the FoundationDB open source project
*
* Copyright 2013-2018 Apple Inc. and the FoundationDB project authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "flow/DeterministicRandom.h"
uint64_t DeterministicRandom::gen64() {
uint64_t curr = next;
next = (uint64_t(random()) << 32) ^ random();
if (TRACE_SAMPLE()) TraceEvent(SevSample, "Random");
return curr;
}
DeterministicRandom::DeterministicRandom(uint32_t seed, bool useRandLog)
: random((unsigned long)seed), next((uint64_t(random()) << 32) ^ random()), useRandLog(useRandLog) {
UNSTOPPABLE_ASSERT(seed != 0); // docs for mersenne twister say x0>0
};
double DeterministicRandom::random01() {
double d = gen64() / double(uint64_t(-1));
if (randLog && useRandLog) fprintf(randLog, "R01 %f\n", d);
return d;
}
int DeterministicRandom::randomInt(int min, int maxPlusOne) {
ASSERT(min < maxPlusOne);
unsigned int range;
if (maxPlusOne < 0)
range = std::abs(maxPlusOne - min);
else {
range = maxPlusOne;
range -= min;
}
uint64_t v = (gen64() % range);
int i;
if (min < 0 && ((unsigned int)-min) > v)
i = -(int)(((unsigned int)-min) - v);
else
i = v + min;
if (randLog && useRandLog) fprintf(randLog, "Rint %d\n", i);
return i;
}
int64_t DeterministicRandom::randomInt64(int64_t min, int64_t maxPlusOne) {
ASSERT(min < maxPlusOne);
uint64_t range;
if (maxPlusOne < 0)
range = std::abs(maxPlusOne - min);
else {
range = maxPlusOne;
range -= min;
}
uint64_t v = (gen64() % range);
int64_t i;
if (min < 0 && ((uint64_t)-min) > v)
i = -(int64_t)(((uint64_t)-min) - v);
else
i = v + min;
if (randLog && useRandLog) fprintf(randLog, "Rint64 %" PRId64 "\n", i);
return i;
}
uint32_t DeterministicRandom::randomUInt32() {
return gen64();
}
uint32_t DeterministicRandom::randomSkewedUInt32(uint32_t min, uint32_t maxPlusOne) {
std::uniform_real_distribution<double> distribution(std::log(min), std::log(maxPlusOne - 1));
double logpower = distribution(random);
uint32_t loguniform = static_cast<uint32_t>(std::pow(10, logpower));
// doubles can be imprecise, so let's make sure we don't violate an edge case.
return std::max(std::min(loguniform, maxPlusOne - 1), min);
}
UID DeterministicRandom::randomUniqueID() {
uint64_t x, y;
x = gen64();
y = gen64();
if (randLog && useRandLog) fprintf(randLog, "Ruid %" PRIx64 " %" PRIx64 "\n", x, y);
return UID(x, y);
}
char DeterministicRandom::randomAlphaNumeric() {
static const char alphanum[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
char c = alphanum[gen64() % 62];
if (randLog && useRandLog) fprintf(randLog, "Rchar %c\n", c);
return c;
}
std::string DeterministicRandom::randomAlphaNumeric(int length) {
std::string s;
s.reserve(length);
for (int i = 0; i < length; i++) s += randomAlphaNumeric();
return s;
}
uint64_t DeterministicRandom::peek() const {
return next;
}
void DeterministicRandom::addref() {
ReferenceCounted<DeterministicRandom>::addref();
}
void DeterministicRandom::delref() {
ReferenceCounted<DeterministicRandom>::delref();
}

View File

@ -36,99 +36,21 @@ private:
uint64_t next;
bool useRandLog;
uint64_t gen64() {
uint64_t curr = next;
next = (uint64_t(random()) << 32) ^ random();
if (TRACE_SAMPLE()) TraceEvent(SevSample, "Random");
return curr;
}
uint64_t gen64();
public:
DeterministicRandom( uint32_t seed, bool useRandLog=false ) : random( (unsigned long)seed ), next( (uint64_t(random()) << 32) ^ random() ), useRandLog(useRandLog) {
UNSTOPPABLE_ASSERT( seed != 0 ); // docs for mersenne twister say x0>0
};
double random01() {
double d = gen64() / double(uint64_t(-1));
if (randLog && useRandLog) fprintf(randLog, "R01 %f\n", d);
return d;
}
int randomInt(int min, int maxPlusOne) {
ASSERT(min < maxPlusOne);
unsigned int range;
if (maxPlusOne < 0)
range = std::abs(maxPlusOne - min);
else {
range = maxPlusOne;
range -= min;
}
uint64_t v = (gen64() % range);
int i;
if (min < 0 && ((unsigned int) -min) > v)
i = -(int)(((unsigned int) -min) - v);
else
i = v + min;
if (randLog && useRandLog) fprintf(randLog, "Rint %d\n", i);
return i;
}
int64_t randomInt64(int64_t min, int64_t maxPlusOne) {
ASSERT(min < maxPlusOne);
uint64_t range;
if (maxPlusOne < 0)
range = std::abs(maxPlusOne - min);
else {
range = maxPlusOne;
range -= min;
}
uint64_t v = (gen64() % range);
int64_t i;
if (min < 0 && ((uint64_t) -min) > v)
i = -(int64_t)(((uint64_t) -min) - v);
else
i = v + min;
if (randLog && useRandLog) fprintf(randLog, "Rint64 %" PRId64 "\n", i);
return i;
}
uint32_t randomUInt32() { return gen64(); }
uint32_t randomSkewedUInt32(uint32_t min, uint32_t maxPlusOne) {
std::uniform_real_distribution<double> distribution( std::log(min), std::log(maxPlusOne-1) );
double logpower = distribution(random);
uint32_t loguniform = static_cast<uint32_t>( std::pow( 10, logpower ) );
// doubles can be imprecise, so let's make sure we don't violate an edge case.
return std::max(std::min(loguniform, maxPlusOne-1), min);
}
UID randomUniqueID() {
uint64_t x,y;
x = gen64();
y = gen64();
if (randLog && useRandLog) fprintf(randLog, "Ruid %" PRIx64 " %" PRIx64 "\n", x, y);
return UID(x,y);
}
char randomAlphaNumeric() {
static const char alphanum[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
char c = alphanum[ gen64() % 62 ];
if (randLog && useRandLog) fprintf(randLog, "Rchar %c\n", c);
return c;
}
std::string randomAlphaNumeric( int length ) {
std::string s;
s.reserve( length );
for( int i = 0; i < length; i++ )
s += randomAlphaNumeric();
return s;
}
uint64_t peek() const { return next; }
virtual void addref() { ReferenceCounted<DeterministicRandom>::addref(); }
virtual void delref() { ReferenceCounted<DeterministicRandom>::delref(); }
DeterministicRandom(uint32_t seed, bool useRandLog = false);
double random01() override;
int randomInt(int min, int maxPlusOne) override;
int64_t randomInt64(int64_t min, int64_t maxPlusOne) override;
uint32_t randomUInt32() override;
uint32_t randomSkewedUInt32(uint32_t min, uint32_t maxPlusOne) override;
UID randomUniqueID() override;
char randomAlphaNumeric() override;
std::string randomAlphaNumeric(int length) override;
uint64_t peek() const override;
void addref() override;
void delref() override;
};
#endif

View File

@ -14,6 +14,7 @@
<ActorCompiler Include="TDMetric.actor.h" />
</ItemGroup>
<ItemGroup>
<ClCompile Include="DeterministicRandom.cpp" />
<ClCompile Include="Error.cpp" />
<ClCompile Include="FastAlloc.cpp" />
<ClCompile Include="Hash3.c" />