wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
This commit is contained in:
Markus Pilman 2021-10-08 11:22:27 -06:00
parent ffdba4a133
commit 4e723ba3d9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fdbclient/NativeAPI.actor.cpp
View File

@ -732,10 +732,10 @@ ACTOR static Future<Void> monitorProxiesChange(DatabaseContext* cx,
// 2. If the old set of Grv proxies is empty, there's nothing to do
// 3. If the new set of Grv proxies is empty, it means the recovery is not complete. So if an old
// Grv proxy still gives out read versions, this would be correct behavior.
// 4. If we see a provisionoal proxy, it means the recovery didn't complete yet, so the same as (3)
// 4. If we see a provisional proxy, it means the recovery didn't complete yet, so the same as (3)
// applies.
if (deterministicRandom()->random01() < cx->verifyCausalReadsProp && !curGrvProxies.empty() &&
!curGrvProxies.empty() && !clientDBInfo->get().grvProxies.empty() &&
!clientDBInfo->get().grvProxies.empty() &&
!clientDBInfo->get().grvProxies[0].provisional) {
actors.add(attemptGRVFromOldProxies(curGrvProxies, clientDBInfo->get().grvProxies));
}

2
fdbclient/vexillographer/fdb.options
View File

@ -201,7 +201,7 @@ description is not currently required but encouraged.
<Option name="use_config_database" code="800"
description="Use configuration database." />
<Option name="test_causal_read_risky" code="900"
description="An integer between 0 and 100 (default is 0) expression the probability that a client will verify it can't read stale data whenever it detects a recovery." />
description="An integer between 0 and 100 (default is 0) expressing the probability that a client will verify it can't read stale data whenever it detects a recovery." />
</Scope>
<Scope name="TransactionOption">