Merge pull request #4635 from RenxuanW/priority_logging

Log a warning when remote dc is disabled (priority < 0)
This commit is contained in:
RenxuanW 2021-04-15 17:00:41 -07:00 committed by GitHub
commit 4bf7218e8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions

View File

@ -1133,9 +1133,15 @@ public:
std::swap(regions[0], regions[1]);
}
if (regions[1].dcId == clusterControllerDcId.get() && regions[1].priority >= 0 &&
if (regions[1].dcId == clusterControllerDcId.get() &&
(!versionDifferenceUpdated || datacenterVersionDifference >= SERVER_KNOBS->MAX_VERSION_DIFFERENCE)) {
std::swap(regions[0], regions[1]);
if (regions[1].priority >= 0) {
std::swap(regions[0], regions[1]);
} else {
TraceEvent(SevWarnAlways, "CCDcPriorityNegative")
.detail("DcId", regions[1].dcId)
.detail("Priority", regions[1].priority);
}
}
bool setPrimaryDesired = false;