wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove fdb_get_server_protocol from the Python bindings. This C function this was using recently moved and changed signature, so it no longer works in Python.

This commit is contained in:
A.J. Beamon 2021-04-16 13:48:44 -07:00
parent e7d4a452e4
commit 4a1a55f270
3 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bindings/c/test/unit/unit_tests.cpp
View File

@ -1513,7 +1513,7 @@ TEST_CASE("fdb_transaction_get_approximate_size") {
} }
} }
TEST_CASE("fdb_get_server_protocol") { TEST_CASE("fdb_database_get_server_protocol") {
// We don't really have any expectations other than "don't crash" here // We don't really have any expectations other than "don't crash" here
FDBFuture* protocolFuture = fdb_database_get_server_protocol(db, 0); FDBFuture* protocolFuture = fdb_database_get_server_protocol(db, 0);
uint64_t out; uint64_t out;

1
bindings/python/fdb/__init__.py
View File

@ -95,7 +95,6 @@ def api_version(ver):
'transactional', 'transactional',
'options', 'options',
'StreamingMode', 'StreamingMode',
'get_server_protocol'
) )
_add_symbols(fdb.impl, list) _add_symbols(fdb.impl, list)

10
bindings/python/fdb/impl.py
View File

@ -1531,9 +1531,6 @@ def init_c_api():
_capi.fdb_transaction_get_approximate_size.argtypes = [ctypes.c_void_p] _capi.fdb_transaction_get_approximate_size.argtypes = [ctypes.c_void_p]
_capi.fdb_transaction_get_approximate_size.restype = ctypes.c_void_p _capi.fdb_transaction_get_approximate_size.restype = ctypes.c_void_p
_capi.fdb_get_server_protocol.argtypes = [ctypes.c_char_p]
_capi.fdb_get_server_protocol.restype = ctypes.c_void_p
_capi.fdb_transaction_get_versionstamp.argtypes = [ctypes.c_void_p] _capi.fdb_transaction_get_versionstamp.argtypes = [ctypes.c_void_p]
_capi.fdb_transaction_get_versionstamp.restype = ctypes.c_void_p _capi.fdb_transaction_get_versionstamp.restype = ctypes.c_void_p
@ -1733,13 +1730,6 @@ open_databases = {}
cacheLock = threading.Lock() cacheLock = threading.Lock()
def get_server_protocol(clusterFilePath=None):
with _network_thread_reentrant_lock:
if not _network_thread:
init()
return FutureUInt64(_capi.fdb_get_server_protocol(optionalParamToBytes(clusterFilePath)[0]))
def open(cluster_file=None, event_model=None): def open(cluster_file=None, event_model=None):
"""Opens the given database (or the default database of the cluster indicated """Opens the given database (or the default database of the cluster indicated
by the fdb.cluster file in a platform-specific location, if no cluster_file by the fdb.cluster file in a platform-specific location, if no cluster_file