wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimization, only the first btree mutation boundary for a subtree needs to be compared to the subtree's lower bound. Also removed a check for a condition which is no longer possible due to other changes.

This commit is contained in:
Stephen Atherton 2019-10-28 16:05:11 -07:00
parent 0d993522d3
commit 40d53e23f5
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fdbserver/VersionedBTree.actor.cpp
View File

@ -3495,24 +3495,22 @@ private:
int changes = 0;
// Now, process each mutation range and merge changes with existing data.
bool firstMutationBoundary = true;
while(iMutationBoundary != iMutationBoundaryEnd) {
debug_printf("%s New mutation boundary: '%s': %s\n", context.c_str(), printable(iMutationBoundary->first).c_str(), iMutationBoundary->second.toString().c_str());
SingleKeyMutationsByVersion::const_iterator iMutations;
// If the mutation boundary key is less than the lower bound key then skip startKeyMutations for
// this bounary, we're only processing this mutation range here to apply any clears to existing data.
if(iMutationBoundary->first < lowerBound->key) {
// For the first mutation boundary only, if the boundary key is less than the lower bound for the page
// then skip startKeyMutations for this boundary, we're only processing this mutation range here to apply
// a possible clear to existing data.
if(firstMutationBoundary && iMutationBoundary->first < lowerBound->key) {
iMutations = iMutationBoundary->second.startKeyMutations.end();
}
// If the mutation boundary key is the same as the page lowerBound key then start reading single
// key mutations at the first version greater than the lowerBound key's version.
else if(!self->singleVersion && iMutationBoundary->first == lowerBound->key) {
iMutations = iMutationBoundary->second.startKeyMutations.upper_bound(lowerBound->version);
}
else {
iMutations = iMutationBoundary->second.startKeyMutations.begin();
}
firstMutationBoundary = false;
SingleKeyMutationsByVersion::const_iterator iMutationsEnd = iMutationBoundary->second.startKeyMutations.end();