From ba9f203858879705135a3afce32dc7bf1ebcbbbd Mon Sep 17 00:00:00 2001 From: Alvin Moore Date: Tue, 11 Aug 2020 03:26:56 -0400 Subject: [PATCH 1/2] Fixed warnings for documentation greater than and less than characters which appear as errors within Java 1.8 Removed broken link --- .../tuple/FastByteComparisons.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java b/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java index 83f5f399de..e71840c880 100644 --- a/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java +++ b/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java @@ -30,7 +30,7 @@ import sun.misc.Unsafe; /** * Utility code to do optimized byte-array comparison. - * This is borrowed and slightly modified from Guava's {@link UnsignedBytes} + * This is borrowed and slightly modified from Guava's UnsignedBytes * class to be able to compare arrays that start at non-zero offsets. */ abstract class FastByteComparisons { @@ -38,14 +38,14 @@ abstract class FastByteComparisons { private static final int UNSIGNED_MASK = 0xFF; /** * Lexicographically compare two byte arrays. - * + * * @param buffer1 left operand, expected to not be null * @param buffer2 right operand, expected to not be null - * @param offset1 Where to start comparing in the left buffer, expected to be >= 0 - * @param offset2 Where to start comparing in the right buffer, expected to be >= 0 - * @param length1 How much to compare from the left buffer, expected to be >= 0 - * @param length2 How much to compare from the right buffer, expected to be >= 0 - * @return 0 if equal, < 0 if left is less than right, etc. + * @param offset1 Where to start comparing in the left buffer, expected to be &rt;= 0 + * @param offset2 Where to start comparing in the right buffer, expected to be &rt;= 0 + * @param length1 How much to compare from the left buffer, expected to be &rt;= 0 + * @param length2 How much to compare from the right buffer, expected to be &rt;= 0 + * @return 0 if equal, < 0 if left is less than right, etc. */ public static int compareTo(byte[] buffer1, int offset1, int length1, byte[] buffer2, int offset2, int length2) { @@ -59,7 +59,7 @@ abstract class FastByteComparisons { interface Comparer extends Comparator { /** * Lexicographically compare two byte arrays. - * + * * @param buffer1 left operand * @param buffer2 right operand * @param offset1 Where to start comparing in the left buffer @@ -291,4 +291,4 @@ abstract class FastByteComparisons { } } } -} \ No newline at end of file +} From 19338267371c1e518c75b9982c47ed7485eb69d0 Mon Sep 17 00:00:00 2001 From: Alvin Moore Date: Tue, 11 Aug 2020 13:09:41 -0400 Subject: [PATCH 2/2] Fixed typos and removed extraneous space --- .../apple/foundationdb/tuple/FastByteComparisons.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java b/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java index e71840c880..10cbf24b96 100644 --- a/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java +++ b/bindings/java/src/main/com/apple/foundationdb/tuple/FastByteComparisons.java @@ -30,7 +30,7 @@ import sun.misc.Unsafe; /** * Utility code to do optimized byte-array comparison. - * This is borrowed and slightly modified from Guava's UnsignedBytes + * This is borrowed and slightly modified from Guava's UnsignedBytes * class to be able to compare arrays that start at non-zero offsets. */ abstract class FastByteComparisons { @@ -41,10 +41,10 @@ abstract class FastByteComparisons { * * @param buffer1 left operand, expected to not be null * @param buffer2 right operand, expected to not be null - * @param offset1 Where to start comparing in the left buffer, expected to be &rt;= 0 - * @param offset2 Where to start comparing in the right buffer, expected to be &rt;= 0 - * @param length1 How much to compare from the left buffer, expected to be &rt;= 0 - * @param length2 How much to compare from the right buffer, expected to be &rt;= 0 + * @param offset1 Where to start comparing in the left buffer, expected to be >= 0 + * @param offset2 Where to start comparing in the right buffer, expected to be >= 0 + * @param length1 How much to compare from the left buffer, expected to be >= 0 + * @param length2 How much to compare from the right buffer, expected to be >= 0 * @return 0 if equal, < 0 if left is less than right, etc. */ public static int compareTo(byte[] buffer1, int offset1, int length1,