wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change from logging point value to logging histogram.

This commit is contained in:
Xin Dong 2020-12-18 16:33:46 -08:00
parent 15ac27ef94
commit 35e8bf3ec7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fdbserver/MasterProxyServer.actor.cpp
View File

@ -65,7 +65,6 @@ struct ProxyStats {
Version lastCommitVersionAssigned; Version lastCommitVersionAssigned;
double transactionRateAllowed, batchTransactionRateAllowed; double transactionRateAllowed, batchTransactionRateAllowed;
double transactionLimit, batchTransactionLimit; double transactionLimit, batchTransactionLimit;
double commitBatchInterval;
// how much of the GRV requests queue was processed in one attempt to hand out read version. // how much of the GRV requests queue was processed in one attempt to hand out read version.
double percentageOfDefaultGRVQueueProcessed; double percentageOfDefaultGRVQueueProcessed;
double percentageOfBatchGRVQueueProcessed; double percentageOfBatchGRVQueueProcessed;
@ -79,6 +78,8 @@ struct ProxyStats {
LatencyBands commitLatencyBands; LatencyBands commitLatencyBands;
LatencyBands grvLatencyBands; LatencyBands grvLatencyBands;
LatencySample commitBatchingWindowSize;
Future<Void> logger; Future<Void> logger;
explicit ProxyStats(UID id, Version* pVersion, NotifiedVersion* pCommittedVersion, explicit ProxyStats(UID id, Version* pVersion, NotifiedVersion* pCommittedVersion,
@ -102,6 +103,8 @@ struct ProxyStats {
SERVER_KNOBS->LATENCY_SAMPLE_SIZE), SERVER_KNOBS->LATENCY_SAMPLE_SIZE),
grvLatencySample("GRVLatencyMetrics", id, SERVER_KNOBS->LATENCY_METRICS_LOGGING_INTERVAL, grvLatencySample("GRVLatencyMetrics", id, SERVER_KNOBS->LATENCY_METRICS_LOGGING_INTERVAL,
SERVER_KNOBS->LATENCY_SAMPLE_SIZE), SERVER_KNOBS->LATENCY_SAMPLE_SIZE),
commitBatchingWindowSize("CommitBatchingWindowSize", id, SERVER_KNOBS->LATENCY_METRICS_LOGGING_INTERVAL,
SERVER_KNOBS->LATENCY_SAMPLE_SIZE),
commitLatencyBands("CommitLatencyBands", id, SERVER_KNOBS->STORAGE_LOGGING_DELAY), commitLatencyBands("CommitLatencyBands", id, SERVER_KNOBS->STORAGE_LOGGING_DELAY),
grvLatencyBands("GRVLatencyBands", id, SERVER_KNOBS->STORAGE_LOGGING_DELAY), grvLatencyBands("GRVLatencyBands", id, SERVER_KNOBS->STORAGE_LOGGING_DELAY),
defaultTxnGRVTimeInQueue("DefaultTxnGRVTimeInQueue", id, SERVER_KNOBS->LATENCY_METRICS_LOGGING_INTERVAL, defaultTxnGRVTimeInQueue("DefaultTxnGRVTimeInQueue", id, SERVER_KNOBS->LATENCY_METRICS_LOGGING_INTERVAL,
@ -123,7 +126,6 @@ struct ProxyStats {
[this]() { return this->percentageOfDefaultGRVQueueProcessed; }); [this]() { return this->percentageOfDefaultGRVQueueProcessed; });
specialCounter(cc, "PercentageOfBatchGRVQueueProcessed", specialCounter(cc, "PercentageOfBatchGRVQueueProcessed",
[this]() { return this->percentageOfBatchGRVQueueProcessed; }); [this]() { return this->percentageOfBatchGRVQueueProcessed; });
specialCounter(cc, "DynamicCommitBatchWindow", [this]() { return this->commitBatchInterval; });
logger = traceCounters("ProxyMetrics", id, SERVER_KNOBS->WORKER_LOGGING_INTERVAL, &cc, "ProxyMetrics"); logger = traceCounters("ProxyMetrics", id, SERVER_KNOBS->WORKER_LOGGING_INTERVAL, &cc, "ProxyMetrics");
} }
}; };
@ -1255,7 +1257,7 @@ ACTOR Future<Void> commitBatch(
std::min(SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_MAX, std::min(SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_MAX,
target_latency * SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_SMOOTHER_ALPHA + self->commitBatchInterval * (1-SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_SMOOTHER_ALPHA))); target_latency * SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_SMOOTHER_ALPHA + self->commitBatchInterval * (1-SERVER_KNOBS->COMMIT_TRANSACTION_BATCH_INTERVAL_SMOOTHER_ALPHA)));
self->stats.commitBatchInterval = self->commitBatchInterval; self->stats.commitBatchingWindowSize.addMeasurement(self->commitBatchInterval);
self->commitBatchesMemBytesCount -= currentBatchMemBytesCount; self->commitBatchesMemBytesCount -= currentBatchMemBytesCount;
ASSERT_ABORT(self->commitBatchesMemBytesCount >= 0); ASSERT_ABORT(self->commitBatchesMemBytesCount >= 0);