wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4214 from dongxinEric/misc/log-when-lb-disabled-in-ss-fetchKeys 

Add a SevWarnAlways trace line to help debug a rare failure.
This commit is contained in:
Xin Dong 2021-01-22 10:45:06 -08:00 committed by GitHub
parent 9931ffbfdb faf571dc06
commit 245214acbf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fdbserver/storageserver.actor.cpp
View File

@ -2359,7 +2359,7 @@ ACTOR Future<Void> fetchKeys( StorageServer *data, AddingShard* shard ) {
//FIXME: remove when we no longer support upgrades from 5.X
if (debug_getRangeRetries >= 100) {
data->cx->enableLocalityLoadBalance = false;
// TODO: Add SevWarnAlways to say it was disabled.
TraceEvent(SevWarnAlways, "FKDisableLB").detail("FKID", fetchKeysID);
}
debug_getRangeRetries++;
@ -2378,6 +2378,7 @@ ACTOR Future<Void> fetchKeys( StorageServer *data, AddingShard* shard ) {
//FIXME: remove when we no longer support upgrades from 5.X
data->cx->enableLocalityLoadBalance = true;
TraceEvent(SevWarnAlways, "FKReenableLB").detail("FKID", fetchKeysID);
// We have completed the fetch and write of the data, now we wait for MVCC window to pass.
// As we have finished this work, we will allow more work to start...