From 1bd615f95454014536a00919496f692f79a08f4f Mon Sep 17 00:00:00 2001 From: Evan Tschannen Date: Tue, 13 Nov 2018 12:36:04 -0800 Subject: [PATCH] fix: remoteDcIds will not actually have transaction logs unless usable regions is > 1 --- fdbserver/masterserver.actor.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fdbserver/masterserver.actor.cpp b/fdbserver/masterserver.actor.cpp index 3cc03f89b0..a0dcce6cd6 100644 --- a/fdbserver/masterserver.actor.cpp +++ b/fdbserver/masterserver.actor.cpp @@ -1274,8 +1274,10 @@ ACTOR Future masterCore( Reference self ) { for(auto& dc : self->primaryDcId) { tr.set(recoveryCommitRequest.arena, tLogDatacentersKeyFor(dc), StringRef()); } - for(auto& dc : self->remoteDcIds) { - tr.set(recoveryCommitRequest.arena, tLogDatacentersKeyFor(dc), StringRef()); + if(self->configuration.usableRegions > 1) { + for(auto& dc : self->remoteDcIds) { + tr.set(recoveryCommitRequest.arena, tLogDatacentersKeyFor(dc), StringRef()); + } } applyMetadataMutations(self->dbgid, recoveryCommitRequest.arena, tr.mutations.slice(mmApplied, tr.mutations.size()), self->txnStateStore, NULL, NULL);