From 19d551d682b2bc8ff0f32b3e85703daa4d67aaee Mon Sep 17 00:00:00 2001
From: Junhyun Shim <junhyun.shim@snowflake.com>
Date: Fri, 26 Aug 2022 10:53:32 +0200
Subject: [PATCH] Revert "Prevent env knob strings from being copied at each
 iteration"

This reverts commit 3d70d3b47e9a416fa90a969ff702b87b3677d37f.
---
 fdbserver/fdbserver.actor.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fdbserver/fdbserver.actor.cpp b/fdbserver/fdbserver.actor.cpp
index 4284ebbbff..d66988d12c 100644
--- a/fdbserver/fdbserver.actor.cpp
+++ b/fdbserver/fdbserver.actor.cpp
@@ -1115,7 +1115,7 @@ private:
 	CLIOptions() = default;
 
 	void parseEnvInternal() {
-		for (const std::string& knob : getEnvironmentKnobOptions()) {
+		for (std::string knob : getEnvironmentKnobOptions()) {
 			auto pos = knob.find_first_of("=");
 			if (pos == std::string::npos) {
 				fprintf(stderr,
@@ -2065,7 +2065,7 @@ int main(int argc, char* argv[]) {
 		}
 
 		std::string environmentKnobOptions;
-		for (const std::string& knobOption : getEnvironmentKnobOptions()) {
+		for (std::string knobOption : getEnvironmentKnobOptions()) {
 			environmentKnobOptions += knobOption + " ";
 		}
 		if (environmentKnobOptions.length()) {