wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stop roll trace events for instances that are no longer running 

Description

Testing
This commit is contained in:
Chang Liu 2021-09-20 21:58:44 +00:00 committed by A.J. Beamon
parent be363f4d81
commit 1817f2ea02
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fdbserver/Ratekeeper.actor.cpp
View File

@ -32,7 +32,6 @@
#include "fdbserver/ServerDBInfo.h"
#include "fdbserver/WaitFailure.h"
#include "flow/actorcompiler.h" // This must be the last #include.
#include <memory>
enum limitReason_t {
unlimited, // TODO: rename to workload?
@ -528,8 +527,7 @@ struct RatekeeperLimits {
SERVER_KNOBS->MAX_READ_TRANSACTION_LIFE_VERSIONS), // The read transaction life versions are expected to not
// be durable on the storage servers
lastDurabilityLag(0), durabilityLagLimit(std::numeric_limits<double>::infinity()), priority(priority),
context(context),
rkUpdateEventCacheHolder(makeReference<EventCacheHolder>("RkUpdate"+context)){}
context(context), rkUpdateEventCacheHolder(makeReference<EventCacheHolder>("RkUpdate" + context)) {}
};
namespace RatekeeperActorCpp {
@ -582,7 +580,7 @@ struct RatekeeperData {
bool autoThrottlingEnabled;
std::vector<std::shared_ptr<Reference<EventCacheHolder>>> storageQueueInfoHolder;
std::vector<Reference<EventCacheHolder>> storageQueueInfoHolder;
RatekeeperData(UID id, Database db)
: id(id), db(db), smoothReleasedTransactions(SERVER_KNOBS->SMOOTHING_AMOUNT),
@ -923,8 +921,8 @@ Future<Void> refreshStorageServerCommitCost(RatekeeperData* self) {
it->value.busiestWriteTagRate = maxRate;
}
auto tempEventCacheHolderPtr = std::make_shared<Reference<EventCacheHolder>>(makeReference<EventCacheHolder>(it->key.toString() + "/BusiestWriteTag"));
self->storageQueueInfoHolder.push_back(tempEventCacheHolderPtr);
auto tempEventCacheHolder = makeReference<EventCacheHolder>(it->key.toString() + "/BusiestWriteTag");
self->storageQueueInfoHolder.emplace_back(tempEventCacheHolder);
TraceEvent("BusiestWriteTag", it->key)
.detail("Elapsed", elapsed)
.detail("Tag", printable(busiestTag))
@ -932,7 +930,7 @@ Future<Void> refreshStorageServerCommitCost(RatekeeperData* self) {
.detail("TagCost", maxCost.getCostSum())
.detail("TotalCost", it->value.totalWriteCosts)
.detail("Reported", it->value.busiestWriteTag.present())
.trackLatest(tempEventCacheHolderPtr.get()->getPtr()->trackingKey);
.trackLatest(tempEventCacheHolder.getPtr()->trackingKey);
// reset statistics
it->value.tagCostEst.clear();