wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove debugging notes

This commit is contained in:
Zhe Wu 2023-08-09 10:12:18 -07:00
parent fb703c0021
commit 17ae952f15
3 changed files with 4 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/DDTeamCollection.actor.cpp
View File

@ -854,7 +854,7 @@ public:
bool recheck = !healthy && (lastReady != self->initialFailureReactionDelay.isReady() ||
(lastZeroHealthy && !self->zeroHealthyTeams->get()) || containsFailed);
TraceEvent("TeamHealthChangeDetected", self->distributorId)
TraceEvent(SevVerbose, "TeamHealthChangeDetected", self->distributorId)
.detail("Team", team->getDesc())
.detail("ServersLeft", serversLeft)
.detail("LastServersLeft", lastServersLeft)
@ -2398,9 +2398,8 @@ public:
state InitializeStorageRequest isr;
isr.storeType = recruitTss ? self->configuration.testingStorageServerStoreType
: self->configuration.storageServerStoreType;
if (self->configuration.perpetualStoreType.storeType() != KeyValueStoreType::END) {
if (!recruitTss && self->configuration.perpetualStoreType.storeType() != KeyValueStoreType::END) {
if (self->configuration.perpetualStorageWiggleLocality == "0") {
// TODO(wiggle) : consider adding a perpetual wiggle storage engine type for TSS.
isr.storeType = self->configuration.perpetualStoreType;
} else {
Optional<Value> localityKey;

4
fdbserver/include/fdbserver/ClusterController.actor.h
View File

@ -349,8 +349,7 @@ public:
std::set<AddressExclusion> excludedAddresses(req.excludeAddresses.begin(), req.excludeAddresses.end());
for (auto& it : id_worker) {
/*
TraceEvent("ZZZZZRecruitStorageTry")
TraceEvent(SevVerbose, "RecruitStorageTry")
.detail("Worker", it.second.details.interf.address())
.detail("WorkerAvailable", workerAvailable(it.second, false))
.detail("RecoverDiskFiles", it.second.details.recoveredDiskFiles)
@ -365,7 +364,6 @@ public:
it.second.details.processClass.machineClassFitness(ProcessClass::Storage) <=
ProcessClass::UnsetFit)
.detail("MachineFitness", it.second.details.processClass.machineClassFitness(ProcessClass::Storage));
*/
if (workerAvailable(it.second, false) && it.second.details.recoveredDiskFiles &&
!excludedMachines.count(it.second.details.interf.locality.zoneId()) &&
(includeDCs.size() == 0 || includeDCs.count(it.second.details.interf.locality.dcId())) &&

18
fdbserver/workloads/PerpetualWiggleStorageMigrationWorkload.actor.cpp
View File

@ -1,5 +1,5 @@
/*
* PerpetualWiggleStatsWorkload.actor.cpp
* PerpetualWiggleStorageMigrationWorkload.actor.cpp
*
* This source file is part of the FoundationDB open source project
*
@ -52,22 +52,6 @@ struct PerpetualWiggleStorageMigrationWorkload : public TestWorkload {
void disableFailureInjectionWorkloads(std::set<std::string>& out) const override { out.insert("all"); }
/*
ACTOR static Future<Void> _setup(PerpetualWiggleStorageMigrationWorkload* self, Database cx) {
// wait(success(setHealthyZone(cx, ignoreSSFailuresZoneString, 0)));
// bool success = wait(IssueConfigurationChange(cx, "storage_migration_type=disabled", true));
// ASSERT(success);
// wait(delay(30.0)); // make sure the DD has already quit before the test start
return Void();
}
Future<Void> setup(Database const& cx) override {
if (clientId == 0) {
return _setup(this, cx); // force to disable DD
}
return Void();
} */
Future<Void> start(Database const& cx) override {
if (clientId == 0) {
return _start(this, cx);