diff --git a/fdbserver/RestoreApplier.actor.cpp b/fdbserver/RestoreApplier.actor.cpp index 4832911291..2bef82d056 100644 --- a/fdbserver/RestoreApplier.actor.cpp +++ b/fdbserver/RestoreApplier.actor.cpp @@ -47,8 +47,8 @@ ACTOR Future restoreApplierCore(RestoreApplierInterface applierInterf, int state Future exitRole = Never(); state Future updateProcessStatsTimer = delay(SERVER_KNOBS->FASTRESTORE_UPDATE_PROCESS_STATS_INTERVAL); - actors.add(traceProcessMetrics(self, "Applier")); - actors.add(traceRoleVersionBatchProgress(self, "Applier")); + actors.add(traceProcessMetrics(self, "RestoreApplier")); + actors.add(traceRoleVersionBatchProgress(self, "RestoreApplier")); loop { state std::string requestTypeStr = "[Init]"; diff --git a/fdbserver/RestoreLoader.actor.cpp b/fdbserver/RestoreLoader.actor.cpp index 513742a217..3abfa1f060 100644 --- a/fdbserver/RestoreLoader.actor.cpp +++ b/fdbserver/RestoreLoader.actor.cpp @@ -67,7 +67,7 @@ ACTOR Future restoreLoaderCore(RestoreLoaderInterface loaderInterf, int no state Future exitRole = Never(); state Future updateProcessStatsTimer = delay(SERVER_KNOBS->FASTRESTORE_UPDATE_PROCESS_STATS_INTERVAL); - actors.add(traceProcessMetrics(self, "Loader")); + actors.add(traceProcessMetrics(self, "RestoreLoader")); loop { state std::string requestTypeStr = "[Init]"; diff --git a/fdbserver/RestoreMaster.actor.cpp b/fdbserver/RestoreMaster.actor.cpp index b35845d81d..4b9ac54c4f 100644 --- a/fdbserver/RestoreMaster.actor.cpp +++ b/fdbserver/RestoreMaster.actor.cpp @@ -81,6 +81,7 @@ ACTOR Future startRestoreMaster(Reference masterWorker, actors.add(updateHeartbeatTime(self)); actors.add(checkRolesLiveness(self)); + actors.add(traceProcessMetrics(self, "RestoreMaster")); wait(startProcessRestoreRequests(self, cx)); } catch (Error& e) { diff --git a/fdbserver/RestoreRoleCommon.actor.cpp b/fdbserver/RestoreRoleCommon.actor.cpp index dbd7fd6b7e..f8c75c8524 100644 --- a/fdbserver/RestoreRoleCommon.actor.cpp +++ b/fdbserver/RestoreRoleCommon.actor.cpp @@ -110,7 +110,8 @@ ACTOR Future isSchedulable(Reference self, int actorBatch } if (memory < memoryThresholdBytes || self->finishedBatch.get() + 1 == actorBatchIndex) { if (memory >= memoryThresholdBytes) { - TraceEvent(SevWarn, "FastRestoreMemoryUsageAboveThreshold") + TraceEvent(SevWarn, "FastRestoreMemoryUsageAboveThreshold", self->id()) + .detail("Role", getRoleStr(self->role)) .detail("BatchIndex", actorBatchIndex) .detail("FinishedBatch", self->finishedBatch.get()) .detail("Actor", name) @@ -119,10 +120,12 @@ ACTOR Future isSchedulable(Reference self, int actorBatch self->delayedActors--; break; } else { - TraceEvent(SevDebug, "FastRestoreMemoryUsageAboveThresholdWait") + TraceEvent(SevInfo, "FastRestoreMemoryUsageAboveThresholdWait", self->id()) + .detail("Role", getRoleStr(self->role)) .detail("BatchIndex", actorBatchIndex) .detail("Actor", name) .detail("CurrentMemory", memory); + // TODO: Set FASTRESTORE_WAIT_FOR_MEMORY_LATENCY to a large value. It should be able to avoided wait(delay(SERVER_KNOBS->FASTRESTORE_WAIT_FOR_MEMORY_LATENCY) || self->checkMemory.onTrigger()); } }