Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
/*
|
|
|
|
* RESTUtils.actor.cpp
|
|
|
|
*
|
|
|
|
* This source file is part of the FoundationDB open source project
|
|
|
|
*
|
|
|
|
* Copyright 2013-2022 Apple Inc. and the FoundationDB project authors
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "fdbrpc/RESTUtils.h"
|
|
|
|
|
|
|
|
#include "flow/flat_buffers.h"
|
|
|
|
#include "flow/UnitTest.h"
|
|
|
|
|
|
|
|
#include <boost/algorithm/string.hpp>
|
|
|
|
|
|
|
|
#include "flow/actorcompiler.h" // always the last include
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
std::unordered_set<std::string> protocols = { "http", "https" };
|
|
|
|
|
|
|
|
bool isProtocolSupported(const std::string& protocol) {
|
|
|
|
return protocols.find(protocol) != protocols.end();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool isSecurePrototol(const std::string& protocol) {
|
|
|
|
return protocol.compare("https") == 0;
|
|
|
|
}
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
RESTClientKnobs::RESTClientKnobs() {
|
|
|
|
secure_connection = RESTClientKnobs::SECURE_CONNECTION;
|
|
|
|
connection_pool_size = FLOW_KNOBS->RESTCLIENT_MAX_CONNECTIONPOOL_SIZE;
|
|
|
|
connect_tries = FLOW_KNOBS->RESTCLIENT_CONNECT_TRIES;
|
|
|
|
connect_timeout = FLOW_KNOBS->RESTCLIENT_CONNECT_TIMEOUT;
|
|
|
|
max_connection_life = FLOW_KNOBS->RESTCLIENT_MAX_CONNECTION_LIFE;
|
|
|
|
request_tries = FLOW_KNOBS->RESTCLIENT_REQUEST_TRIES;
|
|
|
|
request_timeout_secs = FLOW_KNOBS->RESTCLIENT_REQUEST_TIMEOUT_SEC;
|
|
|
|
|
|
|
|
knobMap["connection_pool_size"] = std::addressof(connection_pool_size);
|
|
|
|
knobMap["pz"] = std::addressof(connection_pool_size);
|
|
|
|
knobMap["secure_connection"] = std::addressof(secure_connection);
|
|
|
|
knobMap["sc"] = std::addressof(secure_connection);
|
|
|
|
knobMap["connect_tries"] = std::addressof(connect_tries);
|
|
|
|
knobMap["ct"] = std::addressof(connect_tries);
|
|
|
|
knobMap["connect_timeout"] = std::addressof(connect_timeout);
|
|
|
|
knobMap["cto"] = std::addressof(connect_timeout);
|
|
|
|
knobMap["max_connection_life"] = std::addressof(max_connection_life);
|
|
|
|
knobMap["mcl"] = std::addressof(max_connection_life);
|
|
|
|
knobMap["request_tries"] = std::addressof(request_tries);
|
|
|
|
knobMap["rt"] = std::addressof(request_tries);
|
|
|
|
knobMap["request_timeout_secs"] = std::addressof(request_timeout_secs);
|
|
|
|
knobMap["rtom"] = std::addressof(request_timeout_secs);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RESTClientKnobs::set(const std::unordered_map<std::string, int>& knobSettings) {
|
|
|
|
TraceEvent trace = TraceEvent("RESTClient_SetKnobs");
|
|
|
|
|
|
|
|
for (const auto& itr : knobSettings) {
|
|
|
|
const auto& kItr = RESTClientKnobs::knobMap.find(itr.first);
|
|
|
|
if (kItr == RESTClientKnobs::knobMap.end()) {
|
|
|
|
trace.detail("RESTClient_InvalidKnobName", itr.first);
|
|
|
|
throw rest_invalid_rest_client_knob();
|
|
|
|
}
|
|
|
|
*(kItr->second) = itr.second;
|
|
|
|
trace.detail(itr.first.c_str(), itr.second);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
std::unordered_map<std::string, int> RESTClientKnobs::get() const {
|
|
|
|
std::unordered_map<std::string, int> details = {
|
|
|
|
{ "connection_pool_size", connection_pool_size },
|
|
|
|
{ "secure_connection", secure_connection },
|
|
|
|
{ "connect_tries", connect_tries },
|
|
|
|
{ "connect_timeout", connect_timeout },
|
|
|
|
{ "max_connection_life", max_connection_life },
|
|
|
|
{ "request_tries", request_tries },
|
|
|
|
{ "request_timeout_secs", request_timeout_secs },
|
|
|
|
};
|
|
|
|
|
|
|
|
return details;
|
|
|
|
}
|
|
|
|
|
|
|
|
ACTOR Future<RESTConnectionPool::ReusableConnection> connect_impl(Reference<RESTConnectionPool> connectionPool,
|
|
|
|
RESTConnectionPoolKey connectKey,
|
|
|
|
bool isSecure,
|
|
|
|
int maxConnLife) {
|
|
|
|
auto poolItr = connectionPool->connectionPoolMap.find(connectKey);
|
|
|
|
if (poolItr == connectionPool->connectionPoolMap.end()) {
|
|
|
|
throw rest_connectpool_key_not_found();
|
|
|
|
}
|
|
|
|
|
|
|
|
while (!poolItr->second.empty()) {
|
|
|
|
RESTConnectionPool::ReusableConnection rconn = poolItr->second.front();
|
|
|
|
poolItr->second.pop();
|
|
|
|
|
|
|
|
if (rconn.expirationTime > now()) {
|
|
|
|
TraceEvent("RESTClient_ReusableConnection")
|
|
|
|
.suppressFor(60)
|
|
|
|
.detail("RemoteEndpoint", rconn.conn->getPeerAddress())
|
|
|
|
.detail("ExpireIn", rconn.expirationTime - now());
|
|
|
|
return rconn;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
state Reference<IConnection> conn =
|
|
|
|
wait(INetworkConnections::net()->connect(connectKey.first, connectKey.second, isSecure));
|
|
|
|
wait(conn->connectHandshake());
|
|
|
|
|
|
|
|
return RESTConnectionPool::ReusableConnection({ conn, now() + maxConnLife });
|
|
|
|
}
|
|
|
|
|
|
|
|
Future<RESTConnectionPool::ReusableConnection> RESTConnectionPool::connect(RESTConnectionPoolKey connectKey,
|
|
|
|
const bool isSecure,
|
|
|
|
const int maxConnLife) {
|
|
|
|
return connect_impl(Reference<RESTConnectionPool>::addRef(this), connectKey, isSecure, maxConnLife);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RESTConnectionPool::returnConnection(RESTConnectionPoolKey connectKey,
|
|
|
|
ReusableConnection& rconn,
|
|
|
|
const int maxConnections) {
|
|
|
|
auto poolItr = connectionPoolMap.find(connectKey);
|
|
|
|
if (poolItr == connectionPoolMap.end()) {
|
|
|
|
throw rest_connectpool_key_not_found();
|
|
|
|
}
|
|
|
|
|
|
|
|
// If it expires in the future then add it to the pool in the front iff connection pool size is not maxed
|
|
|
|
if (rconn.expirationTime > now() && poolItr->second.size() < maxConnections) {
|
|
|
|
poolItr->second.push(rconn);
|
|
|
|
}
|
|
|
|
rconn.conn = Reference<IConnection>();
|
|
|
|
}
|
|
|
|
|
|
|
|
RESTUrl::RESTUrl(const std::string& fUrl, const bool isSecure) {
|
|
|
|
parseUrl(fUrl, isSecure);
|
|
|
|
}
|
|
|
|
|
|
|
|
RESTUrl::RESTUrl(const std::string& fullUrl, const std::string& b, const bool isSecure) : body(b) {
|
|
|
|
parseUrl(fullUrl, isSecure);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RESTUrl::parseUrl(const std::string& fullUrl, const bool isSecure) {
|
|
|
|
// Sample valid URIs
|
|
|
|
// 1. With 'host' & 'resource' := '<protocol>://<host>/<resource>'
|
|
|
|
// 2. With 'host', 'service' & 'resource' := '<protocol>://<host>:port/<resource>'
|
|
|
|
// 3. With 'host', 'service', 'resource' & 'reqParameters' := '<protocol>://<host>:port/<resource>?<parameter-list>'
|
|
|
|
|
|
|
|
try {
|
|
|
|
StringRef t(fullUrl);
|
|
|
|
StringRef p = t.eat("://");
|
|
|
|
std::string protocol = p.toString();
|
|
|
|
boost::algorithm::to_lower(protocol);
|
|
|
|
if (!isProtocolSupported(protocol)) {
|
|
|
|
throw format("Invalid REST URI protocol '%s'", protocol.c_str());
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ensure connection secure knob setting matches with the input URI
|
|
|
|
if ((isSecurePrototol(protocol) && !isSecure) || (!isSecurePrototol(protocol) && isSecure)) {
|
|
|
|
throw format("Invalid REST URI protocol secure knob '%s'", fullUrl.c_str());
|
|
|
|
}
|
|
|
|
|
|
|
|
// extract 'resource' and optional 'parameter list' if supplied in the URL
|
|
|
|
uint8_t foundSeparator = 0;
|
|
|
|
StringRef hostPort = t.eatAny("/?", &foundSeparator);
|
|
|
|
if (foundSeparator == '/') {
|
|
|
|
resource = t.eat("?").toString();
|
|
|
|
reqParameters = t.eat().toString();
|
|
|
|
}
|
|
|
|
|
|
|
|
// hostPort is at least a host or IP address, optionally followed by :portNumber or :serviceName
|
|
|
|
StringRef hRef(hostPort);
|
|
|
|
StringRef h = hRef.eat(":");
|
|
|
|
if (h.size() == 0) {
|
|
|
|
throw std::string("host cannot be empty");
|
|
|
|
}
|
|
|
|
host = h.toString();
|
|
|
|
service = hRef.eat().toString();
|
|
|
|
|
|
|
|
TraceEvent("RESTClient_ParseURI")
|
|
|
|
.detail("URI", fullUrl)
|
|
|
|
.detail("Host", host)
|
|
|
|
.detail("Service", service)
|
|
|
|
.detail("Resource", resource)
|
|
|
|
.detail("ReqParameters", reqParameters);
|
|
|
|
} catch (std::string& err) {
|
|
|
|
TraceEvent("RESTClient_ParseError").detail("URI", fullUrl).detail("Error", err);
|
|
|
|
throw rest_invalid_uri();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Only used to link unit tests
|
|
|
|
void forceLinkRESTUtilsTests() {}
|
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/InvalidProtocol") {
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
try {
|
|
|
|
std::string uri("httpx://foo/bar");
|
|
|
|
RESTUrl r(uri, false);
|
|
|
|
ASSERT(false);
|
|
|
|
} catch (Error& e) {
|
|
|
|
if (e.code() != error_code_rest_invalid_uri) {
|
|
|
|
throw e;
|
|
|
|
}
|
|
|
|
}
|
2022-05-08 04:18:35 +08:00
|
|
|
return Void();
|
|
|
|
}
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/MismatchKnobVal") {
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
// mismatch protocol and knob values
|
|
|
|
try {
|
|
|
|
std::string uri("http://foo/bar");
|
|
|
|
RESTUrl r(uri, true);
|
|
|
|
ASSERT(false);
|
|
|
|
} catch (Error& e) {
|
|
|
|
if (e.code() != error_code_rest_invalid_uri) {
|
|
|
|
throw e;
|
|
|
|
}
|
|
|
|
}
|
2022-05-08 04:18:35 +08:00
|
|
|
return Void();
|
|
|
|
}
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/MissingHost") {
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
try {
|
|
|
|
std::string uri("https://:/bar");
|
|
|
|
RESTUrl r(uri, true);
|
|
|
|
ASSERT(false);
|
|
|
|
} catch (Error& e) {
|
|
|
|
if (e.code() != error_code_rest_invalid_uri) {
|
|
|
|
throw e;
|
|
|
|
}
|
|
|
|
}
|
2022-05-08 04:18:35 +08:00
|
|
|
return Void();
|
|
|
|
}
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/ValidURIWithService") {
|
|
|
|
std::string uri("https://host:80/foo/bar");
|
|
|
|
RESTUrl r(uri, true);
|
|
|
|
ASSERT_EQ(r.host.compare("host"), 0);
|
|
|
|
ASSERT_EQ(r.service.compare("80"), 0);
|
|
|
|
ASSERT_EQ(r.resource.compare("foo/bar"), 0);
|
|
|
|
return Void();
|
|
|
|
}
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/ValidURIWithoutService") {
|
|
|
|
std::string uri("https://host/foo/bar");
|
|
|
|
RESTUrl r(uri, true);
|
|
|
|
ASSERT_EQ(r.host.compare("host"), 0);
|
|
|
|
ASSERT(r.service.empty());
|
|
|
|
ASSERT_EQ(r.resource.compare("foo/bar"), 0);
|
|
|
|
return Void();
|
|
|
|
}
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
|
2022-05-08 04:18:35 +08:00
|
|
|
TEST_CASE("/RESTUtils/ValidURIWithParams") {
|
|
|
|
std::string uri("https://host/foo/bar?param1,param2");
|
|
|
|
RESTUrl r(uri, true);
|
|
|
|
ASSERT_EQ(r.host.compare("host"), 0);
|
|
|
|
ASSERT(r.service.empty());
|
|
|
|
ASSERT_EQ(r.resource.compare("foo/bar"), 0);
|
|
|
|
ASSERT_EQ(r.reqParameters.compare("param1,param2"), 0);
|
Interface to enable clients to send/receive REST requests/responses (#6866)
* Interface to enable clients to send/receive REST requests/responses
Description
Major changes:
1. Add RESTClient interface enabling client to send/receive REST HTTP
requests. Support REST APIs are: get, head, put, post, delete, trace
2. Add RESTUtil file introducing below interfaces:
2.1. RESTUrl - Extract URI information: host, service, request-parameters.
2.2. RESTConnectionPool-
Connection establishment, life-cycle management, connection-pool (TTL)
2.3. RESTClientKnobs - supports REST Knob parameter management and updates
Testing
Unit test - fdbrpc/RESTClient, fdbrpc/RESTUtils
2022-04-28 03:17:52 +08:00
|
|
|
return Void();
|
|
|
|
}
|