foundationdb/pull_request_template.md

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

19 lines
923 B
Markdown
Raw Normal View History

2021-03-13 04:47:26 +08:00
Put description here...
2020-11-07 06:06:01 +08:00
2021-03-13 04:46:04 +08:00
# Code-Reviewer Section
2021-03-16 05:41:16 +08:00
The general guidelines can be found [here](https://github.com/apple/foundationdb/wiki/FoundationDB-Commit-Process).
2020-11-07 06:06:01 +08:00
2021-03-13 06:49:03 +08:00
Please check each of the following things and check *all* boxes before accepting a PR.
2020-11-07 06:06:01 +08:00
2021-03-16 10:03:20 +08:00
- [ ] The PR has a description, explaining both the problem and the solution.
- [ ] The description mentions which forms of testing were done and the testing seems reasonable.
- [ ] Every function/class/actor that was touched is reasonably well documented.
2021-03-16 05:41:16 +08:00
## For Release-Branches
If this PR is made against a release-branch, please also check the following:
2022-04-11 15:53:33 +08:00
- [ ] This change/bugfix is a cherry-pick from the next younger branch (younger `release-branch` or `main` if this is the youngest branch)
2021-03-16 10:03:20 +08:00
- [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)