wbtiger
/
ByConity
mirror of https://github.com/ByConity/ByConity
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9975 from CurtizJ/tuple-literal 

Fix use-after-free at syntax error
This commit is contained in:
alexey-milovidov 2020-04-01 04:46:21 +03:00 committed by GitHub
parent a87de767a7 6e305b2ec1
commit 6eb3928567
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dbms/src/Parsers/ExpressionElementParsers.cpp
View File

@ -1026,8 +1026,7 @@ bool ParserCollectionOfLiterals<Collection>::parseImpl(Pos & pos, ASTPtr & node,
}
else
{
String message = String("comma or ") + getTokenName(closing_bracket);
expected.add(pos, message.c_str());
expected.add(pos, "comma or closing bracket");
return false;
}
}

2
dbms/tests/queries/0_stateless/01107_tuples_arrays_parsing_exceptions.reference Normal file
View File

@ -0,0 +1,2 @@
Syntax error
Syntax error

7
dbms/tests/queries/0_stateless/01107_tuples_arrays_parsing_exceptions.sh Executable file
View File

@ -0,0 +1,7 @@
#!/usr/bin/env bash
CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
. $CURDIR/../shell_config.sh
$CLICKHOUSE_CLIENT -q "SELECT (1, 2 2)" 2>&1 | grep -o "Syntax error"
$CLICKHOUSE_CLIENT -q "SELECT [1, 2 2]" 2>&1 | grep -o "Syntax error"