Fix spotless plugin run on CI and in Makefile (#3127)
## Issue
Spotless plugin run is failing on CI and the Makefile was updated after
the change:
35d8bee5db
## Change
- Set git clone depth to 0 for r`atchetFrom=origin/main` to work.
- Use spotless maven profile in Makefile
## General checklist
<!-- Please double-check the following points and mark them like this:
[X] -->
- [x] There are no breaking changes
- [ ] I have added unit and/or integration tests for my change
- [ ] The tests cover both positive and negative cases
- [x] I have manually run all the unit and integration tests in the
module I have added/changed, and they are all green
- [ ] I have manually run all the unit and integration tests in the
[core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core)
and
[main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j)
modules, and they are all green
<!-- Before adding documentation and example(s) (below), please wait
until the PR is reviewed and approved. -->
- [ ] I have added/updated the
[documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs)
- [ ] I have added an example in the [examples
repo](https://github.com/langchain4j/langchain4j-examples) (only for
"big" features)
- [ ] I have added/updated [Spring Boot
starter(s)](https://github.com/langchain4j/langchain4j-spring) (if
applicable)
## Checklist for adding new maven module
<!-- Please double-check the following points and mark them like this:
[X] -->
- [ ] I have added my new module in the root `pom.xml` and
`langchain4j-bom/pom.xml`
## Checklist for adding new embedding store integration
<!-- Please double-check the following points and mark them like this:
[X] -->
- [ ] I have added a `{NameOfIntegration}EmbeddingStoreIT` that extends
from either `EmbeddingStoreIT` or `EmbeddingStoreWithFilteringIT`
- [ ] I have added a `{NameOfIntegration}EmbeddingStoreRemovalIT` that
extends from `EmbeddingStoreWithRemovalIT`
## Checklist for changing existing embedding store integration
<!-- Please double-check the following points and mark them like this:
[X] -->
- [ ] I have manually verified that the
`{NameOfIntegration}EmbeddingStore` works correctly with the data
persisted using the latest released version of LangChain4j
Co-authored-by: Dmytro Liubarskyi <ljubarskij@gmail.com>
This commit is contained in:
parent
e1ee25994c
commit
cb7af71020
4
Makefile
4
Makefile
|
|
@ -7,9 +7,9 @@ build:
|
|||
# Analyze code for errors, potential issues, and coding standard violations.
|
||||
# Reports problems but does not modify the code.
|
||||
lint:
|
||||
mvn -T12C spotless:check -Pspotless
|
||||
mvn -T12C -Pspotless spotless:check
|
||||
|
||||
# Automatically format the code to conform to a style guide.
|
||||
# Modifies the code to ensure consistent formatting.
|
||||
format:
|
||||
mvn -T12C spotless:apply -Pspotless
|
||||
mvn -T12C -Pspotless spotless:apply
|
||||
|
|
|
|||
Loading…
Reference in New Issue