From 6f18b38c934de67fd936c562449cde1c7453c7fc Mon Sep 17 00:00:00 2001 From: LangChain4j Date: Fri, 26 Apr 2024 18:05:29 +0200 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 32 +++++++++++++++++++++++--------- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bb14ae17b..20057c876 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,10 +1,12 @@ Thank you for investing your time and effort in contributing to our project, we appreciate it a lot! 🤗 + # Current situation (25 April 2024) There are over 60 open PRs. Please help us by reviewing them first, before opening new ones. 🙏 + # General guidelines -- If you want to contribute a bug fix or a new feature that isn't listed in the [issues](https://github.com/langchain4j/langchain4j/issues) yet, please open a new issue for it and link it to your PR. +- If you want to contribute a bug fix or a new feature that isn't listed in the [issues](https://github.com/langchain4j/langchain4j/issues) yet, please open a new issue for it. We will prioritize is shortly. - Follow [Google's Best Practices for Java Libraries](https://jlbp.dev/) - Keep the code compatible with Java 8. We plan to increase the baseline to Java 17 a bit later. - Avoid adding new dependencies as much as possible. If absolutely necessary, try to use the same libraries which are already used in the project. @@ -15,27 +17,34 @@ There are over 60 open PRs. Please help us by reviewing them first, before openi - Follow existing code style present in the project. - Large features should be discussed with maintainers before implementation. Please ping @langchain4j in the comments on the issue. + # Priorities All [issues](https://github.com/langchain4j/langchain4j/issues) are prioritized by maintainers. There are 4 priorities: [P1](https://github.com/langchain4j/langchain4j/issues?q=is%3Aissue+is%3Aopen+label%3AP1), [P2](https://github.com/langchain4j/langchain4j/issues?q=is%3Aissue+is%3Aopen+label%3AP2), [P3](https://github.com/langchain4j/langchain4j/issues?q=is%3Aissue+is%3Aopen+label%3AP3) and [P4](https://github.com/langchain4j/langchain4j/issues?q=is%3Aissue+is%3Aopen+label%3AP4). Please start with the higher priorities. PRs will be reviewed in order of priority, with bugs being a higher priority than new features. -Please note that we do not have the capacity to review all PRs immediately. +Please note that we do not have the capacity to review PRs immediately. We ask for your patience. We are doing our best to review your PR as quickly as possible. + # Opening an issue - Please fill in all sections of the issue template. -# Opening a PR -- Link an [issue](https://github.com/langchain4j/langchain4j/issues) to your PR. If there is no issue yet, open one. + +# Opening a draft PR +- Please open the PR as a draft initially. Once it is reviewed and approved, we will then ask you to finalize it (see section below). - Fill in all the sections of the PR template. -- Make sure you've added tests. -- Make sure you've added documentation where required. -- For new big features, make sure you've added an example in the [examples repository](https://github.com/langchain4j/langchain4j-examples) (as a separate PR, linked to the main one). - Please make it easier to review your PR: - Keep changes as small as possible. - Do not combine refactoring with changes in a single PR. - Avoid reformatting existing code. + +# Finalizing the draft PR +- Add [documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs) (if required). +- Add an example to the [examples repository](https://github.com/langchain4j/langchain4j-examples) (if required). +- [Mark a PR as ready for review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review) + + # Guidelines on adding a new model integration - [Integration with Anthropic](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-anthropic) is a good example. - Use the official SDK if available. @@ -45,12 +54,17 @@ Please note that we do not have the capacity to review all PRs immediately. - Add a new module to the appropriate section of the [BOM](https://github.com/langchain4j/langchain4j/blob/main/langchain4j-bom/pom.xml). - It would be great if you could add a [Spring Boot starter](https://github.com/langchain4j/langchain4j-spring). + # Guidelines on adding a new embedding store integration - [Integration with Chroma](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-chroma) is a good example. - Use the official SDK if available. - If the official SDK is not available, use Retrofit and Gson to implement the client. -- `{IntegrationName}EmbeddingStoreIT` should extend from `EmbeddingStoreWithFilteringIT` or `EmbeddingStoreIT` and pass all tests. +- Add a `{IntegrationName}EmbeddingStoreIT`. It should extend from `EmbeddingStoreWithFilteringIT` or `EmbeddingStoreIT` and pass all tests. - Document the new integration [here](https://github.com/langchain4j/langchain4j/blob/main/README.md), [here](https://github.com/langchain4j/langchain4j/tree/main/docs/docs/integrations/embedding-stores) and [here](https://github.com/langchain4j/langchain4j/blob/main/docs/docs/integrations/embedding-stores/index.md). - Add an example to the [examples repository](https://github.com/langchain4j/langchain4j-examples), similar to [this](https://github.com/langchain4j/langchain4j-examples/tree/main/chroma-example). - Add a new module to the appropriate section of the [BOM](https://github.com/langchain4j/langchain4j/blob/main/langchain4j-bom/pom.xml). -- It would be great if you could add a [Spring Boot starter](https://github.com/langchain4j/langchain4j-spring). +- It would be great if you could add a [Spring Boot starter](https://github.com/langchain4j/langchain4j-spring). (after + + +# Guidelines on changing an existing embedding store integration +- Ensure that your changes are backwards compatible. `Embedding`s and `TextSegment`s persisted with the latest released version of LangChain4j should still work.