From 6981d6458e8eb31a247bb114792b2af4f5b05ab3 Mon Sep 17 00:00:00 2001 From: LangChain4j Date: Sun, 6 Oct 2024 19:32:07 +0200 Subject: [PATCH] Voyage AI: set default maxSegmentsPerBatch value to 128 --- .../model/voyageai/VoyageAiEmbeddingModel.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/langchain4j-voyage-ai/src/main/java/dev/langchain4j/model/voyageai/VoyageAiEmbeddingModel.java b/langchain4j-voyage-ai/src/main/java/dev/langchain4j/model/voyageai/VoyageAiEmbeddingModel.java index 964b688a4..61219bdb0 100644 --- a/langchain4j-voyage-ai/src/main/java/dev/langchain4j/model/voyageai/VoyageAiEmbeddingModel.java +++ b/langchain4j-voyage-ai/src/main/java/dev/langchain4j/model/voyageai/VoyageAiEmbeddingModel.java @@ -15,7 +15,6 @@ import java.util.List; import static dev.langchain4j.internal.RetryUtils.withRetry; import static dev.langchain4j.internal.Utils.getOrDefault; import static dev.langchain4j.internal.ValidationUtils.ensureNotBlank; -import static dev.langchain4j.internal.ValidationUtils.ensureNotNull; import static dev.langchain4j.model.voyageai.VoyageAiApi.DEFAULT_BASE_URL; import static java.time.Duration.ofSeconds; import static java.util.stream.Collectors.toList; @@ -32,7 +31,7 @@ public class VoyageAiEmbeddingModel extends DimensionAwareEmbeddingModel { private final String inputType; private final Boolean truncation; private final String encodingFormat; - private Integer maxSegmentsPerBatch; + private final Integer maxSegmentsPerBatch; public VoyageAiEmbeddingModel( String baseUrl, @@ -47,11 +46,9 @@ public class VoyageAiEmbeddingModel extends DimensionAwareEmbeddingModel { Boolean logResponses, Integer maxSegmentsPerBatch ) { - // Below attributes are force to non-null. this.maxRetries = getOrDefault(maxRetries, 3); this.modelName = ensureNotBlank(modelName, "modelName"); - this.maxSegmentsPerBatch = getOrDefault(maxSegmentsPerBatch, 1000); - // Below attributes can be null. + this.maxSegmentsPerBatch = getOrDefault(maxSegmentsPerBatch, 128); this.truncation = truncation; this.inputType = inputType; this.encodingFormat = encodingFormat; @@ -95,11 +92,7 @@ public class VoyageAiEmbeddingModel extends DimensionAwareEmbeddingModel { inputTokenCount += getTokenUsage(response); } - return Response.from( - embeddings, - new TokenUsage(inputTokenCount) - ); - + return Response.from(embeddings, new TokenUsage(inputTokenCount)); } @Override