From 76a34e2a20cf356a3c893b804d5c5d1470369654 Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits@users.noreply.github.com>
Date: Wed, 6 Mar 2024 10:44:08 -0500
Subject: [PATCH] Resolve type issues in redis cache (#1872)

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
---
 autogen/cache/redis_cache.py | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/autogen/cache/redis_cache.py b/autogen/cache/redis_cache.py
index 88f7a36b9a..37bb8b0050 100644
--- a/autogen/cache/redis_cache.py
+++ b/autogen/cache/redis_cache.py
@@ -1,7 +1,15 @@
 import pickle
+from types import TracebackType
+from typing import Any, Optional, Type
 import redis
+import sys
 from .abstract_cache_base import AbstractCache
 
+if sys.version_info >= (3, 11):
+    from typing import Self
+else:
+    from typing_extensions import Self
+
 
 class RedisCache(AbstractCache):
     """
@@ -24,7 +32,7 @@ class RedisCache(AbstractCache):
         __exit__(self, exc_type, exc_value, traceback): Context management exit.
     """
 
-    def __init__(self, seed, redis_url):
+    def __init__(self, seed: str, redis_url: str):
         """
         Initialize the RedisCache instance.
 
@@ -36,7 +44,7 @@ class RedisCache(AbstractCache):
         self.seed = seed
         self.cache = redis.Redis.from_url(redis_url)
 
-    def _prefixed_key(self, key):
+    def _prefixed_key(self, key: str) -> str:
         """
         Get a namespaced key for the cache.
 
@@ -48,7 +56,7 @@ class RedisCache(AbstractCache):
         """
         return f"autogen:{self.seed}:{key}"
 
-    def get(self, key, default=None):
+    def get(self, key: str, default: Optional[Any] = None) -> Any:
         """
         Retrieve an item from the Redis cache.
 
@@ -65,7 +73,7 @@ class RedisCache(AbstractCache):
             return default
         return pickle.loads(result)
 
-    def set(self, key, value):
+    def set(self, key: str, value: Any) -> None:
         """
         Set an item in the Redis cache.
 
@@ -79,7 +87,7 @@ class RedisCache(AbstractCache):
         serialized_value = pickle.dumps(value)
         self.cache.set(self._prefixed_key(key), serialized_value)
 
-    def close(self):
+    def close(self) -> None:
         """
         Close the Redis client.
 
@@ -87,7 +95,7 @@ class RedisCache(AbstractCache):
         """
         self.cache.close()
 
-    def __enter__(self):
+    def __enter__(self) -> Self:
         """
         Enter the runtime context related to the object.
 
@@ -96,7 +104,9 @@ class RedisCache(AbstractCache):
         """
         return self
 
-    def __exit__(self, exc_type, exc_value, traceback):
+    def __exit__(
+        self, exc_type: Optional[Type[BaseException]], exc_val: Optional[BaseException], exc_tb: Optional[TracebackType]
+    ) -> None:
         """
         Exit the runtime context related to the object.