!39681 clean code warning

Merge pull request !39681 from jiahongQian/master
This commit is contained in:
i-robot 2022-08-05 01:26:45 +00:00 committed by Gitee
commit 70c886d2d3
No known key found for this signature in database
GPG Key ID: 173E9B9CA92EEF8F
4 changed files with 7 additions and 7 deletions

View File

@ -211,7 +211,7 @@ Status GroupManager::CreateGroup(const std::string &group_name, const std::vecto
}
}
Status GroupManager::DestroyGroup(const std::string &group_name) {
Status GroupManager::DestroyGroup(const std::string &group_name) const {
auto context_ptr = MsContext::GetInstance();
MS_EXCEPTION_IF_NULL(context_ptr);
std::string device_name = context_ptr->get_param<std::string>(MS_CTX_DEVICE_TARGET);

View File

@ -70,7 +70,7 @@ class GroupManager {
bool CreateGroupByExecutor(const std::string &device_name, const std::string &group_name,
const std::vector<uint32_t> ranks, uint32_t device_id) const;
bool DestroyGroupByExecutor(const std::string &device_name, const std::string &group_name, uint32_t device_id) const;
Status DestroyGroup(const std::string &group_name);
Status DestroyGroup(const std::string &group_name) const;
// the key is group name (name_)
std::map<std::string, Group> groups_;
std::string world_group_;

View File

@ -64,7 +64,7 @@ Status BiasAddInfo::InferTensorMap() {
for (size_t i = 0; i < sub_a_strategy_size; ++i) {
sub_a_tensor_map.push_back(static_cast<int64_t>(LAST_INDEX(sub_a_strategy_size) - i));
}
sub_b_tensor_map.push_back(static_cast<int64_t>(LAST_INDEX(sub_a_strategy_size) - static_cast<size_t>(1)));
sub_b_tensor_map.push_back(static_cast<int64_t>(LAST_INDEX(sub_a_strategy_size) - static_cast<int64_t>(1)));
inputs_tensor_map_.push_back(sub_a_tensor_map);
inputs_tensor_map_.push_back(sub_b_tensor_map);

View File

@ -33,16 +33,16 @@ namespace parallel {
class MatMulBase : public OperatorInfo {
public:
// Generate all strategies and the corresponding cost for this MatMul operator
MatMulBase(const std::string &name, const Shapes &inputs_shape, const Shapes &outputs_shape,
const PrimitiveAttrs &attrs)
: OperatorInfo(name, inputs_shape, outputs_shape, attrs, std::make_shared<MatMulCost>()) {}
~MatMulBase() override = default;
std::vector<StrategyPtr> GenerateOpStrategies(int64_t stage_id) override;
Status SetCostUnderStrategy(const StrategyPtr &strategy) override;
Status SwapLastTwoElements(Shape *const input);
Shapes InferParamStrategy(const Shapes &default_strategy) override;
protected:
MatMulBase(const std::string &name, const Shapes &inputs_shape, const Shapes &outputs_shape,
const PrimitiveAttrs &attrs)
: OperatorInfo(name, inputs_shape, outputs_shape, attrs, std::make_shared<MatMulCost>()) {}
~MatMulBase() override = default;
Status InferForwardCommunication() override;
Status InferTensorInfo() override; // the forward_reduce_scatter mode need to override this function
Status InferDevMatrixShape() override;