From a9ee95737d8f5a614a70764141e260ef26d3013f Mon Sep 17 00:00:00 2001 From: liuchongming Date: Thu, 12 May 2022 13:10:45 +0800 Subject: [PATCH] Update pull request template. --- .gitee/PULL_REQUEST_TEMPLATE.md | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.gitee/PULL_REQUEST_TEMPLATE.md b/.gitee/PULL_REQUEST_TEMPLATE.md index df8034c5c15..710c0f9b237 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.md @@ -23,6 +23,28 @@ Usage: `Fixes #`, or `Fixes (paste link of issue)`. --> Fixes # +**Code review checklist**: + + +- **Typical problems of security coding [[historical security coding cases reference]](https://gitee.com/mindspore/community/blob/master/security/security_coding_violation_cases.md)** + - [ ] whether to verify the pointer is null/nullptr + - [ ] whether to verify the function's return value + - [ ] whether new/malloc memory is released correctly +- **Performance analysis (if a sub-item is involved, please outline the implementation idea or modification content)** + - [ ] whether to modify hotspot ***function / algorithm / operation*** + - [ ] whether to consider concurrent scenarios + - [ ] whether to consider communication scenario ++ - [ ] **Whether to comply with coding specifications [[coding specification reference]](https://gitee.com/mindspore/community/blob/master/security/coding_guild_cpp_zh_cn.md)** ++ - [ ] **Whether to comply with ***SOLID principle / Demeter's law***** ++ - [ ] **Whether the ***interaction between modules / features*** is involved (if yes, please outline the implementation ideas)** ++ - [ ] **Whether there is UT test case && the test case is a valid (if there is no test case, please explain the reason)** ++ - [ ] **whether the secret key is loaded/released correctly** +- **Error handling and recording** + - [ ] whether the interface exception scenarios are fully considered + - [ ] whether the error is recorded appropriately + **Special notes for your reviewers**: - - + + + +