From 53f0a1a5ea3c65d135ba8e5b02456de736bf89f5 Mon Sep 17 00:00:00 2001
From: yujianfeng <yujianfeng5@huawei.com>
Date: Fri, 19 Jun 2020 16:44:24 +0800
Subject: [PATCH] Fix computation of sparse_apply_proximal_adagrad

---
 .../kernel/cpu/sparse_apply_proximal_adagrad_cpu_kernel.cc   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mindspore/ccsrc/kernel/cpu/sparse_apply_proximal_adagrad_cpu_kernel.cc b/mindspore/ccsrc/kernel/cpu/sparse_apply_proximal_adagrad_cpu_kernel.cc
index 69b4755bc17..d99c294594c 100644
--- a/mindspore/ccsrc/kernel/cpu/sparse_apply_proximal_adagrad_cpu_kernel.cc
+++ b/mindspore/ccsrc/kernel/cpu/sparse_apply_proximal_adagrad_cpu_kernel.cc
@@ -98,10 +98,11 @@ bool SparseApplyProximalAdagradCPUKernel::Launch(const std::vector<kernel::Addre
     size_t start_index = var_outer_dim_size_ * index;
     size_t end_index = start_index + var_outer_dim_size_;
     for (size_t j = start_index, k = var_outer_dim_size_ * i; j < end_index; ++j, ++k) {
-      accum[j] += grad[k] * grad[k];
+      auto summed_grad = unique_sparse_grad.value_[k];
+      accum[j] += summed_grad * summed_grad;
       auto learning_rate = lr * (1 / std::sqrt(accum[j]));
       auto prox_v = var[j];
-      prox_v -= grad[k] * learning_rate;
+      prox_v -= summed_grad * learning_rate;
       if (l1 > 0) {
         var[j] = Sign(prox_v) * std::fmax(std::fabs(prox_v) - learning_rate * l1, static_cast<float>(0.0)) /
                  (1 + l2 * learning_rate);