mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
5,842 Commits 56 Branches 544 Tags 445 MiB
Commit Graph

1777 Commits

Author SHA1 Message Date
Marcel Molina 7143d80147 Smattering of grammatical fixes to documentation. Closes #10083 [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 03:37:16 +00:00
David Heinemeier Hansson 37adea6ff1 Address shortcomings of changeset [8054] [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-07 15:07:39 +00:00
Marcel Molina f770b829f4 Enhance explanation with more examples for attr_accessible macro. Closes #8095 [fearoffish, Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 23:50:23 +00:00
Marcel Molina 94502623fb Standardize on using hyphens rather than colons to separate option names from their explanation in documentation. Replace + with tt tags. Closes #8732. [ryanb] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 23:33:40 +00:00
Marcel Molina a291ea2bc9 Update association/method mapping table to refected latest collection methods for has_many :through. Closes #8772 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8102 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 23:20:22 +00:00
Marcel Molina 96fa4a2f52 Make transaction documentation example more realistic 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8097 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 19:11:42 +00:00
Marcel Molina 4f59aacb68 Explain semantics of having several different AR instances in a transaction block. Closes #9036 [jacobat, Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 19:04:54 +00:00
Marcel Molina aaccd182ea Add missing file for revision #8090 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8092 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 18:47:27 +00:00
Marcel Molina 026973f6a0 Update Schema documentation to use updated sexy migration notation. Closes #10086 [sjgman9] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 18:26:54 +00:00
Michael Koziarski 7e6bb82f44 Use the safe conversion code introduced in earlier commit. References #10068 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-05 22:29:52 +00:00
Michael Koziarski 8f74527282 Escape table names during calculation queries. [wesley.moxam, Koz] Closes #4593 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-31 05:58:09 +00:00
Michael Koziarski 3c9cd19786 Make fixtures work with the new test subclasses. [tarmo, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-31 05:43:52 +00:00
Jeremy Kemper bef071dd0b Introduce finder :joins with associations. Same :include syntax but with inner rather than outer joins. Closes #10012. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-29 21:39:52 +00:00
Jeremy Kemper 204c2755e2 Associations: speedup duplicate record check. Closes #10011. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-29 03:02:42 +00:00
Rick Olson c708346688 Change JSON to encode %w(< > &) as 4 digit hex codes to be in compliance with the JSON spec. Closes #9975 [josh, chuyeow, tpope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8050 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-29 00:18:43 +00:00
Michael Koziarski df0765d8dc Make sure that << works on has_many associations on unsaved records. Closes #9989 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8049 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-28 03:39:18 +00:00
Jeremy Kemper 88f951a519 Allow association redefinition in subclasses. Closes #9346. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8046 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-27 20:31:09 +00:00
Jeremy Kemper 4b639904d7 Fix has_many :through delete with custom foreign keys. Closes #6466. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-27 18:51:32 +00:00
Jeremy Kemper 49eafd8c36 Foxy fixtures. Adapter#disable_referential_integrity. Closes #9981. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 05:56:46 +00:00
Marcel Molina d761ac4095 Add docs explaining how to protect all attributes using attr_accessible with no arguments. Closes #9631 [boone, rmm5t] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 04:07:39 +00:00
Marcel Molina 27941f649f Update add_index documentation to use new options api. Closes #9787 [kamal] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 03:55:22 +00:00
Marcel Molina bf658a906b Allow find on a has_many association defined with :finder_sql to accept id arguments as strings like regular find does. Closes #9916 [krishna] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 03:42:28 +00:00
Marcel Molina 8b2a6014a2 Use VALID_FIND_OPTIONS when resolving :find scoping rather than hard coding the list of valid find options. Closes #9443 [sur] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8025 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 03:20:14 +00:00
Michael Koziarski 96557eb35b Remove superfluous code and quote table name. References #9971 [jkit, nzkoz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 18:53:07 +00:00
Michael Koziarski 11d2a309c5 Make clear_reloadable_connections! take account of @@allow_concurrency. Closes #7579 [wilson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 08:09:41 +00:00
Michael Koziarski 2d208eb3a0 Make sure that the Schema Dumper supports non-standard primary keys with MySQL. Closes #9971 [RubyRedRick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 06:42:05 +00:00
Marcel Molina c8b6b4821f Limited eager loading no longer ignores scoped :order. Closes #9561 [danger, josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 18:34:01 +00:00
Jeremy Kemper 7b42a1d0ac Assigning an instance of a foreign class to a composed_of aggregate calls an optional conversion block. Refactor and simplify composed_of implementation. Closes #6322. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:39:35 +00:00
Jeremy Kemper c220e558be Assigning nil to a composed_of aggregate also sets its immediate value to nil. Closes #9843. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:29:42 +00:00
Jeremy Kemper 28729a4829 validates_uniqueness_of behaves well with abstract superclasses. References #3833, closes #9886. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 06:18:42 +00:00
Jeremy Kemper 902533e6f0 Reinstate test_change_column_nullability for all adapters. Closes #9945 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:52:04 +00:00
Jeremy Kemper e829e12e16 test_select_rows shouldn't depend on implicit result ordering. Closes #9898 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:50:12 +00:00
Rick Olson 7042163d76 Ensure that mysql quotes table names with database names correctly. Closes #9911 [crayz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 21:17:31 +00:00
Michael Koziarski 17ac677a2d typo in test name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:51:44 +00:00
Michael Koziarski 3facc8578b Few more tests for Sexy Migrations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:23 +00:00
Michael Koziarski 637c685a42 Forgotten changelog entry 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:09 +00:00
Michael Koziarski 6ddde027c4 Add t.belongs_to and t.references to sexy migrations [arthurgeek] 
Test harness for Sexy Migrations. [Koz]
Closes #9775


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:09:06 +00:00
Michael Koziarski 210f7e29e2 Move all Schema creation into schema.rb for Mysql. Closes #9899 [mikong, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 01:52:50 +00:00
Jeremy Kemper 2fac5d1a8b SQL Server: test for affected row count. References #9558 [lawrence, ryepup] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 23:47:59 +00:00
Michael Koziarski 2833706699 Read in binary mode to make sure windows support keeps working. [lawrence] Closes #9912 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 22:50:34 +00:00
Michael Koziarski 8ed1e885b7 Use a smaller binary fixture so we don't overflow column size limitations in some commercial / legacy databases. Closes #7987 [roderickvd, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:46 +00:00
Michael Koziarski ac3cf43182 Raise an intelligible error message when migration aren't named correctly [bronson] Closes #9909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7957 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:19 +00:00
Jeremy Kemper f575757ca4 Qualified column names work in hash conditions, like :conditions => { 'comments.created_at' => ... }. Closes #9733. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 08:08:08 +00:00
Jeremy Kemper cfbd790ad3 Fix regression where the association would not construct new finder SQL on save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved. Closes #8713. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 07:24:23 +00:00
Jeremy Kemper a72c1ec43e Refactor association create and build so before & after callbacks behave consistently. Closes #8854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:07:58 +00:00
Jeremy Kemper 9b6207c3d0 Quote table names. Defaults to column quoting. Closes #4593. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:06:33 +00:00
Jeremy Kemper e7ed4c9354 Fix join table docs error in schema_statements. Closes #9880 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:05:47 +00:00
Jeremy Kemper 197c888576 Moving SQL Server tests to the extracted adapter. References #9884. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:05:22 +00:00
Jeremy Kemper 671228942d Alias association #build to #new so it behaves predictably. Closes #8787. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 08:09:04 +00:00
Jeremy Kemper 333463679a Revert [7894] and apply to adapter instead. References #9588. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:57:06 +00:00