mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
18,814 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

3130 Commits

Author SHA1 Message Date
David Chelimsky f656796d05 Rename _assigns to view_assigns in AV::TC 
- also add tests
- also deprecate _assigns

[#5751 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-03 13:30:31 -02:00
Aditya Sanghi 297cf0b266 added test for form_for with search_field 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-02 17:48:12 +02:00
Aaron Patterson 3eb7f9adee removing more duplicate code. :'( 2010-10-01 18:09:37 -07:00
Aaron Patterson 50cf5c11a1 fixing warnings with regexps on assert_match 2010-10-01 18:07:19 -07:00
Aaron Patterson ffbcb84c21 removing more duplicate code 2010-10-01 18:05:59 -07:00
Aaron Patterson 44f85678e9 delete repeated code 2010-10-01 18:01:34 -07:00
Aaron Patterson dfa331ae15 use a method that actually exists 2010-10-01 17:54:50 -07:00
Piotr Sarnacki 22b11a41cc Allow mounting engines at '/' 
Without that commit script_name always become '/', which
results in paths like //posts/1 instead of /posts/1
 2010-09-30 09:47:05 +02:00
Aaron Patterson 1c0be7baac fixing space error 2010-09-29 11:47:54 -07:00
Emilio Tagua 6371e5b99f We can't assign @view_context_class here, define super() in test instead if we want to avoid warnings. 2010-09-29 14:35:24 -03:00
Emilio Tagua c37800aae1 _ is not a valid scheme name character, \w includes it and also is redundant with \d. 
'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").'
 2010-09-29 12:55:43 -03:00
Emilio Tagua bc0e7f4e37 Test correct method behaviour. 2010-09-29 12:42:51 -03:00
José Valim f63d35fba5 Ensure that named routes do not overwrite previously defined routes. 2010-09-29 14:24:32 +02:00
José Valim 14f9904e0f Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected. 2010-09-29 11:18:31 +02:00
José Valim 0bbf9029e8 Merge remote branch 'miloops/warnings' 2010-09-29 10:04:42 +02:00
Emilio Tagua 623ef13b77 Fix test that wasn't running at all. 2010-09-28 18:48:58 -03:00
Emilio Tagua d5bb640eb0 Remove methods to avoid warnings. 2010-09-28 18:40:38 -03:00
Emilio Tagua 783e9b8de5 Change test to avoid warnings. 2010-09-28 18:38:25 -03:00
Emilio Tagua 34fc109549 Redefine duplicated test name. 2010-09-28 18:36:45 -03:00
Emilio Tagua 454960d9fb Redefine duplicated test name. 2010-09-28 18:35:02 -03:00
Emilio Tagua 3e336f9ab7 Use redefine_method since baz is already defined. 2010-09-28 18:31:52 -03:00
Emilio Tagua 0c08d8bd75 Fix more warnings by defining variables and using instance_variable_defined? instead instance_variable_get. 2010-09-28 18:25:52 -03:00
Emilio Tagua e804104200 Use helper method here. 2010-09-28 18:16:26 -03:00
Emilio Tagua a0f95a887e Silence warnings here, only setting Encoding.default_external for testing. 2010-09-28 18:11:57 -03:00
Emilio Tagua d1e976da7f Silence warnings here, only setting Encoding.default_external for testing. 2010-09-28 18:10:32 -03:00
Emilio Tagua 523f98099d Remove more warnings on AP. 2010-09-28 18:01:48 -03:00
Emilio Tagua ad2c21089e Define @title to avoid warnings. 2010-09-28 17:44:26 -03:00
Emilio Tagua 80a98e9b25 Use instance_variable_defined? instead instance_variable_get in tests. 2010-09-28 17:35:17 -03:00
Emilio Tagua 3abd0593a6 Initialize ivars in tests. 2010-09-28 17:32:18 -03:00
Emilio Tagua c648a4cb94 Remove useless string line causing a warning. 2010-09-28 17:18:48 -03:00
Emilio Tagua 9917356d66 Remove more warnings by initializing variables in test. 2010-09-28 17:16:18 -03:00
Emilio Tagua 3f94b45262 Remove more warnings: no need to define attr_accessor if already exists. Initialize ivar. 2010-09-28 17:08:43 -03:00
Emilio Tagua c8db1adc0d Remove duplicated class test. copy/paste fail? 2010-09-28 16:40:28 -03:00
Emilio Tagua dc37bd778a Initialize @trusted_proxies. 2010-09-28 16:25:06 -03:00
Emilio Tagua 7129dd95d0 undef method if already defined. 2010-09-28 16:08:00 -03:00
Emilio Tagua dda3431942 Remove useless use of :: in void context. 2010-09-28 16:02:31 -03:00
Emilio Tagua 9027721b11 Add parenthesis to avoid syntax warnings. 2010-09-28 15:48:45 -03:00
Emilio Tagua 97174980e5 Remove duplicated method. 2010-09-28 15:43:03 -03:00
Emilio Tagua 699fb81def Initialize @_virtual_path path ivar. 2010-09-28 15:31:29 -03:00
Emilio Tagua dc2cd266cd Rename tests to avoid name collisions and warnings when running rake task. 2010-09-28 15:30:59 -03:00
Emilio Tagua f63f90134a Rename duplicated test, and give it a correct name. Remove nonsense line. 2010-09-28 15:30:16 -03:00
Emilio Tagua dc61ab0be5 Remove duplicated test. 2010-09-28 15:29:59 -03:00
Diego Carrion 72f37bd8bc renderer calls object.to_json when rendering :json => object [#5655 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:11:29 +02:00
Emilio Tagua 1ab2ab07b5 Remove more warnings shadowing outer local variable. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-27 16:43:17 -03:00
Emilio Tagua bb71f182dd Rename duplicated test name. 2010-09-27 11:19:24 -03:00
Emilio Tagua 583ddf22a2 Remove more warnings shadowing outer local variable. 2010-09-27 11:19:22 -03:00
Emilio Tagua 0cb1d87cd5 Remove duplicated test. 2010-09-27 11:19:22 -03:00
Emilio Tagua 535371e956 Fix indentation. 2010-09-27 11:19:19 -03:00
Emilio Tagua 2d274a5208 Use parentheses when using assert_match followed by a regexp to avoid warnings. 2010-09-27 11:19:19 -03:00
Carlos Antonio da Silva 6345899489 Remove last tests with deprecated form_for and cleanup form_for helper 
This cleans up the last bits of deprecation stuff from form_for helper.
However there is still a bug when using :as => foo[], with index. The
classes and ids are being generated using [], such as foo[]_edit. This
bug already existed but it was not detected before.
 2010-09-26 02:13:47 +08:00