mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
18,814 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

2154 Commits

Author SHA1 Message Date
David Chelimsky f656796d05 Rename _assigns to view_assigns in AV::TC 
- also add tests
- also deprecate _assigns

[#5751 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-03 13:30:31 -02:00
Aditya Sanghi 8d1df887d3 Fixing search_field to remove object attribute from options hash [#5730 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-02 17:48:11 +02:00
José Valim b951522018 Revert "Perf: refactor _assign method to avoid inject and defining unneeded local var." 
_assigns must return a hash.

This reverts commit e66c1cee86.
 2010-10-02 08:36:55 +02:00
José Valim 6a55ca346e Revert "removing crazy finalizer code until there is proof that we need it" 
This reverts commit a40e3c1a96.
 2010-09-30 11:41:53 +02:00
Aaron Patterson 29c32e8329 tag value can be false, so nil? check is necessary 2010-09-29 17:57:39 -07:00
Neeraj Singh 618407db56 another case of extra nil? check 2010-09-30 08:11:35 +08:00
Neeraj Singh 08a08d97dd no need to check for nil? 2010-09-30 08:11:35 +08:00
Aaron Patterson a40e3c1a96 removing crazy finalizer code until there is proof that we need it 2010-09-29 16:40:47 -07:00
Aaron Patterson 2eef53b163 removing useless code 2010-09-29 16:17:56 -07:00
José Valim 14f9904e0f Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected. 2010-09-29 11:18:31 +02:00
José Valim 0bbf9029e8 Merge remote branch 'miloops/warnings' 2010-09-29 10:04:42 +02:00
Emilio Tagua 357f59447d Initialize @path. 2010-09-28 18:20:54 -03:00
Emilio Tagua 7c8b43ed4f Ask if the instance variable is defined before asking for it, avoid *many* warnings. 2010-09-28 15:53:32 -03:00
Emilio Tagua 04c4f47fed Initialize @sub_templates 2010-09-28 15:33:48 -03:00
Aaron Patterson 1ef2b47fb1 convert inject to map + join 2010-09-28 11:22:16 -07:00
Emilio Tagua 8ee27afd06 Don't define _test_case method if already defined. 2010-09-28 15:21:44 -03:00
José Valim fe0251e408 Merge remote branch 'miloops/warnings' 
Conflicts:
	actionpack/lib/action_controller/metal/url_for.rb
 2010-09-27 21:00:54 +02:00
thedarkone dc09cc055a Assume compute_asset_host returns reasonable values. 2010-09-27 17:46:00 +02:00
thedarkone b127e0cac9 Performance: refactor convert_options_to_data_attributes. 2010-09-27 17:46:00 +02:00
thedarkone dcabc6c043 Remove dead code. 2010-09-27 17:46:00 +02:00
thedarkone 7d9f605f80 Clean up url_for. 2010-09-27 17:45:59 +02:00
thedarkone 70357666bc Do a single string interpolation. 2010-09-27 17:45:59 +02:00
thedarkone e1bccc5169 Simple .empty? test will do fine here (rails_asset_id returns nice strings). 2010-09-27 17:45:59 +02:00
thedarkone 7b2d51817d Make asset extension rewriting faster. 2010-09-27 17:45:58 +02:00
thedarkone 05e53b4c1a Optimize relative_url_root rewriting code. 2010-09-27 17:45:58 +02:00
thedarkone 918dc27345 Compile ActionController::Base.config's methods to avoid method_missing overhead. 2010-09-27 17:45:58 +02:00
Emilio Tagua 2f59cd6fd6 Remove method previous method if already defined. 2010-09-27 11:19:23 -03:00
Emilio Tagua e7c833fca9 Define @emitted_hidden_id if it doesn't exists and reuse it if it does. 2010-09-27 11:19:23 -03:00
Emilio Tagua 74d7664b60 Avoid uninitialized variable warning. 2010-09-27 11:19:23 -03:00
Emilio Tagua dafb4bd33b Don't shadow outer local variables. 2010-09-27 11:19:22 -03:00
Carlos Antonio da Silva ecc13f7c18 We don't need to check if the format exists to generate the url, it already does it internally 2010-09-26 02:13:48 +08:00
Carlos Antonio da Silva 00e7633555 More cleanup on form helpers 2010-09-26 02:13:47 +08:00
Carlos Antonio da Silva 6345899489 Remove last tests with deprecated form_for and cleanup form_for helper 
This cleans up the last bits of deprecation stuff from form_for helper.
However there is still a bug when using :as => foo[], with index. The
classes and ids are being generated using [], such as foo[]_edit. This
bug already existed but it was not detected before.
 2010-09-26 02:13:47 +08:00
Carlos Antonio da Silva db57e92784 Select tags with array options are deprecated, removing 2010-09-26 02:13:46 +08:00
Carlos Antonio da Silva eb8a24a375 Refactor form_for helper 2010-09-26 02:13:46 +08:00
Carlos Antonio da Silva f405df6e57 There is no DeprecatedBlockHelpers in AV, so remove it 2010-09-26 02:13:44 +08:00
Kevin Hughes f48c56008e Changed documentation for auto_link so that the truncate example works [#5694 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-09-24 00:58:43 +02:00
Xavier Noria 8c0c815ba7 resolves rdoc conflict 2010-09-23 22:35:08 +02:00
Emilio Tagua 8c97f49f2e Refactor decode_credentials to avoid inject and use map instead. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:03 -03:00
Emilio Tagua 6d8a6700a7 Perf: refactor _assign method to avoid inject and defining unneeded local var. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:03 -03:00
Joost Baaij b39dfd5936 Document form_for behaviour when using file_field inside the block 2010-09-21 15:11:04 +02:00
Santiago Pastorino 0523b55ab9 file_field propagates up multipart property even inside of fields_for 2010-09-20 01:11:55 -07:00
Santiago Pastorino 88a82bcb2d application.js should be the last file on javascript_include_tag(:all) 2010-09-19 14:41:32 -07:00
Aaron Patterson 2d65ff5af7 removing some warnings 2010-09-18 14:14:46 -07:00
Aaron Patterson 6b50bfb0f0 freeze is not necessary 2010-09-18 14:03:29 -07:00
Aaron Patterson 38f6533792 argument error is done for us 2010-09-18 14:00:00 -07:00
Santiago Pastorino b17b980a15 file_field makes the enclosing form multipart 2010-09-18 12:31:00 -07:00
Alexey Mahotkin dfebdb1b03 Tiny fixes to rdoc 2010-09-16 17:10:36 +04:00
rspeicher 6f3ac42550 Typos 2010-09-15 19:19:48 -04:00
Xavier Noria dd6efe98b6 Merge remote branch 'docrails/master' 2010-09-14 20:07:29 +02:00