7595c922a6
Use the combined jsbundling-rails gem instead of individual js bundler gems ( #43172 )
...
* Use the combined jsbundling-rails gem instead of individual js bundler gems
* Remove Webpacker remnants
* Replace webpacker with jsbundling-rails
2021-09-06 16:44:44 +02:00
7437b6a361
Tidy up the build output for Active Job adapters
2019-10-23 20:47:50 +10:30
892e38c78e
Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin block
...
Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205 ).
I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906 ), so we'd probably meets with
that situation than before.
2018-12-21 06:12:42 +09:00
2e7e9fe1dc
Do not require `webpacker` in Active Job integration tests
...
Because `skip-javascript` option is specified for the dummy application
used in the integration tests.
bdc96802a7/activejob/test/support/integration/helper.rb (L14)
2018-12-08 13:24:22 +09:00
a48f6a5d9f
Enable warnings in all test tasks
...
Also normalize AJ task use t, like all other Rails test tasks.
2018-05-23 23:05:03 +02:00
6ef720791d
Remove support for Qu gem.
...
Reasons are that the Qu gem wasn't compatible since Rails 5.1,
gem development was stopped in 2014 and maintainers have
confirmed its demise. See issue #32273
2018-03-19 21:27:16 +01:00
245c1dafa8
Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the future
...
Follow up of #31432 .
2017-12-14 17:30:54 +09:00
aa28c5ca65
[Active Job] `rubocop -a --only Layout/EmptyLineAfterMagicComment`
2017-07-11 13:12:32 +09:00
14ece5e429
Use frozen-string-literal in ActiveJob
2017-07-09 20:50:52 +03:00
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
82e646f3d0
Bring back delayed_job to test list
...
`delayed_job_active_record` 4.1.2 supports Rails 5.1.
Ref: https://github.com/collectiveidea/delayed_job_active_record/pull/138
2017-05-28 21:39:18 +09:00
40bdbce191
Define path with __dir__
...
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df
2017-05-23 00:53:51 +03:00
030dff74ce
Delayed job doesn't support Active Record 5.1 yet
2016-12-29 17:53:04 -05:00
2f421fa294
Remove warning in ActiveJob
...
Currently it causes:
```
activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS
```
2016-12-21 20:38:12 -05:00
bb1ecdcc67
fixes remaining RuboCop issues [Vipul A M, Xavier Noria]
2016-09-01 23:41:49 +02:00
e6ab70c439
applies new string literal convention to the rest of the project
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:28:46 +02:00
d12209cad2
Remove package:clean task
...
Introduced in d6f2000a67
2016-05-24 13:11:28 -04:00
8ecc5ab1d8
Start Rails 5.1 development 🎉
2016-05-10 03:46:56 -03:00
d6f2000a67
Wrangle the asset build into something that sounds more general
2016-02-01 05:03:03 +10:30
25a4155257
Initial implementation of ActiveJob AsyncAdapter.
2015-08-25 14:22:11 -04:00
21b6b68f63
Remove unused package tasks
...
We are using `all:build` now.
2015-05-28 09:06:10 +02:00
4194d052d8
Remove broken and unused release task
...
- We do release with release.rb
- There is no `rake/gemcutter`
2015-05-22 14:30:30 +02:00
c2e30f8e45
Disable warnings on activejob tests
...
The implementations seems to not be interested to remove the warnings so
enabling them we are just making harder to read the outputs
2015-05-03 18:01:10 -03:00
e380ac685b
Changed the AJADAPTER to AJ_ADAPTER
...
* This allows for easier reading, since those are two words, so they should be
split by _
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-22 16:11:21 +01:00
8a1c3476a6
Do not run integration tests for the test adapter
2015-01-02 00:09:10 -03:00
8a73f4b5b9
ActiveJob testing improvements
...
1. The :test adapter wasn't going through a full cycle of
serialize/deserialize when performing jobs. Now it does
2. Regular AJ tests were not run for the :test adapter. Now they are
3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires
the file that implements that method. Now it does
2014-12-30 17:53:42 +02:00
16c04040f4
Enable emitting of warnings from ActiveJob tests.
2014-10-19 23:05:03 +05:30
1fac7b79f3
Follow up to #16613
...
Since we want this flag to be enabled anytime we are running the tests
under JRuby, let's enable this at the Rakefile level so people get the
performance boost on their local checkout.
Moreover, we avoid having to update this particular line anytime the
option changes on the JRuby side.
The only drawback is that we have to define it in every Rakefile but
there's no big deal, this is already the case for other options.
2014-09-28 12:04:06 +02:00
01ac23423d
Pare down and simplify Active Job's rake tasks
2014-09-14 14:01:16 -07:00
175ba66664
ActiveJob Integration Tests
2014-09-11 00:38:56 +03:00
01604c6ee5
Skip adapter queue_classic for JRuby
2014-08-19 15:40:45 +02:00
0c232779ec
Remove activejob integration tests
2014-08-12 10:07:21 +00:00
a75f085941
Add 'activejob/' from commit '14f74a8331f94150dfee653224de8fc837797709'
...
git-subtree-dir: activejob
git-subtree-mainline: b45b99894a14f74a8331
2014-08-12 09:17:19 +00:00
David Heinemeier Hansson