Commit Graph

3226 Commits

Author SHA1 Message Date
Rafael Mendonça França 86f287e6cf Remove warning of shadowing outer local variable 2013-10-27 20:18:08 -02:00
Vasiliy Ermolovich 106c988c10 add include_hidden option to collection_check_boxes helper 2013-10-27 18:31:19 +03:00
Rafael Mendonça França a53f716706 Merge pull request #12636 from kongregate/dont_rescue_Exceptions
Avoid unnecessary catching of Exception instead of StandardError (conver...
2013-10-24 16:48:32 -07:00
stopdropandrew 54f485248c Avoid unnecessary catching of Exception instead of StandardError (converting Exceptions into StandardErrors) 2013-10-24 16:43:27 -07:00
Rafael Mendonça França 6c570648ad Merge pull request #10471 from andyw8/button_to_params
Add params option for button_to

Conflicts:
	actionpack/CHANGELOG.md
2013-10-24 18:02:19 -02:00
Rafael Mendonça França b2ea0ff572 Ensure the state is clean after one failure 2013-10-16 19:43:10 -03:00
Rafael Mendonça França c44f8d255b Merge pull request #12540 from wyaeld/bug/fix-recursive-digest
Ensure ActionView::Digestor.cache is correctly cleaned up
2013-10-16 19:41:16 -03:00
Adam Jahnke 065d3e061d Fix typo in form_helper.rb 2013-10-16 16:09:09 -05:00
Brad Murray 0cdce7f910 add a new local variable to track if digests are being stored, to ensure the cleanup works correctly 2013-10-17 09:00:37 +13:00
Brad Murray af1dc7f08a update digestor code based on review 2013-10-15 21:08:47 +13:00
Brad Murray 6c04cb2261 update changelog 2013-10-15 11:23:37 +13:00
Brad Murray 2b3a349123 Ensure ActionView::Digest.cache is correctly cleaned up when
ActionView::Resolver.caching = false.
2013-10-15 11:17:11 +13:00
Brad Murray 89969dd711 Add 2 tests, 1 of which fails, to isolate the digest_caching behaviour causing #12521
If config.action_view.cache_template_loading = false, most likely in a development
configuration if config.cache_classes = false &
config.action_controller.perform_caching = true.

config.action_view.cache_template_loading defaults to the value of config.cache_classes
2013-10-15 11:06:50 +13:00
Rafael Mendonça França aa9101eb7e Merge pull request #12491 from shamanime/patch-1
Fix wrong variable name used in the select_day method documentation
2013-10-13 10:13:03 -07:00
Vipul A M 78c176e2fa Change `map` to `map!` to save extra array creation on new array 2013-10-13 20:58:50 +05:30
Jefferson Queiroz Venerando 97943f19b7 Fix wrong variable name used in the select_day method documentation
The variable name created in the example is `my_date`, the methods  were using `my_time` instead.
2013-10-10 10:34:14 -03:00
Arun Agrawal 64eb39a5b9 Moved viewpathstest into actionview/test/actionpack/controller
These test were not running at all,
Now it will run as a tests part.
2013-10-09 20:09:33 +02:00
Arun Agrawal 32b42e2620 FakeController is not required in AV 2013-10-09 19:30:44 +02:00
Rafael Mendonça França 874ca68f3d Merge pull request #12437 from websiteswithclass/master
Fixed typo in documentation
2013-10-04 06:40:01 -07:00
Arun Agrawal e9bce34ddf Directory name in RUNNING_UNIT_TESTS.rdoc [ci skip] 2013-10-04 08:31:29 +02:00
Joseph Zidell bf495069cb Fixed return strings in documentation 2013-10-03 18:30:42 -04:00
Joseph Zidell 58d64ddc46 Fixed typo in documentation 2013-10-03 16:57:18 -04:00
Arun Agrawal 9a16872aee Running all isolated test for actionview
1. fix name for activerecord directory
2. Added actionpack directory to run tests
2013-10-03 00:00:50 +02:00
Thomas von Deyen 1825f6fb60 Adds template dependencies rake task from cache_digests gem.
This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem.
2013-09-26 21:19:19 +02:00
Rafael Mendonça França 0cc4ff77cc Add CHANGELOG entry for #12344
[ci skip]
2013-09-24 21:07:24 -03:00
Angel N. Sciortino 8ae8044726 Use the given name in html_options for the hidden field in collection_check_boxes 2013-09-24 13:42:06 -05:00
Rafael Mendonça França dd13722c26 Merge pull request #10773 from wangjohn/link_and_routing_options
Adding documentation and tests to ``polymorphic_url`` and ``link_to``
2013-09-23 12:13:15 -03:00
Bogdan Gusiev e8e08d69c2 Fix some edge cases for AV `select` helper with `:selected` option 2013-09-23 17:48:23 +03:00
Rafael Mendonça França 1c6bcefe7e Expand select documentation to tell about the block
[ci skip]
2013-09-23 11:19:35 -03:00
Rafael Mendonça França 0e9f0bd6f7 Use ERB in the CHANGELOG [ci skip] 2013-09-23 11:11:26 -03:00
Bogdan Gusiev 57bf92c6de Ability to pass block to AV#select helper
Example:

    = select(report, "campaign_ids") do
      - available_campaigns.each do |c|
        %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
2013-09-23 14:25:42 +03:00
Vasiliy Ermolovich 0b0ac5d917 handle `:namespace` form option in collection labels 2013-09-22 21:49:01 +03:00
Santiago Pastorino 32e23884cc Merge pull request #12232 from claudiob/delete-unused-helper-fixtures
Remove unused AV helper fixtures from e10a2531
2013-09-20 18:55:08 -07:00
Daniel Schierbeck 77e79ecd92 Bust the template digest cache key when details are changed
Since the lookup details will influence which template is resolved, they
need to be included in the cache key -- otherwise two different
templates may erroneously share the same digest value.
2013-09-19 10:25:14 +02:00
Andy Waite e6e0579def Add params option for button_to
The parameters are rendered as hidden form fields within the generated
form. This is useful for when a record has multiple buttons associated
with it, each of which target the same controller method, but which
need to submit different attributes.
2013-09-18 19:56:46 +01:00
Santiago Pastorino 949c4291a4 There's no need to do this
AS does the following inside Time.find_zone! ...
`ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)`
and given that the test is stubbing AS::TZ[] we don't need the removed
code.
2013-09-17 16:12:15 -03:00
claudiob d6efc1edc1 Remove unused AV helper fixtures from e10a2531
Several fixtures for helpers are removed. They were introduced in
ActionView by @strzalek but never referenced in any test.
2013-09-14 10:30:17 -07:00
Waynn Lue 87fe7e9b16 "generates" applies to "collection radio" so it should be singular
I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails).
2013-09-12 14:48:57 -07:00
Rafael Mendonça França 495daef061 Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-as
form_for - fix :namespace and :as options clash

Conflicts:
	actionview/CHANGELOG.md
2013-09-12 18:20:14 -03:00
Rafael Mendonça França 4bdf929579 Write the right CHANGELOG entry for #11603
[ci skip]
2013-09-12 13:25:21 -03:00
Rafael Mendonça França 9c18beae64 Merge pull request #11603 from jetthoughts/join_strings_instead_of_contactination
Cleanup: replace String concatenation by joining for excerpt helper
2013-09-12 13:25:04 -03:00
Guillermo Iguaran 005b33222d Merge pull request #12173 from arunagw/fixes_reverted_by_revert_commit
Revert fixes
2013-09-10 07:05:17 -07:00
claudiob 61d2391352 Remove helper fixtures not used in any test
The fixture for module AbcHelper defines three functions bare_a,
bare_b and bare_c, but only bare_a is used in the code that tests
helper functions.
2013-09-09 14:19:09 -07:00
José Valim 67336ce199 Remove remaining coupling with AV in MimeResponds 2013-09-09 12:33:53 -03:00
José Valim a41669563b Remove BasicRendering and remove template functionality from AbsC::Rendering 2013-09-09 12:33:53 -03:00
Arun Agrawal 3dffe65d91 Back AV description in gemspec 2013-09-09 17:12:45 +02:00
Adam Niedzielski e18f045b65 form_for - fix :namespace and :as options clash
:as option should not overwrite :namespace option when
generating html id attribute of the form element. id should be prefixed
by specified namespace even if :as option is present

Add test case showing the issue and code fixing it
2013-09-09 07:59:07 +02:00
Paul Nikitochkin 061e48df26 Cleanup of excerpt helper
* replaced String concatenation by joining
* separator has default value to '', even it is nil
2013-09-06 18:00:55 +03:00
Carlos Antonio da Silva b77781c012 Fix failure with minitest 5.0.7
Require minitest/mock in test where stub method is needed.

Apparently this was being "imported" by minitest pride plugin, which
previously required "minitest/autorun", that required "minitest/mock",
making the method available by chance.

It has been changed in minitest:
595ce955c0

So we need to make sure we require what we really need where necessary.
2013-09-06 09:29:00 -03:00
Carlos Antonio da Silva 3b35103793 Merge pull request #12143 from rajcybage/fixing_typos
fix actionview and activemodel test cases typos
2013-09-05 03:32:56 -07:00
Rajarshi Das e21a18bed0 fix actionview and activemodel test cases typos 2013-09-05 14:21:57 +05:30
Vipul A M bb69f1df8b Fix method name typos 2013-09-05 10:43:57 +05:30
namusyaka 2b6b5404af Fix a few typos. [ci skip] 2013-09-04 03:48:53 +09:00
Łukasz Strzałkowski aea02eb430 Move skeleton methods from AV to AbsC
The methods:

 * #render_to_body
 * #render_to_string
 * #_normalize_render

Haven't had anything specyfic to ActionView. This was common code which should belong to AbstractController
2013-09-03 14:57:37 +02:00
Łukasz Strzałkowski 544d0fad3d Return to using protected_instance_variables in AV 2013-09-02 23:18:02 +02:00
Rajarshi Das 414f496363 fix the typo [ci skip]
fix the typo newstopics => new topics in action view cache helper
2013-09-02 10:41:55 +05:30
Rafael Mendonça França 974335d4d0 Improve CHANGELOG entry [ci skip] 2013-08-27 14:10:45 -03:00
Rafael Mendonça França d6854dfe13 Merge pull request #11768 from cloudspace/cache_template_loading
Only cache template digests if !config.cache_template_loading
2013-08-27 10:05:01 -07:00
Łukasz Strzałkowski e10a25310f Move abstract's controller tests to AV
The ones that were actually testing AV functionality and should belong in there
2013-08-25 11:40:11 +02:00
Łukasz Strzałkowski 7620ab08be Move actionpack's controller tests 2013-08-25 11:40:10 +02:00
Łukasz Strzałkowski c40c362ec1 Load HTML in ActionView not ActionPack
HTML Scanner is part of ActionView and it should be loaded along with it
2013-08-25 11:40:10 +02:00
Łukasz Strzałkowski 1e001b1db3 Move AP's capture tests to AV 2013-08-25 11:39:14 +02:00
Łukasz Strzałkowski c9ef9c1442 Move remaining layouts tests to AV 2013-08-25 11:39:14 +02:00
Łukasz Strzałkowski 53e65e1772 Add AP tests to runner 2013-08-25 11:39:14 +02:00
Łukasz Strzałkowski 969b22f189 Cleanup & reorganise rake tasks in AV 2013-08-25 11:39:14 +02:00
Łukasz Strzałkowski b5410a73ec Split rendering tests between AP & AV
All rendering test remain in AV. Head, ETag etc. test stay in AP
2013-08-25 11:39:13 +02:00
Łukasz Strzałkowski acc8e25902 Move render_test to AV 2013-08-25 11:39:13 +02:00
Łukasz Strzałkowski aa2d003812 Fist stab on basic rendering 2013-08-25 11:39:13 +02:00
Łukasz Strzałkowski 7d810049fe Add #rendered_format method to controllers 2013-08-25 11:39:13 +02:00
Łukasz Strzałkowski 3f2ac795b8 Add missing requires inside AV 2013-08-25 11:39:12 +02:00
Łukasz Strzałkowski 6c7d895dda Do not load AV inside AP
Move that part to AV railtie
2013-08-25 11:39:12 +02:00
Łukasz Strzałkowski 7c8817aeef Add missing require 2013-08-25 11:39:12 +02:00
Łukasz Strzałkowski 839938e3de Revert "Move setting content_type to AV"
This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc.
2013-08-25 11:39:12 +02:00
Łukasz Strzałkowski cb2d671cb8 Move setting content_type to AV 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski 0b4507a26f Use concat to avoid allocating additional array 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski 98ec4ebfe7 Pass args to render's super method 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski 1656f58f07 Improve AV::Rendering docs 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski b068e20b35 Include AV::Layouts before setting view_paths 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski d1760253f5 Load AV::Layout to AM::Base in railties 2013-08-25 11:39:11 +02:00
Łukasz Strzałkowski 43ce8265a1 Don not require AC::Caching 2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski 087c66d183 Remove ApplicationController & RoutingTestHelpers 2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski fc118d0b41 Remove unused ActionDispatch::RoutingVerbs 2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski 81e5be0692 Remove unused in AV fixture-controllers 2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski 977c60eeea Remove view_assigns from AV
It wasn't adding anything, just invoking super
2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski 3fd2e72477 Load AV::Layouts dynamicly via railties 2013-08-25 11:39:10 +02:00
Łukasz Strzałkowski d6363aa180 Code formatting & typo fixes 2013-08-25 11:39:09 +02:00
Łukasz Strzałkowski b9b48c7806 Remove abstract_controller load hooks 2013-08-25 11:39:09 +02:00
Łukasz Strzałkowski 49608f7b81 Move protected_instance_variables & view_assigns to AbstractController 2013-08-25 11:39:09 +02:00
Łukasz Strzałkowski 8b8111aeea Remove 'api plugin' from docs
AbstractController::Rendering is module which defines thie api
2013-08-25 11:39:09 +02:00
Łukasz Strzałkowski 8e3413d410 Create AbstractController::Rendering interface
This interface should be use when implementing renderers.
2013-08-25 11:39:09 +02:00
Łukasz Strzałkowski 757170dca4 Fix eager_autoload for layouts
Name was singular, should be plural
2013-08-25 11:39:08 +02:00
Łukasz Strzałkowski 58b338677a Fix AV tests, I18nProxy was moved to AV 2013-08-25 11:39:08 +02:00
Łukasz Strzałkowski 769d6dc423 Revert "Require only path_set && lookup_context instead of whole base"
This reverts commit 77bb03df2ca3687b290e9fe77d21007642f0329c.
2013-08-25 11:39:08 +02:00
Łukasz Strzałkowski 766fa97b45 Hook up AV::Rendering on AV intialization 2013-08-25 11:39:08 +02:00
Łukasz Strzałkowski c48ce6e73d Move layouts to AV 2013-08-25 11:39:07 +02:00
Łukasz Strzałkowski 5759531a95 Move rendering from AP to AV 2013-08-25 11:39:07 +02:00
Łukasz Strzałkowski e772b098ed Require only path_set && lookup_context instead of whole base 2013-08-25 11:39:07 +02:00
Łukasz Strzałkowski 1b446d06dd Move view_paths from AP to AV 2013-08-25 11:39:07 +02:00
Vijay Dev 9abe72c760 Merge branch 'master' of github.com:rails/docrails
Conflicts:
	actionview/README.rdoc
	activerecord/lib/active_record/migration.rb
	guides/source/development_dependencies_install.md
	guides/source/getting_started.md
2013-08-17 21:49:16 +05:30
Vijay Dev ec8ef1e105 Revert "Merge branch 'master' of github.com:rails/docrails"
This reverts commit 70d6e16fba, reversing
changes made to ea4db3bc07.

Seems to be a code merge done by mistake.
2013-08-17 21:46:39 +05:30
Xavier Noria 4a7fba09f4 RDoc tweaks 2013-08-07 06:10:18 +02:00
Josh Lauer 7e74a01f84 Only cache template digests if config.cache_template_loading
since ActionView::Resolver.caching is set to the same value as config.cache_template_loading
only cache template digests if config.cache_template_loading is not falsy
fixes issues #10752 and #10791
2013-08-06 14:06:42 -04:00
Tim Ruffles 08525e3ef1 be more specific about csrf token and ajax - not whitelisted outside of jquery-rails [ci skip] 2013-08-06 10:55:58 +01:00
Alex Tambellini f1d9179087 Remove privatizing of Fixnum#/ from assert_distance_of_time_in_words
MRI reimplemented Date in C so it doesn't hit this division anymore
while JRuby still uses the old stdlib implementation of Date so
it will always hit this.

With this change the actionview date_helper_test.rb tests should pass on JRuby.
2013-08-05 21:52:13 -04:00
Guillermo Iguaran ee0a8e0113 Merge pull request #11743 from gaurish/tmp-magic
[Jruby] Make all tests in ActionView::TemplateDigestorTest green
2013-08-05 17:04:57 -07:00
Gaurish Sharma 4254a6e677 Add tmp dir in actionview/test/
Missing tmp directory will cause the test to fail on JRuby. will commit
adds tmp directory & 22 TemplateDigestorTests which were failing before
are now green.

Further Discussion on this can be seen at #11743
2013-08-05 01:24:14 +05:30
Jan Szumiec 512603ee32 Removed an unnecessary loop - it kills performance on large texts. 2013-08-03 23:56:38 +01:00
Nathan Stitt 0855f041df Add "extname" option to javascript_include_tag
ActionView::Helpers.asset_path is where the logic for
javascript_include_tag resides.  It takes an extname option for
specifying the extension or false to not append it.  This exposes that
option to javascript_include_tag.

Without the option files that didn't end with ".js" would get the
extension appended to them.  This broke JST templates and other file
types that should be interpreted as JavaScript but who's file extension
isn't ".js"
2013-08-03 09:30:06 -05:00
Arun Agrawal a6dab95eb8 Using URI.parser.unescape
Fixes warning

warning: URI.unescape is obsolete
2013-08-03 09:10:27 -04:00
Rajarshi Das 36aaf46372 fix the changelog typo[ci skip] 2013-08-02 12:33:35 +05:30
Rafael Mendonça França b3c0858f73 Make current_page? compare binary strings 2013-08-01 17:59:25 -03:00
Rafael Mendonça França 69339e54d3 Fix `current_page?` when the URL contains escaped characters
In some cases webservers like nginx send the escaped characters
lowercased to the Rails application. The current_page? helper was
comparing the escaped strings that are different since Ruby escapes the
URL using uppercased characters.
2013-08-01 10:46:35 -03:00
Arun Agrawal 622d2a4b0d Moved README into action_view [ci skip] 2013-07-31 15:44:17 -04:00
Vipul A M 4ce11c0150 Change from `map` => `map!` and `collect!` to save creation of extra array. 2013-07-31 10:07:04 +05:30
thedarkone 650810fc6c AV::Digestor thread safety fixes.
This fixes potential thread safety issues introduced in 09f6fe1. The problem
with the original code was that the "recursion-stopping" `nil` values could
be seen by other threads.
2013-07-30 15:21:32 +02:00
Arun Agrawal f52832de2a grab executable from rubygems
As done here d7fc97d3f9
2013-07-26 11:07:25 +02:00
Rafael Mendonça França cd4feb31ce Merge pull request #11341 from arunagw/added-missing-actionview-to-install
Added description in actionview gemspec.
2013-07-25 07:12:11 -07:00
Joel Cogen 1424873948 text_area should handle nil value option like text_field 2013-07-24 08:39:17 +02:00
Carlos Antonio da Silva 1c4eb13345 Leave the knowledge of boolean tag values to content tag
content tag already knows which tags are boolean and the values that
should generate them when a truthy value is passed, so leave this logic
for it instead of duplicating when generating options tags.
2013-07-22 14:39:45 -03:00
Carlos Antonio da Silva b973852feb Use merge! to avoid a new hash and change some spots to 1.9 hash style 2013-07-22 14:36:10 -03:00
Carlos Antonio da Silva c23c193a84 Fix changelog syntax and use Ruby 1.9 hash style [ci skip] 2013-07-22 14:36:09 -03:00
Karunakar (Ruby) afa5445060 syntax fix for f.select doc. [ci skip] . 2013-07-22 18:04:50 +05:30
Vasiliy Ermolovich cadfe4bf45 add support for html attributes to grouped_options_for_select 2013-07-20 17:14:28 +03:00
Yves Senn eda66d89c7 Merge pull request #11508 from vipulnsward/extract_constants
Extract verbs array from helper to a contant
2013-07-20 01:46:10 -07:00
Vipul A M 30ca90a0b6 Extract verbs array from helper to a constant 2013-07-20 01:32:58 +05:30
Vipul A M ad3916d133 Fix test name typos 2013-07-19 20:15:14 +05:30
Rafael Mendonça França ebc5bdb8e7 Use the canonical router on the CHANGELOG entry
Thanks @egilburg

[ci skip]
2013-07-18 10:35:15 -03:00
Arun Agrawal 507c803a93 Added some description to generate actionview gem [ci skip] 2013-07-17 10:19:13 +02:00
kennyj ca85caca0d Fix default rendered format problem when calling render method without :content_type option. Closes #11393. 2013-07-15 02:11:43 +09:00
Rafael Mendonça França 4b6886a140 Merge pull request #11383 from mattdbridges/simple-format-doc-fix
Fix simple_format output example ending tag
2013-07-09 12:12:08 -07:00
Matt Bridges 7e1cb39f72 Fix simple_format output example ending tag 2013-07-09 14:09:26 -05:00
Arun Agrawal d6da0dc3f2 Removed unused require from actionview rakefile. 2013-07-09 00:10:24 +02:00
Rafael Mendonça França b18a27375a Add CHANGELOG entry for #11348 2013-07-07 14:26:20 -03:00
Rafael Mendonça França 9eeb3cc040 Merge pull request #11348 from sanemat/fix/link-to-block
Fix actionview link_to with block and url_hash
2013-07-07 10:02:39 -07:00
Rafael Mendonça França 09f6fe1cd4 Fix "Stack Level Too Deep" error when rendering recursive partials
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.

Fixes #11340
2013-07-07 13:44:16 -03:00
sanemat bcc30d8f2f Include block in a argument shift 2013-07-08 00:35:14 +09:00
Takayuki Matsubara 06388b0779 Added an `enforce_utf8` hash option for `form_tag` method
Control to output a hidden input tag with name `utf8` without monkey
patching

Before:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

After:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

    form_tag({}, { :enforce_utf8 => false })
    # => '<form>....</form>'
2013-07-07 23:49:38 +09:00
sanemat f71b075d6c Fix link_to with block and url_hash
Use link_to with block and url_hash, expect block as name.
But ignore block and use url_hash as name.
3-2-stable passes this test. 4-0-stable and master fail this.
2013-07-07 23:21:47 +09:00
Arun Agrawal 06ad30758c RUNNING_UNIT_TESTS file is in rdoc [ci skip] 2013-07-06 22:49:16 +02:00
sanemat 56e3419fef Remove action view test duplication
Same test exists above 2 or 3 lines.
2013-07-07 00:59:30 +09:00
Carlos Antonio da Silva 6b9356a4b7 Remove the deprecated include_seconds argument from distance_of_time_in_words
Pass in an :include_seconds hash option to use this feature.
2013-07-02 22:46:23 -03:00
Vipul A M 38aafc0377 Remove `FormBuilder` deprecation warning about block argument and associated tests 2013-07-02 02:06:39 +05:30
Santiago Pastorino 4eedb3928e Clean the code a bit 2013-06-29 21:20:08 -07:00
Jon Rowe 53eb9fdd9c fetch value(s) from stringified options 2013-06-29 19:32:13 +10:00
Carlos Antonio da Silva e16ad2db8c Review AV changelog [ci skip] 2013-06-27 15:39:17 -03:00
kennyj 94c72c45bb Remove passing the prompt to grouped_options_for_select as an argument, because it was deprecated. 2013-06-28 03:11:00 +09:00
Yves Senn 4f1a7dc956 Merge pull request #11141 from keydunov/master
Fix documentation for grouped_collection_select
2013-06-27 11:09:00 -07:00
kennyj 77cb37cc74 Fix copyright year for actionview [ci skip] 2013-06-28 01:05:08 +09:00
Artyom 2137f8842b Fix documentation for grouped_collection_select [ci skip] 2013-06-27 19:52:37 +04:00
Arun Agrawal c4f588213b Minor changes to actionpack/actionview Rakefile 2013-06-26 10:22:10 +02:00
Carlos Antonio da Silva f410c13bf8 Refactor cache fragment handling with read/write methods 2013-06-25 20:51:02 -03:00
Andrew Rove f341acdae3 Move the write portion of fragment_for to its own method to allow for easier creation of custom cache methods. 2013-06-25 20:46:02 -03:00
mariozig bf044a9bbe Fix typo in docs. HABTM associations should use a pluralized name 2013-06-25 15:35:03 -07:00
Carlos Antonio da Silva f02d4ddc99 Merge pull request #11046 from arunagw/verbose_mode_on
Verbose mode on when running tests
2013-06-25 15:15:43 -07:00
Ryan Williams 7acbe60328 Comment typo 2013-06-25 14:34:51 -04:00
Rafael Mendonça França 035e2976d0 Add CHANGELOG entry for #10971
[ci skip]

Conflicts:
	actionpack/CHANGELOG.md
2013-06-24 16:21:54 -03:00
Arun Agrawal d88b390dfd Adding verbose in isolated test. 2013-06-21 14:14:36 +02:00
Arun Agrawal 6f4d9ab823 Adding verbose mode to test_with_ar_integration 2013-06-21 14:12:13 +02:00
Arun Agrawal 67f668845e Saying gemcutter => rubygems [ci skip] 2013-06-21 11:04:52 +02:00
Łukasz Strzałkowski d6b1caa8f2 Check if malformed fixture exists first
Now if somebody by mistake will remove malformed files test will raise error.
2013-06-20 23:38:38 +02:00
Łukasz Strzałkowski 08998d2eec Restore mistakenly removed malformed file fixtures 2013-06-20 23:35:48 +02:00
Łukasz Strzałkowski 8b57b78c09 Rename AP to AV in info about running tests 2013-06-20 19:12:17 +02:00
Łukasz Strzałkowski 633f84c899 Bump up version, fix module name 2013-06-20 19:11:32 +02:00
Łukasz Strzałkowski d1fb5d5949 Adjust changelog for AV & AP 2013-06-20 19:06:52 +02:00
Łukasz Strzałkowski 1d59e94cea Remove heading from AV's CHANGELOG 2013-06-20 19:01:26 +02:00
Łukasz Strzałkowski 194aebb02d Fix isolated tests on AV 2013-06-20 18:24:50 +02:00
Łukasz Strzałkowski 995e9c41a5 Remove require to AP stuff that left 2013-06-20 17:23:17 +02:00
Łukasz Strzałkowski 6241513736 Fix digestor tests 2013-06-20 17:23:16 +02:00
Łukasz Strzałkowski c815775d01 Copy company test fixture to AV (fixes failing test) 2013-06-20 17:23:16 +02:00
Piotr Sarnacki f12109448b Remove unneeded test fixtures in AV 2013-06-20 17:23:16 +02:00
Piotr Sarnacki b01331e392 Add actionpack as actionview's development dependency
ActionView still relies on ActionPack in some of the tests.
2013-06-20 17:23:16 +02:00
Piotr Sarnacki 5e5bf31b4a Remove unneeded files 2013-06-20 17:23:16 +02:00
Piotr Sarnacki eb23754ebb Move template tests from actionpack to actionview 2013-06-20 17:23:16 +02:00
Piotr Sarnacki 5bcdf4faa6 ActionView version should be 4.1.0 2013-06-20 17:23:15 +02:00
Piotr Sarnacki 0d6e8edc2a Move actionpack/lib/action_view* into actionview/lib 2013-06-20 17:23:15 +02:00
Piotr Sarnacki 78b0934dd1 Add bare actionview gem to the root directory
This commit creates structure for Action View gem and is first of a
series of commits extracting Action View from Action Pack.
2013-06-20 17:23:15 +02:00