Commit Graph

2238 Commits

Author SHA1 Message Date
Jeremy Kemper 562b398fd7 Some mime type refactoring. Closes #9957 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 06:33:28 +00:00
Jeremy Kemper 6a35ed16c2 Remove duplicate rjs layout check. Closes #9956 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 05:54:19 +00:00
Jeremy Kemper 3334609ecb Expand form helper test coverage. Closes #9950 [robinjfisher]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-22 21:17:20 +00:00
Jeremy Kemper 79670fb975 request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-22 21:10:56 +00:00
David Heinemeier Hansson f777ff72f9 Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-21 18:58:17 +00:00
Rick Olson c9fecf20ff Ensure that cookies handle array values correctly. Closes #9937 [queso]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-20 17:30:01 +00:00
Michael Koziarski 62fd6532e5 Remove more potential clashes with asset methods and resource routes. Closes #9928 [gbuesing]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-19 02:46:41 +00:00
Michael Koziarski b1c3fc22c9 Rename image_path path_to_image to avoid conflicting with named routes. Closes #9924 [gbuesing]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-19 00:52:55 +00:00
Jeremy Kemper a9f790a748 Use SecureRandom to generate unique ids, if available.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-18 18:25:31 +00:00
Jeremy Kemper 011a209174 caches_page uses a single after_filter instead of one per action. Closes #9891.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 22:24:55 +00:00
Sam Stephenson 45107ecaf8 Update Prototype to 1.6.0_rc1 and script.aculo.us to 1.8.0 preview 0.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 21:08:29 +00:00
Michael Koziarski 534600eb7c More Performant Cookie Regexp for Integration tests. [Ola Bini]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 20:19:27 +00:00
Jeremy Kemper a2172e75f5 Dispatcher: fix that to_prepare should only run once in production. Closes #9889.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 16:36:52 +00:00
Jeremy Kemper 5cb6a9aabd Improve the error message for assert_redirected_to. Closes #7337 [mikong, sandofsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 05:07:23 +00:00
Jeremy Kemper cfe36d1609 Test link_to 'back', :back
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 05:06:55 +00:00
Jeremy Kemper cf2ee1451b Fix silent failure of rxml templates. Closes #9879.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7921 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 20:30:48 +00:00
Michael Koziarski fe234a1538 Fix Json related documentation for render and the AR serializer. Closes #9814. Closes #9833. [chuyeow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 07:04:10 +00:00
Michael Koziarski 3353b85b0e Sync country_select with ISO 3166 long names. Closes #6872 [abhay, mikong, ruben]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 06:52:00 +00:00
Michael Koziarski 61639262f1 Enhance documentation for observe_field. Closes #9808 [RubyRedRick, danger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 05:03:23 +00:00
Jeremy Kemper ae8179f05c Expand Routes::DynamicSegment test coverage. Closes #7122 [Kevin Clark]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 04:27:31 +00:00
Jeremy Kemper 86a9c212c0 Skip memcache tests unless it's installed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 01:47:35 +00:00
Jeremy Kemper 6e56cc013f Wrap test with uses_mocha
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 22:54:28 +00:00
Jeremy Kemper d0df7f2b12 Memcached sessions: add session data on initialization; don't silently discard exceptions; add unit tests. Closes #9823.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 20:46:06 +00:00
Jeremy Kemper a0bcb45b09 non-executable
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 20:45:48 +00:00
Jeremy Kemper 01cfda7cf2 error_messages_for also takes :message and :header_message options which defaults to the old "There were problems with the following fields:" and "<count> errors prohibited this <object_name> from being saved". Closes #8270.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 02:59:32 +00:00
Michael Koziarski 52235a70db Missed post_via_redirect. References #6834
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:34:24 +00:00
Michael Koziarski 569c7d5488 Define get_via_redirect as well. Closes #6834 [colthorp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:32:20 +00:00
Michael Koziarski bd03bf9f5e Make sure that custom inflections are picked up by map.resources by triggering a routing reload when new inflections are defined. Closes #9815 [mislav, kampers]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:28:35 +00:00
David Heinemeier Hansson faff774f9d Update versions here too
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-12 16:03:54 +00:00
Jeremy Kemper 21b51eda63 JavaScriptVariableProxy#to_json ignores the options arg
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-11 00:21:59 +00:00
David Heinemeier Hansson 6637f9069c Extracted sanitization methods from TextHelper to SanitizeHelper [DHH] Changed SanitizeHelper#sanitize to only allow the custom attributes and tags when specified in the call [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-10 17:35:10 +00:00
Jeremy Kemper 4db4661a67 rescue_from accepts :with => lambda { |exception| ... } or a normal block. Closes #9827.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-10 02:34:42 +00:00
Michael Koziarski 4aabe46341 Add :status to redirect_to allowing users to choose their own response code without manually setting headers. Closes #8297 [codahale, chasgrundy]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-09 23:07:36 +00:00
Michael Koziarski c2602354d1 form_for example for namespaced routes. Closes #9769 [sjgman9]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7799 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-08 05:50:59 +00:00
Jeremy Kemper 931be6ed1b 1 years -> 1 year
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-08 03:46:23 +00:00
Jeremy Kemper 8a2fa23cd1 Add tests for [7727]. Closes #6090 [dkubb, mpalmer, tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-08 03:33:30 +00:00
Michael Koziarski 074fe35b8a Add link_to :back which uses your referrer with a fallback to a javascript link. #7366 [eventualbuddha, tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7791 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-08 03:30:29 +00:00
Jeremy Kemper 459cc1ecb8 error_messages_for and friends also work with local variables. Closes #9699.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 19:50:30 +00:00
Jeremy Kemper d9f3c435f9 Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'. Closes #8562, #9525.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 19:12:02 +00:00
Jeremy Kemper 845e6ff45a String#to_xs uses the fast_xs extension if available for Builder speedup.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 09:15:26 +00:00
Jeremy Kemper 4430a00c04 BlankSlate -> BasicObject
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 06:45:01 +00:00
Jeremy Kemper 52ca5dad1e Use StringIO and Tempfile subclasses instead of defining singleton methods on each multipart field.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 11:40:13 +00:00
Jeremy Kemper 3405fb3dea Rewind stdin if possible after multipart parsing.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 09:39:31 +00:00
Jeremy Kemper 551f6e9bee Don't generate strings to log unless they'll actually get logged.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 09:28:50 +00:00
Jeremy Kemper 89eb53395b Typo
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 01:38:58 +00:00
Jeremy Kemper fe0df25f7b Move misplaced CHANGELOG entry
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 01:26:48 +00:00
Jeremy Kemper 335c15005d Bump versions for 1.2.4 release.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-05 05:20:37 +00:00
Jeremy Kemper 12d740dd57 Move #query_string to AbstractRequest
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7727 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 16:39:18 +00:00
Rick Olson 3dc62ab8f9 rescue LoadError if memcache isn't available while loading the MemCache fragment store
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 16:15:42 +00:00
Rick Olson 408f496402 Use #require_library_or_gem to load the memcache library for the MemCache session and fragment cache stores. Closes #8662. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 14:52:56 +00:00