Commit Graph

81276 Commits

Author SHA1 Message Date
Xavier Noria c192feb3eb Update Gemfile.lock 2021-08-21 10:35:03 +02:00
Xavier Noria fc9a179033 Depends on Zeitwerk 2.5.0.beta2 2021-08-21 01:23:21 +02:00
Xavier Noria e9f38a164e
Merge pull request #43058 from rails/del-private-constantize
Delete AS::Dependencies.(safe_)constantize
2021-08-20 18:25:48 +02:00
Xavier Noria 38e82daee8 Delete AS::Dependencies.safe_constantize 2021-08-20 17:51:05 +02:00
Xavier Noria 3e3504bdaa Delete AS::Dependencies.constantize 2021-08-20 09:47:22 +02:00
Jonathan Hefner 074c7f50c5
Merge pull request #43018 from ChaelCodes/document-order
[DOCS] Improve Documentation for ActiveRecord's order Method [ci-skip]
2021-08-19 09:20:11 -05:00
Rachael Wright-Munn d6a38d2c43 Improve Documentation around the options that can be passed to order.
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
2021-08-19 09:16:25 -05:00
Ryuta Kamizono 64a3bb892f
Merge pull request #43052 from p8/activerecord/change-joins-docs
Improve description of ActiveRecord.joins [ci-skip]
2021-08-19 21:26:44 +09:00
Petrik bdd7e24bf2 Improve description of ActiveRecord.joins [ci-skip]
Joins is the plural of join. So "a joins" doesn't seem correct.
To make it clear joins is a SQL term, we can upcase it just like the
descriptions for GROUP, HAVING and SELECT.
2021-08-19 14:05:01 +02:00
Xavier Noria 6b5915895b
Merge pull request #43048 from rails/drop-orphan-methods
Drop orphan methods in AS::Dependencies
2021-08-19 00:32:22 +02:00
Xavier Noria d4ab55e901 Delete orphan requires in AS::Dependencies 2021-08-19 00:14:06 +02:00
Xavier Noria c640deef99 Delete AS::Dependencies.explicitly_unloadable_constants 2021-08-18 23:26:29 +02:00
Xavier Noria fb9a33d602 Delete AS::Dependencies.mechanism 2021-08-18 23:26:25 +02:00
Xavier Noria 0f2d2ba87d Delete AS::Dependencies.load? 2021-08-18 23:26:20 +02:00
Xavier Noria ed1571ddc0 Delete AS::Dependencies.autoloadable_module? 2021-08-18 23:26:16 +02:00
Xavier Noria c1a89b57df Delete AS::Dependencies.load_once_path? 2021-08-18 23:26:12 +02:00
Xavier Noria bde4b04323 Delete AS::Dependencies.uninitialized_constant 2021-08-18 23:26:07 +02:00
Xavier Noria bc2cd69c22 Delete AS::Dependencies::WatchStack 2021-08-18 23:26:03 +02:00
Xavier Noria dd5d632a6b Delete AS::Dependencies.constant_watch_stack 2021-08-18 23:25:59 +02:00
Xavier Noria e5cdd54525 Delete AS::Dependencies.will_autoload? 2021-08-18 23:25:54 +02:00
Xavier Noria 2105d1ed3e Delete AS::Dependencies.mark_for_unload 2021-08-18 23:25:49 +02:00
Xavier Noria 7788697797 Delete AS::Dependencies.loading 2021-08-18 23:25:49 +02:00
Xavier Noria 4ba449aafb Delete AS::Dependencies.loaded 2021-08-18 23:25:49 +02:00
Xavier Noria 46576a4555 Delete AS::Dependencies.history 2021-08-18 23:25:49 +02:00
Xavier Noria 5102fdeacf Delete AS::Dependencies.remove_constant 2021-08-18 23:25:49 +02:00
Xavier Noria 2b31655493 Delete AS::Dependencies.new_constants_in 2021-08-18 23:25:49 +02:00
Xavier Noria e24ae73021 Delete AS::Dependencies.qualified_name_for 2021-08-18 23:25:49 +02:00
Xavier Noria 1b92154ff4 Delete AS::Dependencies.autoload_module! 2021-08-18 23:25:49 +02:00
Xavier Noria 7b2223be8b Delete AS::Dependencies.remove_unloadable_constants! 2021-08-18 23:25:49 +02:00
Xavier Noria d3ffcafb14 Delete AS::Dependencies.load_file 2021-08-18 23:25:44 +02:00
Xavier Noria 805067e6d2 Delete AS::Dependencies.loadable_constants_for_path 2021-08-18 23:25:35 +02:00
Xavier Noria 98381b7ba2 Delete AS::Dependencies.require_or_load 2021-08-18 22:44:59 +02:00
Xavier Noria 1343a3a67d Delete AS::Dependencies.load_missing_constant 2021-08-18 22:43:52 +02:00
Xavier Noria 27262897c7 Delete AS::Dependencies::Loadable 2021-08-18 22:31:07 +02:00
Xavier Noria a7a217212b Delete AS::Dependencies::ModuleConstMissing 2021-08-18 22:27:55 +02:00
Xavier Noria 627037fa8b Delete AS::Dependencies.depend_on 2021-08-18 22:24:08 +02:00
Xavier Noria cb0c746b7d Revises the autoloading guide [skip ci] 2021-08-18 21:37:50 +02:00
Rafael Mendonça França cabe311f67
Make `DatabaseConnectionError` a subclass of `ConnectionNotEstablished`
Before the introduction of this exception, we where raising
a `ConnectionNotEstablished` and users might be rescuing that exception
already.

As the goal of the new exception was to be more specific, we should be
subclassing `ConnectionNotEstablished` to keep the old behaviour.
2021-08-18 18:44:52 +00:00
Xavier Noria 4b4895e60d Tweaks wording in guide [skip ci]
The way it was written, it was not 100% clear if that was the name
to choose or the one to avoid.
2021-08-18 09:14:21 +02:00
Rafael Mendonça França 614fc3d827
Delay the exclusion of the configs to the last minute
The framework still rely on the configuration object being modified
in initializers, so we need to delay the exclusion to the last minute.
2021-08-18 00:04:25 +00:00
Rafael Mendonça França 3ca36fb9ef
Fix action_on_unpermitted_parameters setter
If the falue is false we should not try to calculate it.
2021-08-17 23:40:55 +00:00
Rafael Mendonça França bc00484d2c
No need to check if the logs are enable to run those tests 2021-08-17 23:35:49 +00:00
Rafael Mendonça França ac77ab469f
Only try to configure the query log tags if Active Record is present 2021-08-17 23:35:47 +00:00
Rafael Mendonça França a6aa9376f1
Stop relying on mutating the configuration object 2021-08-17 23:35:46 +00:00
Rafael Mendonça França 8af78700d2
Improve taggings API by introducing a null object
Instead of adding chains of `&.` we should use a null object to allow
the taggings definition to be more concise.
2021-08-17 23:35:44 +00:00
Rafael Mendonça França 18cd634e07
Fix initialization proccess of the query tags
The tags were being added in the wrong way, now it is always using the
configuration.
2021-08-17 22:59:44 +00:00
Rafael Mendonça França 16242464db
Allow tag values to be static 2021-08-17 22:59:24 +00:00
Rafael Mendonça França 1e3e1a0e72
No need for memoization
At this point the application name can't change.
2021-08-17 22:41:03 +00:00
Rafael Mendonça França 84376c3e03
Move default tagging configuration to the railtie
All other tags are there, so there is no need to keep them separated.
2021-08-17 22:38:27 +00:00
Rafael Mendonça França 6d983e86da
Remove more unneeded methods that should be configs 2021-08-17 22:35:22 +00:00