mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
65,869 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

5321 Commits

Author SHA1 Message Date
George Claghorn dab7d401e8 Demonstrate providing keyfile data in lieu of a path [ci skip] 2017-12-28 17:18:40 -05:00
George Claghorn 09d4cb4225 Link to the client gems [ci skip] 2017-12-28 17:11:15 -05:00
bogdanvlviv 181a9fdafe
Update "Action View Overview" guide [ci skip] 
- Provide full / Fix generated HTML by `form_for` in the example.
  - Provide full params in the example.
  - Express params[:person] in the sentence.
 2017-12-26 13:30:39 +02:00
Jan Bussieck ee7fb923d4 [docs] Add mention of removal of HWIA interface from `AC:Parameters` 
[ci skip]
 2017-12-22 22:01:49 +01:00
SHIBATA Hiroshi fd6522a4b4 Revert "Specify bundler version in template files" 
This reverts commit b106242f52.
 2017-12-22 23:07:14 +09:00
Matthew Draper 08b9d8b3e0
Merge pull request #31177 from albertoalmagro/remove-default-mysql-engine-from-ar-5-2 
Remove default ENGINE=InnoDB for Mysql2 adapter
 2017-12-20 10:47:36 +10:30
Dixit Patel 4e8082f5fa [ci skip] Added Object Relational Mapping wiki link 2017-12-19 11:19:26 +05:30
Xavier Noria 475a0f887c emphasize working on existing issues/patches for newcomers [ci skip] 
Thanks to @Datasnuten for the suggestion.
 2017-12-17 14:14:40 +01:00
Kasper Timm Hansen 28d2968533
Merge pull request #31316 from bogdanvlviv/update-association_basics-guide 
Update "Active Record Associations" guide [ci skip]
 2017-12-16 10:18:52 +01:00
Yoshiyuki Hirano 94baf7291a Fix Active Storage Overview guide [ci skip] 2017-12-16 14:25:45 +09:00
Claudio B 6211445d55 [ci skip] Use :amazon, not :s3, to reflect code 
The [template](https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/config/storage.yml.tt#L10)
that generates the `config/storage.yml` file has the Amazon S3 key specified as `:amazon`, not `:s3`.

The guides should reflect the nomenclature, given that every other service also
has the name of the company as the key (:google, :microsoft).
 2017-12-15 15:49:18 -08:00
Ryuta Kamizono cda7e63abc Sync header title with file name [ci skip] 
Like other Basics and Overview guides.
 2017-12-15 16:52:27 +09:00
Yauheni Dakuka 83e10bd068 Fix in ASt guide [ci skip] 2017-12-15 10:33:38 +03:00
yuuji.yaginuma 6a902d43c7 Fix guide generation error [ci skip] 
Currently, generation of guide is an error in `5_2_release_notes.html`.

```
$ bunele exec rake guides:generate:html
Generating 5_2_release_notes.md as 5_2_release_notes.html
rails/guides/rails_guides/markdown.rb:44:in `dom_id': undefined method `[]' for nil:NilClass (NoMethodError)
	from rails/guides/rails_guides/markdown.rb:106:in `block (2 levels) in generate_structure'
```

It seems that it is an error because there are multiple
`active-storage` anchors.

Since Active Storage is a Major feature, it is unnecessary to show
CHANGELOGs, so remove from `Incompatibilities` section.
 2017-12-15 15:52:02 +09:00
Ryuta Kamizono 597b941930 [ci skip] Add missing **DO NOT READ THIS FILE ON GITHUB, GUIDES ARE PUBLISHED ON http://guides.rubyonrails.org.** 2017-12-15 14:02:25 +09:00
Yoshiyuki Hirano 63554cb322 [ci skip] Update guide index for active storage 2017-12-15 13:19:55 +09:00
Jeffrey Guenther 53757939b7 Tweak whitespace 2017-12-14 19:09:48 -08:00
Jeffrey Guenther 1dba0a279d Formatting updates 2017-12-14 19:08:33 -08:00
Jeffrey Guenther 1c5358e472 Merge branch 'master' into activestorage-guide 2017-12-14 19:03:28 -08:00
Yasuo Honda e4a6a23aa7 Suppress `warning: BigDecimal.new is deprecated` 
`BigDecimal.new` has been deprecated in BigDecimal 1.3.3
 which will be a default for Ruby 2.5.

Refer
533737338d

* This commit has been made as follows:

```
cd rails
git grep -l BigDecimal.new | grep -v guides/source/5_0_release_notes.md | grep -v activesupport/test/xml_mini_test.rb | xargs sed -i -e "s/BigDecimal.new/BigDecimal/g"
```
- `activesupport/test/xml_mini_test.rb`
Editmanually to remove `.new` and `::`

- guides/source/5_0_release_notes.md
This is a Rails 5.0 release notes.
 2017-12-15 01:19:57 +00:00
bogdanvlviv ff214c3715
Update "Active Record Associations" guide [ci skip] 
- Make all `ActiveRecord::Base.find` as link
  - Remove redundant sentences
    "It also adds the additional condition that the object must be in the collection."
 2017-12-14 21:31:59 +00:00
Eileen M. Uchitelle 53593a6636
Merge pull request #30474 from yhirano55/make_it_same_title_in_index_and_page 
Make it same title in index and page [ci skip]
 2017-12-13 10:23:14 -05:00
bogdanvlviv 011e641d19
Update 'Configuring Rails Applications' guide 
- Add mention about `config.active_record.internal_metadata_table_name`
  - Add mention about `config.active_record.protected_environments`
 2017-12-12 23:31:25 +00:00
fatkodima 77ef84d61e Remove stale comment about `ActiveRecord::SchemaDumper.ignore_tables` [skip ci] 2017-12-12 14:19:26 +02:00
Ryuta Kamizono c5462d1f27
Merge pull request #31402 from yhirano55/update_routing_guide_for_direct_method 
[ci skip] Update routing guide for Direct & resolved routes
 2017-12-12 14:56:21 +09:00
Yoshiyuki Hirano 3dc774f371 [ci skip] Update routing guide for Direct 
* Added the direct method to routing guide.
 2017-12-12 14:07:58 +09:00
Yoshiyuki Hirano 19e9e1492e [ci skip] Update instrumentation guide for ActiveStorage 
* Added `service_delete_prefixed.active_storage`.
 2017-12-12 04:17:14 +09:00
Alberto Almagro 95b6a198ef Remove default ENGINE documentation for MySQL and MariaDB 
Removes default ENGINE documentation hint for MySQL and MariaDB as we
aren't taking measures to set the default ENGINE anymore.
 2017-12-11 10:46:25 +01:00
Jeffrey Guenther ab2a95db80 Apply edits and suggestions 2017-12-08 13:44:59 -08:00
Jeffrey Guenther a822287cef Merge branch 'master' into activestorage-guide 2017-12-08 13:25:54 -08:00
bogdanvlviv 82b974813b
Add headless firefox driver to System Tests 2017-12-07 20:20:54 +02:00
Eileen M. Uchitelle ce37e1643a
Merge pull request #31345 from yhirano55/add_assert_in_epsilon_to_testing_guide 
Add `assert_in_epsilon` to Testing guide [ci skip]
 2017-12-06 09:21:54 -05:00
Yoshiyuki Hirano 5f7fd1584f Add `assert_in_epsilon` to Testing guide [ci skip] 
I found `assert_in_epsilon` is not be in "2.4 Available Assertions".
So I Added them.

MiniTest::Assertions#assert_in_epsilon:

https://github.com/seattlerb/minitest/blob/master/lib/minitest/assertions.rb#L204-L210
 2017-12-06 09:09:32 +09:00
Jeffrey Guenther 08fab27db5 Incorporate latest round of feedback 2017-12-04 20:56:16 -08:00
bogdanvlviv 20bb26a428
Update "Active Record Query Interface" guide [ci skip] 
- Add missing `LIMIT 1` for some queries
  - Make some examples of query more readable
 2017-12-04 01:18:59 +02:00
willnet 99f6722e86 [ci skip] Add a missing space before closing curly braces 2017-12-02 16:35:38 +09:00
Yuji Yaginuma 81b2aed360
Merge pull request #31293 from ydakuka/fix-gemfile-guides 
Cosmetic changes for Gemfile [ci skip]
 2017-12-01 11:43:05 +09:00
Jeffrey Guenther 29051b60a2 Change info to note 2017-11-30 09:19:57 -08:00
Jeffrey Guenther 858e5cd09c Adds Javan's event example 2017-11-30 09:01:01 -08:00
Jeffrey Guenther 241b5f1ceb Merge branch 'master' into activestorage-guide 2017-11-30 08:43:37 -08:00
Jeffrey Guenther 3429ab14a6 First pass on incoporating George's feedback 2017-11-30 08:42:04 -08:00
Dixit Patel 96d17ecba8 [ci skip] Updated links for uncorn which redirect & added https for nginx link 2017-11-30 17:05:48 +05:30
Yauheni Dakuka b6baf0c884 Cosmetic changes [ci skip] 2017-11-30 09:35:26 +03:00
Rafael Mendonça França 2837d0f334
Preparing for 5.2.0.beta2 release 2017-11-28 14:41:02 -05:00
Fatos Morina 37cf9b3466 Fix typos and add a few suggestions 2017-11-28 19:27:43 +01:00
Dixit Patel ce180231d9 [ci skip] Update MVC wiki link 2017-11-28 16:42:11 +05:30
Rafael Mendonça França 052620e003
Add releases notes to the guides index 2017-11-27 14:51:20 -05:00
Rafael Mendonça França cceeeb6e57
Preparing for 5.2.0.beta1 release 2017-11-27 14:50:03 -05:00
Rafael França 5fb36d03db
Merge pull request #31242 from fgo/patch-22 
Update Rails on Rack guide [ci skip]
 2017-11-27 14:48:04 -05:00
Francis Go 9cb7c90c59 Update Rails on Rack guide [ci skip] 2017-11-27 18:43:24 +00:00