Commit Graph

309 Commits

Author SHA1 Message Date
David Rodríguez 0c2c32d3d6 Fix warnings in railties tests
This warning has been fixed in sass-rails. This change picks up the fix.
2017-07-24 12:55:08 +02:00
Dwight Watson de550be5ea Update rack-test dependency constraint 2017-07-24 15:09:00 +10:00
Kasper Timm Hansen 5c16dd35a2 Move back to @matthewd's close io fixed rb-inotify. 2017-07-19 19:45:42 +02:00
Burke Libbey 0312a5c67e
Add bootsnap to default Gemfile:
Bootsnap precomputes load path resolution and caches ruby ISeq
and YAML parsing/compilation, reducing application boot time by
approximately 50% on supported configurations.
2017-07-17 13:17:45 -04:00
Kasper Timm Hansen 0391bbc01b Bump minitest; Use double quotes 2017-07-15 21:19:13 +02:00
Kasper Timm Hansen aad42dce10 Merge branch 'master' into unlock-minitest 2017-07-15 21:17:27 +02:00
Rafael Mendonça França 44f3ecbe5f Test thor master 2017-07-07 15:16:39 -04:00
Rafael Mendonça França 2975aeb888 Commit gemfile.lock 2017-07-04 14:55:50 -04:00
Kir Shatrov 4ee42379cc Use bulk INSERT to insert fixtures
Improves the performance from O(n) to O(1).
Previously it would require 50 queries to
insert 50 fixtures. Now it takes only one query.

Disabled on sqlite which doesn't support multiple inserts.
2017-06-20 13:18:53 -04:00
Matthew Draper 67a579419b Merge pull request #29488 from utilum/update_gemfile
Fixes FIXME: rb-inotify 0.99 has been released
2017-06-18 05:23:53 +09:30
utilum 96d58433c9 Fixes FIXME: rb-inotify 0.99 has been released 2017-06-17 18:59:41 +02:00
yuuji.yaginuma 3ab7483f47 Bundle capybara 2.14.1 that includes fix for Ruby warnings
Ref: https://github.com/teamcapybara/capybara/pull/1868
2017-06-08 11:14:54 +09:00
Akira Matsuda d1d39710cc Let's test nokogiri 1.8 against edge Rails, and vice versa 2017-06-06 17:32:49 +09:00
Rafael Mendonça França 62d316c6d8
Merge branch 'master' into unlock-minitest 2017-06-02 12:24:31 -04:00
Rafael França eb804ad5a7 Merge pull request #29187 from robin850/remove-mathn
Remove requirement on mathn
2017-05-30 11:37:15 -04:00
Robin Dupret ba84867549 Remove requirement on mathn
The test using mathn was first introduced in f1d9179 to check that the
`distance_of_time_in_words` properly doesn't use the `Fixnum#/` method
by explicitly requiring this library as it redefines this method.

Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since
version 2.2, we can certainly safely assume that people will most-likely
not require this library in their application.

However, to make sure that we don't regress, let's add a test similar to
the one before f1d9179.
2017-05-30 13:46:21 +02:00
Koichi ITO 6c13663c2b Bump RuboCop to 0.49.1 2017-05-30 07:30:22 +09:00
Kasper Timm Hansen e1758b5e8c Merge branch 'master' into unlock-minitest 2017-05-29 20:37:35 +02:00
yuuji.yaginuma d4d44e7e1d Bump `delayed_job_active_record` gem 2017-05-28 21:33:16 +09:00
Matthew Draper d93cd4357b Switch to rb-inotify master
https://github.com/guard/rb-inotify/pull/49 has been merged.
2017-05-27 09:38:08 +09:30
Koichi ITO 525586417e Bump rubocop and dependent gem versions 2017-05-24 15:20:00 +09:00
Akira Matsuda 7a2041335f bundle up sidekiq to the one with safer integration with Rails 5
see: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md
2017-05-21 21:34:33 +09:00
Akira Matsuda d577e780ba bundle up redis to the one that does not warn about ::Fixnum deprecation 2017-05-21 12:33:47 +09:00
Akira Matsuda 45d7d80ea6 mathn has been gemified in ruby 2.5 2017-05-19 18:42:43 +09:00
Akira Matsuda 579757cbff bundle mail 2.6.5 that includes fix for ::Fixnum warning 2017-05-19 17:50:25 +09:00
yuuji.yaginuma 6086fbaecf Bump rack version 2017-05-16 07:25:56 +09:00
Justin Coyne 673a5644ac Allow capybara minor releases
Capybara 2.14.0 was released. Loosen the tight constraint in the
generated Gemfile, so that Rails applications can take advantage of the
new version
2017-05-05 10:26:59 -05:00
Ryuta Kamizono 626f3d6088 Don't pass `arel.engine` to `Arel::SelectManager.new`
The argument of `Arel::SelectManager.new` is `table`, not `engine`.

https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
2017-05-05 15:39:42 +09:00
Yasuo Honda 4d07e1c60b Use mysql2 0.4.6 to suport MySQL 8.0.1
Follow up #28733 and brianmario/mysql2#840
2017-05-04 13:35:23 +00:00
Rafael Mendonça França 1421950512
Add minitest-bisect as part of the gemfile 2017-04-26 22:54:54 -07:00
Rafael Mendonça França 2883d2dff6
Release minitest lock so we can fix the order dependent tests 2017-04-26 22:53:55 -07:00
Zachary Scott 8e98cdfe63 Ask for a sane version of SDoc
This will allow me to push a release, including bug fixes,
without having to update Rails everytime.
2017-04-23 16:32:57 +09:00
Rafael Mendonça França 0871e5e5c1
Fix all style guides violations
Closes #28382
Closes #28651
2017-04-19 20:13:42 -04:00
Kasper Timm Hansen 01caad190f Bump the bundled GlobalID version. 2017-04-16 17:40:00 +02:00
Matthew Draper 19ae6597b8 Revert "Avoid broken faraday 0.12.0 release"
This reverts commit 82a7593e3a.
2017-04-02 21:32:33 +09:30
Matthew Draper 82a7593e3a Avoid broken faraday 0.12.0 release 2017-04-02 18:18:52 +09:30
Matthew Draper 6c08d480f1 Start Rails 5.2 development 2017-03-22 10:11:39 +10:30
eileencodes eadbc82c47 Bump Capybara and include Minitest::Assertions
Capybara was updated in teamcapybara/capybara#1841 to use Minitest style
assertions so that system test output shows x number of assertions, x
numbe of failures, etc.

Before:

```
6 runs, 0 assertions, 0 failures, 0 errors, 0 skips
```

After:

```
6 runs, 7 assertions, 1 failures, 0 errors, 0 skips
```

This change bumps Capybara from 2.7.0 to 2.13.0 and includes the
required minitest assertion file in the test case. 🎉
2017-03-17 08:22:22 -04:00
Javan Makhmali 2d2b3025ec Restore action_cable.js UMD module support. Fixes #28366 2017-03-11 16:12:36 -05:00
Rafael Mendonça França f4acdd83ff
Preparing for 5.1.0.beta1 release 2017-02-23 14:53:21 -05:00
Rafael Mendonça França ea9566f6cd
Use released arel 2017-02-21 11:46:42 -05:00
eileencodes 1a0ca84a06 Move and rename system tests
* Move system tests back into Action Pack
* Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase`
* Remove private base module and only make file for public
`SystemTestCase` class, name private module `SystemTesting`
* Rename `ActionSystemTestCase` to `ApplicationSystemTestCase`
* Update corresponding documentation and guides
* Delete old `ActionSystemTest` files
2017-02-20 15:07:35 -05:00
eileencodes 5bf0aa6745 Turn system testing into it's own gem and rename
Renames `Rails::SystemTestCase` to `ActionSystemTest` and moves it to a
gem under the Rails name.

We need to name the class `ActionSystemTestCase` because the gem expects
a module but tests themselves expect a class.

Adds MIT-LICENSE, CHANGELOG, and README for the future.
2017-02-20 15:07:33 -05:00
eileencodes 9730b1dba6 Add tests for system testing
* Adds test case test
* Adds driver adapter test
* Adds tests for capybara seleium driver (testing the settings not
actually opening the browser to test capybara w/ selenium because that
would so so so slow)
* Adds tests for rack test driver
* Adds tests for generators
2017-02-20 15:07:32 -05:00
Akira Matsuda c92520077c Test with the newest i18n
which is bundled in new apps by default
2017-02-11 06:12:07 +09:00
yuuji.yaginuma 4a694c19e2 Use released resque 2017-02-10 15:31:41 +09:00
Rafael Mendonça França f04a49b033
Fix rubocop violations 2017-02-09 23:13:41 -03:00
Akira Matsuda 6a1c0218df delayed_job and delayed_job_active_record gems with AR5 support are available 2017-01-29 09:05:06 +09:00
Akira Matsuda 786710b061 bundle update some gems
* puma 3.7.0: to let kill("TERM") properly terminate the process in railties test (3.6.2 doesnot on my machine)
* amq-protocol 2.1.0: to reduce warnings in AJ tests
* rails-html-sanitizer: missing change in a previous commit that updated Gemfile
2017-01-29 07:07:19 +09:00
Jeremy Evans 7da8d76206
Change ActionView ERB Handler from Erubis to Erubi
Erubi offers the following advantages for Rails:

* Works with ruby's --enable-frozen-string-literal option
* Has 88% smaller memory footprint
* Does no freedom patching (Erubis adds a method to Kernel)
* Has simpler internals (1 file, <150 lines of code)
* Has an open development model (Erubis doesn't have a
  public source control repository or bug tracker)
* Is not dead (Erubis hasn't been updated since 2011)

Erubi is a simplified fork of Erubis that contains just the
parts that are generally needed (which includes the parts
that Rails uses).  The only intentional difference in
behavior is that it does not include support for <%=== tags
for debug output.  That could be added to the ActionView ERB
handler if it is desired.

The Erubis template handler remains in a deprecated state
so that code that accesses it directly does not break.  It
can be removed after Rails 5.1.
2017-01-25 01:41:27 -07:00
Akira Matsuda 641a490e56 Revert "I guess we're ready for the randomized tests now"
This reverts commit 8c155c932f.

Not really 😢
2017-01-18 20:52:21 +09:00
Akira Matsuda 8c155c932f I guess we're ready for the randomized tests now 2017-01-18 18:27:05 +09:00
Rafael Mendonça França af5dd491b5
Fix all rubocop violations 2017-01-17 22:10:14 -05:00
toshimaru 6e30114c0a update rubocop to 0.47 2017-01-16 15:34:30 +09:00
Akira Matsuda 46fdbc5290 Revert "bundle u mocha"
This reverts commit 66e5b9d3f4.

We're seeing some test failures in AR postgresql tests
2017-01-16 00:16:41 +09:00
Akira Matsuda 66e5b9d3f4 bundle u mocha
I see no reason not to use the newest stable version.
2017-01-15 22:58:40 +09:00
Kir Shatrov 240f1e7162 Update builder gem to avoid deprecations of 2.4 2017-01-13 13:50:25 -05:00
Akira Matsuda 1db9e9e8f1 bundle u sqlite3
this fixes sqlite3-1.3.12/lib/sqlite3/pragmas.rb:301: warning: method redefined; discarding old integrity_check
2017-01-05 17:39:45 +09:00
Rafael Mendonça França e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
Tony Arcieri c434b97628 Upgrade to nio4r 2.0.0
nio4r 2.0.0 primarily includes new features and bugfixes, with few breaking
changes. The primary reason for bumping the major version is dropping support
for all Ruby versions prior to 2.2.2, so as to match Rails 5.

Full release announcement here:

https://groups.google.com/forum/#!topic/socketry/ZDIUj1ufiJ8
2016-12-28 19:45:39 -08:00
Rafael Mendonça França fce3c0cf64
Upgrade gems 2016-12-28 00:34:59 -05:00
Matthew Draper 933ae2cc14 bundle update 2016-12-27 23:58:29 +10:30
Ryuta Kamizono 821e17de66 Restore missing Gemfile.lock entries
These lines were lost in 774be3ea3b (diff-e79a60dc6b85309ae70a6ea8261eaf95L204).
2016-12-27 00:51:07 +09:00
Matthew Draper 774be3ea3b bundle update 2016-12-26 23:17:54 +10:30
Zachary Scott eeb1926158 Bump sdoc to rc1 which includes zzak/sdoc#98 2016-12-25 17:55:21 +09:00
Akira Matsuda f28b8892ab bundle u rake to 12.0.0 2016-12-24 06:00:49 +09:00
Jon Moss b50090a561 Bump concurrent-ruby and sprockets
Bumped to Ruby 2.4 compatible versions
2016-12-20 15:07:33 -05:00
Bian Jiaping 88792b1b2e Fix rake guides:generate:kindle error 2016-12-18 23:13:50 +08:00
eileencodes 8a37ac9264 Bump coffee-script-source to fix bug
Coffee script 1.12.1 was released and contained a bug where coffee
script was undefined. 1.12.1 was yanked and 1.12.2 was released. This
bumps coffee-script-source so that CI Railties tests pass.

See: https://github.com/jashkenas/coffeescript/issues/4403
2016-12-16 10:43:44 -05:00
Guillermo Iguaran ffb81ad6e3 rails-ujs is now shipped with Action View 2016-11-29 09:48:19 -05:00
Rafael França 06d2049618 Merge pull request #27196 from kirs/rubocop-gem
Add rubocop to Gemfile
2016-11-28 17:32:48 +01:00
Kir Shatrov 61fa0a8675 Add rubocop to Gemfile 2016-11-28 10:28:21 -05:00
Guillermo Iguaran 277b5f9af8 Add rails-ujs as dependency in the rails Gemfile 2016-11-21 18:58:36 -05:00
Javan Makhmali 6f30cb3559 Bump Blade and its Sauce Labs plugin to fix tunnel shutdown and related error
https://travis-ci.org/rails/rails/jobs/165766716#L506
2016-11-21 09:49:59 -05:00
Jon Moss 3256dcd8b9 Install libxml-ruby gem so full XMLMini test suite can be run 2016-11-19 10:46:28 -05:00
Akira Matsuda 3a558aa2bc Make sure to bundle json 2.x on CI
Without this, bundler tries to bundle json 1.8 on Ruby 2.4 in some cases
https://travis-ci.org/rails/rails/jobs/175874852
2016-11-15 09:26:03 +09:00
Gianfranco Montoya 13441a77a6 Update sqlite3 2016-11-04 11:12:28 -05:00
Rafael França c05a209fe9 Merge pull request #26851 from Gaurav2728/update-kindlerb
update kindlerb gem
2016-10-25 14:19:12 -02:00
Guillermo Iguaran 52852733d2 Update mysql2 version in Gemfile.lock 2016-10-22 20:09:02 -05:00
Gaurav Sharma f0bacbc2c4 update kindlerb gem
Ruby Kindle periodical-format ebook generator
2016-10-21 09:37:24 +05:30
Zachary Scott db85fa1db4 Include sdoc 1.0.0.beta2 which includes updated rdoc w/o hard json dep 2016-10-07 18:51:27 +09:00
Zachary Scott 91efc4fc0b Bump sdoc to 1.0.0.beta1 which includes fix to support Ruby 2.4 2016-10-07 18:42:22 +09:00
Matthew Draper acd7ba795e Use a branch of websocket-client-simple, to work around read/close race 2016-10-06 12:51:26 +10:30
Ryuta Kamizono 432cc58a29 Restore missing Gemfile.lock entries
These lines were lost in https://github.com/rails/rails/pull/26695/files#diff-e79a60dc6b85309ae70a6ea8261eaf95L192.
2016-10-04 09:25:31 +09:00
Esteban Santana Santana ddddedc487 Allow the use of listen's 3.1.x branch.
When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.
2016-10-03 16:58:17 +05:30
Matthew Draper 7c812c2401 Use websocket-client-simple instead of Faye as a websockets client
Mostly, this is just to avoid EventMachine. But there's also an argument
to be made that we're better off using a different protocol library for
our test suite than the one we use to implement the server.
2016-10-02 12:25:33 +10:30
Ryuta Kamizono f88ed6020b Restore missing Gemfile.lock entries
These lines were lost in https://github.com/rails/rails/commit/12d5c210#diff-e79a60dc6b85309ae70a6ea8261eaf95L191.
2016-09-20 23:01:35 +09:00
Rafael Mendonça França 12d5c21031
Override the github git source instead of changing manually all entries 2016-09-14 10:58:21 -03:00
Prathamesh Sonpatki cc769d03dc
Use :git for specifying dependencies from github with https protocol
- This is required for bundler 1.13.0 because of which lot of specs are
  failing on Travis CI.
- Similar to https://travis-ci.org/rails/rails/jobs/158905576#L559
2016-09-10 20:15:53 +05:30
Ryuta Kamizono 906577db06 Add accidentally removed dependency in Gemfile.lock
Follow up to ca0b6d0d41.
2016-08-04 07:55:47 +09:00
Sean Griffin ca0b6d0d41 Don't require C dependencies on Windows/JRuby 2016-08-03 10:14:26 -04:00
Rafael Mendonça França 5859cbddc3
Use a form of rb-inotify to fix broken tests with Ruby 2.2.5
See https://github.com/nex3/rb-inotify/pull/49
2016-07-27 23:39:10 -03:00
Rafael Mendonça França 3778350fed
Bump arel 2016-07-27 20:23:31 -03:00
Prathamesh Sonpatki 1a50262b5b
Bump Arel to fix few failing tests on Ruby 2.4 related to the Integer unification
* Following tests were failing on Ruby edge 2.4 version -

- RelationTest#test_update_all_with_joins_and_offset_and_order:
- RelationTest#test_update_all_with_joins_and_offset:
- BasicsTest#test_no_limit_offset:
- CalculationsTest#test_offset_is_kept:
- ActiveRecord::CollectionCacheKeyTest#test_cache_key_for_queries_with_offset_which_return_0_rows:
- FinderTest#test_third_to_last:

* As Arel 7.1 supports Integer unification after https://github.com/rails/arel/pull/437 we can use it.
2016-07-24 09:17:45 +05:30
yuuji.yaginuma 8c46abfd70 test with latest resque
When run test of Active Job with resque 1.26, occurs following error.

```
QueuingTest#test_current_locale_is_kept_while_running_perform_later:
NoMethodError: undefined method `current_tags' for #<Resque::QuietFormatter:0x0055b44f63ed50>
    /home/yaginuma/program/rails/master_y_yagi/rails/activejob/lib/active_job/logging.rb:51:in `logger_tagged_by_active_job?'
```

This was happening for the formatter class of resque not the formatter class of
Rails is they've been used to logger.formatter.
This was happening because become fomatter is changed during the instantiation
of worker in the resque 1.26.
In the master, unless the environment variable is set, fomatter is so as not to
be changed, test will pass.

Ref: https://github.com/resque/resque/pull/1439
2016-07-05 10:02:41 +09:00
Rafael Mendonça França 14dc9b9cd9
Use sass-rails in our test suite 2016-06-30 19:39:37 -03:00
Rafael Mendonça França 3bf0fe4a9c
Do not allow rack pre releases 2016-06-30 15:12:08 -03:00
Rafael Mendonça França 19ba6b8d4e
Merge pull request #25607 from sstephenson/turbolinks-5-final
Update to Turbolinks 5.0.0 final
2016-06-30 14:39:36 -03:00
Rafael Mendonça França e4c8aae643
Point to released coffee-rails 2016-06-30 14:35:25 -03:00
Sam Stephenson 10ba790124 Update to Turbolinks 5.0.0 final 2016-06-30 12:22:16 -05:00