mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
62,558 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

4969 Commits

Author SHA1 Message Date
utilum 2dc74387b7 Fixes #27202, [ci skip] 2016-11-30 21:22:30 +01:00
Rory O’Kane 4c0c7cba2b Fix typo in Rails 5.0 release notes – “when when” 
[ci skip]
 2016-11-29 16:46:10 -05:00
JessRudder a92e115e19 Add note about step needed to get tests to pass if you implemented basic auth [ci skip] 2016-11-28 19:28:40 -05:00
jnoortheen fa497ebb0d fix: solves issue#27189 2016-11-27 22:59:59 +05:30
Prathamesh Sonpatki 312b345b45
Followup of UUID default extension in the docs [ci skip] 
- Mentioned clearly that for PostgreSQL < 9.4, you need to pass the
  default option with "uuid_generate_v4()"
- Also updated PostgreSQL Active Record guide with this change.
- https://github.com/rails/rails/pull/25395#r66877078
 2016-11-24 17:33:16 +05:30
Kirill Zhuravlov 30433253ed Add link to API documentation 
Add a link to http://api.rubyonrails.org/classes/ActionController.html in the beginning of an article.
 2016-11-23 03:04:55 +02:00
Matthew Draper b89ddd421f Merge pull request #27143 from sachin21/fix-permission 
Fix a wrong permission
 2016-11-22 21:51:56 +10:30
Satoshi Ohmori d34f328929 Fix a wrong permission 2016-11-22 19:41:13 +09:00
Jon Moss 4c3afea7df Change html-scanner to rails-html-sanitizer 
[ci skip]
 2016-11-19 20:31:25 -05:00
Prathamesh Sonpatki 04bb2d0dfa
Remove mention of SafeErb gem [ci skip] 
Followup of https://github.com/rails/rails/pull/27086
 2016-11-19 17:15:19 +05:30
Tom Prats dd66493d70 Updated Sprockets Documentation 2016-11-17 18:18:14 -05:00
Vipul A M 8d015dff82 Remove mention of deprecated SafeERB gem from security docs for now, prior section already speaks about sanitization as a safety measure. [ci skip] (#27086) 
Fixes #27085
 2016-11-18 00:11:48 +05:30
yuuji.yaginuma eda23fa62f remove `alias_method_chain` from guide [ci skip] 
Follow up to 7c848e6dd4
 2016-11-15 08:42:02 +09:00
Conrad Beach b8341b3a2a Fix small typo in Layouts and Rendering guide. [ci skip] 
Changed "same way they do" to "same way they are".
 2016-11-14 14:07:21 -07:00
Andrew White 0ef5b6c163 Merge pull request #26905 from bogdanvlviv/docs 
Add missing `+` around a some literals.
 2016-11-13 14:09:30 +00:00
Xavier Noria e86524c0c5 adds support for arbitrary hashes in strong parameters 2016-11-11 23:31:50 +01:00
bogdanvlviv 25eed41c49 Update guides/source/active_record_querying.md 
Add info about updating locking column value

Follow #26050 and #26871

[ci skip]
 2016-11-10 20:42:23 +02:00
Kasper Timm Hansen bab665f893 [ci skip] Expand context on `:cache_hits`. 
Need to explain the key is only there in certain cases.
 2016-11-08 18:52:31 +01:00
yui-knk 4582d5766a [ci skip] Add `render_collection.action_view` entry to AS instrumentation 2016-11-08 20:03:22 +09:00
Kasper Timm Hansen e91dd52d56 Merge pull request #26982 from bogdanvlviv/started_guide 
Fix 'Getting Started with Rails' [ci skip]
 2016-11-07 07:36:03 +01:00
bogdanvlviv 2339466542 Add missing spaces [ci skip] 2016-11-07 01:43:59 +02:00
bogdanvlviv 88aeadb5b3 Fix 'Getting Started with Rails' [ci skip] 
`bin/rails generate controller Comments` creates files
  app/assets/javascripts/comments.coffee
  app/assets/stylesheets/comments.scss
  not
  app/assets/javascripts/comment.coffee
  app/assets/stylesheets/comment.scss
 2016-11-06 23:02:23 +02:00
Daniel Amireh b49e601e3a Use local variable instead of instance variable [ci skip] 
Update render yield docs to use `search` local variable instead of `@q` instance variable
 2016-11-05 14:19:28 +01:00
colleenmcguckin 700623936e
fix typo in Rails Test Runner section 2016-10-31 12:18:20 -07:00
Shia e7bb3cd4ae Remove `Rack::Runtime from console log [ci skip] 2016-10-31 17:53:52 +09:00
Benny 32d0d971eb Add missing space in Migrations guide [ci skip] 2016-10-31 11:32:29 +08:00
Jon Moss 1f63d09ad7 Merge pull request #26932 from y-yagi/update_doc_about_assets_digest 
update doc about assets digest class [ci skip]
 2016-10-29 21:05:57 -04:00
yuuji.yaginuma 8ee7d5e1fc update doc about assets digest class [ci skip] 
The default digest class changed to SHA256 in sprockets 3.0.
Ref: https://github.com/sstephenson/sprockets/pull/647
 2016-10-30 09:34:27 +09:00
Rafael Mendonça França fe1f4b2ad5
Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
Erol Fornoles f7d54c4247
Add documentation for `config.assets.version` [skip ci] 2016-10-28 18:13:30 +08:00
yuuji.yaginuma 3db6ca9d04 fix initializer name [ci skip] 
This changed in c046660
 2016-10-27 08:04:24 +09:00
bogdanvlviv 5faa9a235c Add missing `+` around a some literals. 
Mainly around `nil`

[ci skip]
 2016-10-27 00:27:47 +03:00
James Doyley ae83b01b19 Update HABTM documentation in guides 2016-10-26 09:22:23 +01:00
Rafael França c05a209fe9 Merge pull request #26851 from Gaurav2728/update-kindlerb 
update kindlerb gem
 2016-10-25 14:19:12 -02:00
Rafael Mendonça França 8b3ed2b68a
Fix HTML escaping in the guides 
render :html escapes the argument if not provided as html safe.
 2016-10-25 11:19:28 -02:00
Rafael Mendonça França 0b4679f192
Fix indentation 2016-10-25 03:16:51 -02:00
Rafael Mendonça França 1e7f6488f7
Generate HTML not plain text 2016-10-25 03:06:57 -02:00
Rafael Mendonça França d34a2747cb
Fix plain option in the rails_guides generator 2016-10-25 00:08:39 -02:00
Erol Fornoles 094638e544
Fix typo in Upgrading Ruby on Rails Guide [ci skip] 2016-10-24 22:28:40 +08:00
yuuji.yaginuma 0f87413f41 update description of Etag [ci skip] 
The document is written with "only generate weak", but it can also be used to
strong etag.
Also, add missing entory for #24387
 2016-10-24 20:17:31 +09:00
Carlos Antonio da Silva a0d0648efb Merge release note entry for Date/Time/DateTime extensions 
The first release note entry mentioned #on_weekday?, but that was only
added by the second PR mentioned there. To simplify reading the notes
just merge the two, since they are related methods. [ci skip]
 2016-10-23 16:51:51 -02:00
Gaurav Sharma f0bacbc2c4 update kindlerb gem 
Ruby Kindle periodical-format ebook generator
 2016-10-21 09:37:24 +05:30
Yves Senn dba9ce8ec8 guides, include note about modifiers when using the CLI. 
[ci skip]

This was pointed out on
https://github.com/rails/rails/issues/15583#issuecomment-239212831

The comment was lost in the changes made by
fcd0ac066e and
3e1373a773
 2016-10-20 20:34:46 +02:00
Yves Senn fb2f8d2b75 remove trailing whitespace [ci skip] 2016-10-20 20:32:24 +02:00
Bruno Facca 85dd85fe01 [ci skip] Fix return values of Hash Extensions examples 
The hashes returned in some examples of the following sections had items in a different order than their receivers. That may mislead readers into believing those methods will not preserve element order.

Extensions to Hash/Working with Keys/transform_keys and transform_keys!
Extensions to Hash/Working with Keys/stringify_keys and stringify_keys!
Extensions to Hash/Working with Keys/symbolize_keys and symbolize_keys!
Extensions to Hash/Slicing
 2016-10-20 15:38:49 -02:00
Alex Kitchens f6cc4f5648 [ci skip] Fix typo in Guides: Contributing 2016-10-17 16:31:01 -05:00
rmarone be6990bf01 Pull request for ticket 26769 (#26770) 
* Clarify the default behavior of log_formatter

Updates language to remove reference to production.rb and fix quoting
 2016-10-15 09:20:41 -04:00
Godfrey Chan f2f9b88685 Introduce a benchmark template [ci skip] 
This replaces boilerplate in the “benchmark your code” section of the
contributors’ guide with an executable template. I also amended the text
to encourage best practices and codified it in the template.

For now this is only good for relatively self-contained changes that can
be inlined into a simple script. In the future, this can be expanded to
cover how to measure the difference between two commits.

The output looks like this:

```
==================================== Empty =====================================

Warming up --------------------------------------
              blank?   225.963k i/100ms
         fast_blank?   238.147k i/100ms
Calculating -------------------------------------
              blank?      8.825M (± 6.4%) i/s -     44.063M in   5.014824s
         fast_blank?      9.311M (± 6.3%) i/s -     46.439M in   5.009153s

Comparison:
         fast_blank?:  9310694.8 i/s
              blank?:  8824801.7 i/s - same-ish: difference falls within error


================================= Single Space =================================

Warming up --------------------------------------
              blank?    56.581k i/100ms
         fast_blank?   232.774k i/100ms
Calculating -------------------------------------
              blank?    813.985k (±16.7%) i/s -      4.017M in   5.076576s
         fast_blank?      9.547M (± 5.2%) i/s -     47.719M in   5.013204s

Comparison:
         fast_blank?:  9547414.0 i/s
              blank?:   813985.0 i/s - 11.73x  slower


================================== Two Spaces ==================================

Warming up --------------------------------------
              blank?    58.265k i/100ms
         fast_blank?   244.056k i/100ms
Calculating -------------------------------------
              blank?    823.343k (±16.2%) i/s -      4.020M in   5.014213s
         fast_blank?      9.484M (± 4.9%) i/s -     47.347M in   5.005339s

Comparison:
         fast_blank?:  9484021.6 i/s
              blank?:   823343.1 i/s - 11.52x  slower


=============================== Mixed Whitspaces ===============================

Warming up --------------------------------------
              blank?    53.919k i/100ms
         fast_blank?   237.103k i/100ms
Calculating -------------------------------------
              blank?    763.435k (±16.8%) i/s -      3.720M in   5.018029s
         fast_blank?      9.672M (± 5.8%) i/s -     48.369M in   5.019356s

Comparison:
         fast_blank?:  9672467.2 i/s
              blank?:   763435.4 i/s - 12.67x  slower


=============================== Very Long String ===============================

Warming up --------------------------------------
              blank?    34.037k i/100ms
         fast_blank?   240.366k i/100ms
Calculating -------------------------------------
              blank?    409.731k (± 8.9%) i/s -      2.042M in   5.028235s
         fast_blank?      9.794M (± 4.3%) i/s -     49.035M in   5.016328s

Comparison:
         fast_blank?:  9794225.2 i/s
              blank?:   409731.4 i/s - 23.90x  slower
```
 2016-10-15 12:34:46 +02:00
Javier Cuevas 854a1be5fa Suggested edits 2016-10-13 18:02:52 +02:00
Javier Cuevas 3de12286e6 Improve Action Cable Overview guide 
The default adapter in development & test environments is not `redis` but `async`.
 2016-10-13 17:49:26 +02:00
Rafael Mendonça França b3d41eae4b
Deprecated ActionDispatch::ParamsParser::ParamsParser 
ActionDispatch::ParamsParser class was removed in favor of
ActionDispatch::Http::Parameters so it is better to move the error
constant to the new class.
 2016-10-10 01:35:58 -03:00
kenta-s a0f871f95a Change page:change to turbolinks:load in README.md [ci skip] 2016-10-05 19:41:27 +09:00
Esteban Santana Santana ddddedc487 Allow the use of listen's 3.1.x branch. 
When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.
 2016-10-03 16:58:17 +05:30
yuuji.yaginuma f597822f4a add `cached` key to `sql.active_record` event [ci skip] 
Follow up to #26584
 2016-10-02 13:29:17 +09:00
Jeremy Wilmot 7d0e73bc01 Remove dup distinct from AR query list [ci skip] 2016-09-30 15:12:16 -07:00
Yusuke Nakamura 86c0dccac1 Fix typo in 5_0_release_notes.md doc [ci skip] 2016-09-29 21:56:56 +09:00
Jon Moss 29f883640c Merge pull request #26648 from y-yagi/update_description_of_queue_adapter 
update description of queue adapter in test [ci skip]
 2016-09-28 17:04:21 -04:00
Michael Lennox ba415c4f8a Removes broken performance testing link from the 2.2 release notes 2016-09-28 14:11:26 +01:00
yuuji.yaginuma 9a918800c0 update description of queue adapter in test [ci skip] 
`ActiveJob::TestCase` set `TestAdapter` to queue adapter at `before_setup`.
https://github.com/rails/rails/blob/master/activejob/lib/active_job/test_helper.rb#L12..L21
 2016-09-28 18:59:17 +09:00
Jon Moss c427033e7a Add info about a502703 to Rails 5 release notes 
[ci skip]
 2016-09-25 14:58:41 -04:00
Michael Hoy b8c74e77f2 Fix docs for allowed params to `get` in controller tests [ci skip] 
Fixes #26602

Relevant method documentation:

abe3da9f12/actionpack/lib/action_dispatch/testing/integration.rb (L14-L43)
 2016-09-23 13:43:02 -05:00
Vijay Dev 67313650eb Merge branch 'master' of github.com:rails/docrails 2016-09-20 16:27:19 +00:00
Andrey Molchanov e1252e073a [ci skip] Fixed commas according to Oxford comma in rdoc and guides 2016-09-17 22:36:13 +03:00
Jon Moss cd6605438d Fix small grammar issue introduced in #26382 
[ci skip]
 2016-09-16 19:22:07 -04:00
Girish Sonawane 084211a7da bug report template for migrations (#26488) 
* added bug report template for migrations
 2016-09-15 07:28:12 -04:00
Girish S b4a4860f1e fixed guide to add correct documentation for partial render 'as' option 2016-09-13 12:51:33 +05:30
Kasper Timm Hansen 2b5ed618ed [ci skip] Update Levenshtein code with better attribution. 
Lacks some proper creds to the homies who went the... distance ;)
 2016-09-12 21:46:44 +02:00
प्रथमेश Sonpatki 087427e0d1 Merge pull request #26431 from wytesk133/master 
Fix table name typos [ci skip]
 2016-09-08 16:44:14 +05:30
Waitaya Krongapiradee 831f1b67b7 Fix table name typos [ci skip] 2016-09-08 16:41:16 +07:00
yuuji.yaginuma 5d33209335 update doc about default `cache_store` [ci skip] 
The default `cache_store` has changed in 8f0e0b6 to use `file_store`.
 2016-09-08 07:22:50 +09:00
Prathamesh Sonpatki 2352fcc162
💅 [ci skip] 2016-09-07 07:33:26 +05:30
Vipul A M 06658f1d9d Merge pull request #26390 from Neodelf/format_mds 
[ci skip] Simply formatting documents
 2016-09-07 00:57:19 +05:30
Neodelf e0e7047233 [ci skip] Simply formatting documents 2016-09-06 22:23:49 +03:00
Vipul A M b4dac34508
Document that redirect* don't halt exucution. We explain more on this behavior in 2.3.2, but dont specify that is not halting. Its better to not let developers be caught by surprise. [ci skip] 2016-09-06 23:45:34 +05:30
Vijay Dev 0fdf522611 Merge pull request #24612 from vipulnsward/fix-li-ol-width 
Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl as needed
 2016-09-06 22:49:10 +05:30
Ryunosuke Sato b9e98d62c2 Remove the word "mongrel" from documents 
Currently mongrel is not maintained.
And it couldn't be built with any Ruby versions that
supported by Rails.

It is reasonable to remove the word "mongrel" in order to avoid
confusion from newcomer.
 2016-09-07 01:59:37 +09:00
Mark Sun 28426f5349 Minor grammar fix in engines.md 2016-09-06 11:00:09 -04:00
Nathan Wenneker 37219bbb5a Update docs for change in transaction callback exceptions 
07d3d40 changed how exceptions are handled in after_commit
and after_destroy callbacks.  This commit updates the 5.0
release notes and the  ActiveRecord callback guide to reflect
the new behavior.

[ci skip]
 2016-09-03 13:48:07 -06:00
yuuji.yaginuma 29cab68c5f add Active Job bug report templates to guide [ci skip] 
Follow up to #26362
 2016-09-03 07:12:20 +09:00
Kasper Timm Hansen 55c5dffd9f Merge pull request #26364 from y-yagi/fix_class_name_typo_in_bug_report_templates 
fix class name typo in bug report templates for Active Job
 2016-09-02 11:31:12 +02:00
Shia 24d00d229e Improve Getting Started [ci skip] 2016-09-02 17:16:45 +09:00
yuuji.yaginuma 9eba3d6976 fix class name typo 2016-09-02 17:16:15 +09:00
Guillermo Iguaran 8697ce4dba Merge pull request #26362 from prathamesh-sonpatki/add-aj-bug-report-templates 
Added bug report templates for Active Job
 2016-09-02 01:05:15 -05:00
Prathamesh Sonpatki 26a2776f23
Added bug report templates for Active Job 2016-09-02 11:31:04 +05:30
Waitaya Krongapiradee e88a745ca3 Grammar fix [ci skip] 2016-09-02 12:00:16 +07:00
Xavier Noria 810dff7c9f RuboCop is 100% green 🎉 2016-09-02 00:43:33 +02:00
Devinsuit 6e414b87a2 Update Jason Zimdars twitter 2016-08-31 22:09:22 +03:00
Richard Schneeman 4ba40bc2d6 Merge pull request #26226 from schneems/schneems/explicit-public-urls 
Make public asset use explicit
 2016-08-31 10:28:31 -05:00
Jon Moss b7ec47aa8f Merge pull request #26331 from kjellberg/broken-links 
[ci skip] Broken links in documentation fix
 2016-08-30 14:10:06 -04:00
Rasmus Kjellberg e49444797e [ci skip] Broken links in documentation fix 2016-08-30 20:02:46 +02:00
Shia 61522dc126 Update typo & Make explanation more clear 2016-08-31 01:12:49 +09:00
schneems e1791d1dd4 Explicitly mention defaults. 2016-08-29 13:16:07 -05:00
schneems 8bcf42c4b3 Address doc style comments from @robin850 2016-08-29 13:16:07 -05:00
schneems 581d9685ea Fix asset_pipeline.md miss-merge 2016-08-29 13:16:07 -05:00
schneems b6b4d6980b Specify version of Sprockets-rails this will be in 2016-08-29 13:16:07 -05:00
schneems 58bd1124cf Move default to different initializer 
Is this usage correct? cc/ @prathamesh-sonpatki
 2016-08-29 13:16:07 -05:00
schneems e1bd2f59dd [ci skip] configuring.md assets.unknown_asset_fallback 2016-08-29 13:16:07 -05:00
schneems 8126c7c2f7 [ci skip] asset_pipeline.md assets.unknown_asset_fallback 2016-08-29 13:16:07 -05:00
schneems 3105642a5c [ci skip] Upgrading assets.unknown_asset_fallback 2016-08-29 13:16:07 -05:00
Alex Kitchens a84b50374e [ci skip] Update branch version in Contributing Guide 
Since only Rails 4 and above are currently supported, this updates a
3-2-stable example to be consistent with the support standard.
 2016-08-29 11:00:43 -05:00
Rasmus Kjellberg 7425aaaec3 Added gitignore to "files & purpose" list [ci skip] 2016-08-29 02:53:55 +02:00
Guillermo Iguaran f394f3ba76 Merge pull request #26288 from maclover7/jm-revert-21995 
Update `Rails.configuration` documentation
 2016-08-26 09:30:34 -05:00
Jon Moss 2f5a40a800 Clarify two ways to set Rails configuration options 
[ci skip]
 2016-08-26 10:24:38 -04:00
Jon Moss 01dca5b4b3 Add back in `config_for` example 
[ci skip]
 2016-08-26 10:20:18 -04:00
Jon Moss 5fb513f26a Revert "Merge pull request #21995 from tak1n/master" 
This reverts commit 4973704bf5, reversing
changes made to 78edeb3334.
 2016-08-26 10:15:01 -04:00
Santosh Wadghule ba84258819 Move `assert_nothing_raised` method to Rails Specific Assertions 
section [ci skip]

- Method `assert_nothing_raised` is Rails' own custom assertion method and
not a part of Minitest. So move it from Minitest assertions section to Rails
Specific Assertions section.
 2016-08-26 19:05:24 +05:30
Shia 53a8663bb5 Rename the title of comand_line.md in index 
Remove 'rake tasks' from index
 2016-08-24 11:27:00 +09:00
Shia e473b8251c update `is renamed` to `tasks are renamed` 2016-08-23 22:03:44 +09:00
Shia a2aed31564 Remove Duplicated information & fix typo... 
- Remove Duplicated explanation.
- Fix some typo.
- Attach PR, commit link that missed one.
 2016-08-23 21:49:35 +09:00
Rafael França 3bfd352452 Merge pull request #26249 from rafamanzo/add_redis_to_development_dependencies 
Update docs with Action Cable Redis dependency
 2016-08-22 16:51:38 -03:00
Rafael Mendonça França df84e98672
Remove the SchemaDumper options and change the default behavior 
Now the schema dumper by default doesn't align the types and arguments
in the ruby format anymore.
 2016-08-22 15:46:04 -03:00
Rafael Reggiani Manzo 65b5960759 [ci skip] Update docs with Action Cable Redis dependency 
Action Cable's test `test/subscription_adapter/redis_test.rb` fail if
Redis is not installed and running.

Following the guides `development_dependen there's no mention to this.
 2016-08-22 14:44:46 -03:00
Will Jordan 8c1fdf679e Remove `:action` and `:controller` segments from routing guide 
Fixes #26247.
[ci skip]
 2016-08-22 17:19:28 +00:00
Eileen M. Uchitelle 9caca55f71 Merge pull request #25750 from go2null/go2null-test-directories 
Specified directories for routes, views and jobs tests
 2016-08-22 13:13:20 -04:00
go2null 90fbae6acc Clearly state purpose of test directories 
* Added location for route, view and job tests to section 2.1.  (They are currently only defined in sections 8 Testing Views and 11 Testing Jobs.)
* Added location for route test in section 7 Testing Routes.  (Currently only defined in section 8 Testing Views.)
 2016-08-22 11:27:22 -04:00
Danila Ermakov 3b7642a328 Change form of table name to plural in query example 2016-08-22 15:24:19 +03:00
Jon Moss 409dbc891d Merge pull request #26241 from scottyantipa/query-interface-docs 
Upate guides to properly define return values of finder methods
 2016-08-21 22:01:28 -04:00
Kasper Timm Hansen 0432652f23 Merge pull request #26234 from y-yagi/remove_unnessary_session_store_setting 
remove  unnessary `session_store` setting
 2016-08-21 21:04:19 +02:00
Scott Antipa f3626c38fc Update docs for query interface to not declare that all methods return instance of ActiveRecord::Relation 2016-08-21 11:17:37 -07:00
Vijay Dev 3e2be0bf14 Merge branch 'master' of github.com:rails/docrails 2016-08-21 10:48:53 +00:00
Vijay Dev fae7c46285 Merge pull request #26227 from alexcameron89/syntax_highlighter_fix 
Increase margin-bottom for doc's code syntax highlighter
 2016-08-20 23:01:43 +05:30
Alex Kitchens 5624d1158e Increase margin-bottom for doc's code syntax highlighter 
Fixes #25744 by slightly increasing the margin in code syntax
highlights. With a margin of 0, it was cutting off underscores in Linux
browesers, so I slightly increased it to 0.5px.
 2016-08-20 11:56:03 -05:00
yuuji.yaginuma 3173244d4b remove unnessary `session_store` setting 
Since e5a6f7ee9e, by default the session store
will be set to cookie store with application name as session key.
 2016-08-20 20:24:17 +09:00
Eileen M. Uchitelle 01a8e0c24e Merge pull request #26224 from jonatack/consistent-asset-precompile-examples 
Consistent examples and template for assets#precompile
 2016-08-19 16:52:16 -04:00
Jon Atack b4c92be471 Consistent examples and template for assets#precompile 
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.

This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.

Re-add spaces inside array parentheses.
 2016-08-19 22:24:54 +02:00
Vipul A M 18e599940a
When referring to Rails, be consistent in usage of capitalized form, unless it is used in context of a command like bin/rails or the rails directory [ci skip] 2016-08-19 14:17:07 +05:30
Vipul A M 5b5437caeb
Grammar changes on getting started guide, specify where exactly the example is that we are referring to. [ci skip] 2016-08-19 14:14:32 +05:30
Rafael Mendonça França e87158f16b
Merge pull request #25675 from TimPetricola/schema-no-standardized-column-widths 
Option not to line up column attributes in schema.rb
 2016-08-19 01:28:39 -03:00
Phil Nash a0c4bcf651 [ci skip] Updates ActiveJob guide on default runner. 
The immediate runner is no longer default, the async adapter is.
 2016-08-18 23:00:07 +01:00
Tim Petricola 84cc8fd5d8 Merge branch 'master' into schema-no-standardized-column-widths 2016-08-18 15:02:39 +02:00
Ian C. Anderson fbaa5e390f i18n documentation for required belongs_to message 
When you don't explicitly provide `optional: true` to a `belongs_to`
definition, rails adds a validation to ensure presence of the
`belongs_to` validation.

However, when the validation is added, it is added with a message key of
`:required`, which was not documented in the "Translations for Active
Record Models" section of the i18n guides.

Here are the lines that add the `:required` message:
c3e3577f9d/activerecord/lib/active_record/associations/builder/belongs_to.rb (L136-L138)

This commit adds the "non-optional association" validation to the table,
so rails users know how to override the message for this validation. The
default message is "must exist".
 2016-08-17 18:19:59 -04:00
Jonathan ce17ac2773 Fix #26187 
As "discussed" in #26187 I added the route that magically disappeared again.
 2016-08-17 15:28:54 +02:00
Jonathan 9233f52bd9 Fix diffrent naming in getting_started.md 
I've noticed that once `<h1>Editing article</h1>` L1157 was the title and then later on it's `<h1>Edit article</h1>` L1358 which kind of makes more sense...

[ci skip]
 2016-08-17 12:49:56 +02:00
Tim Petricola dde3bdf214 Option not to line up column types and attributes in schema.rb 2016-08-17 10:09:34 +02:00
Yohei YASUKAWA d4aec26030
Fix link in Rails 5.0 Release Note [ci skip] 2016-08-17 12:43:52 +09:00
Rafael França 82ec6b3606 Merge pull request #26061 from malclocke/specify_ar_message_interpolation_names_in_i18n_guide 
List names of error interpolation variables.
 2016-08-16 07:03:16 -03:00
Rafael França 05a35b5b63 Merge pull request #26175 from stomar/upgrade-guide-fix 
Clarify migration to ApplicationRecord in upgrade guides [ci skip]
 2016-08-16 06:56:22 -03:00
Rafael Mendonça França 55f9b8129a
Add three new rubocop rules 
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces

Fix all violations in the repository.
 2016-08-16 04:30:11 -03:00
Marcus Stollsteimer b3ad505cac Clarify use of update task on 4.2 and earlier [ci skip] 2016-08-15 21:53:27 +02:00
Marcus Stollsteimer 9f8de63783 Clarify migration to ApplicationRecord in upgrade guides [ci skip] 2016-08-15 21:15:56 +02:00
chuckdishmon 9826b24242 fix usage of pluralized word 2016-08-14 21:36:46 -04:00
Eugene Kenny 115e31440c Update increment! documentation [ci skip] 
The `increment!` and `decrement!` methods were recently reimplemented to
make them safe to call from multiple connections concurrently. This
changed their behaviour in a few ways.

Previously they used `update_attribute`, which calls the attribute
setter method, runs callbacks, and touches the record. Now they behave
more like `update_column`, writing the update to the database directly
and bypassing all of those steps.
 2016-08-15 01:14:08 +01:00
Xavier Noria 5c2c6966a0 Revert "Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]" 
Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322

This reverts commit 39effc857e.
 2016-08-15 01:03:54 +02:00
Jon Moss 916d9d70a0 Merge pull request #26163 from olivierlacan/clarify-autoloading-disabled 
Clarify and fix typos in autoloading disabled section
 2016-08-14 14:56:09 -04:00
Olivier Lacan 39effc857e Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip] 
The Guides section about autoloading being disabled was slightly confusing
(#24724) and didn't directly reference the removed feature by name
(config.autoload_paths) making it much harder for someone to search the upgrade
guides for a mention or serendipitously find it via a Google search when running
into autoloading issues.

I also fixed some confusing turns of phrase and a missing word.

/cc @vipulnsward @jvanbaarsen
 2016-08-14 14:08:16 -04:00
Prathamesh Sonpatki c6a4561901
Fix the documentation for configuring `enable_fragment_cache_logging` [ci skip] 
- It is Action Controller config, not Action View.
 2016-08-14 18:15:46 +08:00
Prathamesh Sonpatki 484b3ca402
Fix remaining broadcasting_name example from Action Cable guide [ci skip] 
- Followup of https://github.com/rails/rails/pull/26125.
 2016-08-12 12:19:34 +08:00
Eric Zhang 3f9d380963 [ci skip] Fix documentation wrong for ActionCable 2016-08-12 00:29:20 +08:00
Eric Zhang dfd7c2f058 [ci skip] Fix documentation for ActionCable::Channel#broadcast_to 2016-08-12 00:27:39 +08:00
Guillermo Iguaran 5cb6b887d4 Merge pull request #26110 from aditya-kapoor/minor-doc-fix 
Minor doc fix related to ActiveModel::SecurePassword [ci skip]
 2016-08-10 20:44:30 -05:00
Aditya Kapoor d61aec316a Minor doc fix related to ActiveModel::SecurePassword [ci skip] 2016-08-11 01:55:45 +05:30
Santosh Wadghule 80f777e1c0 Add documentation for `http_cache_forever`. [ci skip] 2016-08-10 20:27:29 +05:30
Ryuta Kamizono f006de5dc5 Fix broken alignments caused by auto-correct commit 411ccbd 
Hash syntax auto-correcting breaks alignments. 411ccbdab2
 2016-08-10 06:36:39 +09:00
Vipul A M 67d0c9ee93 Merge pull request #24476 from vipulnsward/24314-eagerloading-doc-update 
Document know limitation about using `references` in conjunction with custom select clauses [ci skip]
 2016-08-09 14:19:48 +05:30
Vipul A M 0ee88bf1e7
Document know limitation about using `references` in conjunction with eager loading causing it to ignore custom select clauses. 
[ci skip]

Fixes #24314
 2016-08-09 14:14:53 +05:30
Vipul A M c5fb8b18fe Merge pull request #26042 from bogdanvlviv/debugging_guide 
Add link to 'Pry' in debugging guide [ci skip]
 2016-08-09 13:52:47 +05:30
yuuji.yaginuma 73f33266d8 update list of rescue_responses default [ci skip] 
Follow up to fe859a5421
 2016-08-09 08:15:18 +09:00
bogdanvlviv a170304174 Add link to 'Pry' in debugging guide [ci skip] 2016-08-07 21:47:27 +03:00
Stan Lo ab2af4dfcb Modify LogSubscriber for single partial's cache message. 
Implement naive partial caching mechanism.

Add test for LogSubscriber

Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it.

Fixed tests

Remove useless settings

Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute

Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload.

Update test's hash syntax

Add configuration to enable/disable fragment caching logging

Remove unless test and add new test to ensure cache info won't effect next rendering's log

Move :enable_fragment_cache_logging config from ActionView to ActionPack

Apply new config to tests

Update actionview's changelog

Update configuration guide

Improve actionview's changelog

Refactor PartialRenderer#render and log tests

Mute subscriber's log instead of disabling instrumentation.

Fix typo, remove useless comment and use new hash syntax

Improve actionpack's log_subscriber test

Fix rebase mistake

Apply new config to all caching intstrument actions
 2016-08-08 00:24:39 +08:00
Xavier Noria b326e82dc0 applies remaining conventions across the project 2016-08-06 20:20:22 +02:00
Xavier Noria 80e66cc4d9 normalizes indentation and whitespace across the project 2016-08-06 20:16:27 +02:00
Xavier Noria 411ccbdab2 remove redundant curlies from hash arguments 2016-08-06 19:44:11 +02:00
Xavier Noria 1607ee299d modernizes hash syntax in guides 2016-08-06 19:39:28 +02:00
Xavier Noria 6b3719b757 applies new string literal convention in guides 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:21:59 +02:00
Eileen M. Uchitelle 78a877408b Merge pull request #26023 from tekin/correct-acceptance-guidelines 
Correct usage for acceptance validator in guide
 2016-08-06 10:19:33 -04:00
claudiob 2ea3342c56 [ci skip] Fix broken URL in guides 2016-08-05 17:00:37 -07:00
Andrew White 70f2f98150 Add note about limitations of Windows Subsystem for Linux 
Due to the limited support for inotify (Microsoft/BashOnWindows#216) in
WSL the best thing to do at moment is add a note about skipping spring
and listen when generating your application in the Getting Started guide.

[skip ci]

Fixes #26054.
 2016-08-05 19:23:39 +01:00
Malcolm Locke 97b5341d6a List names of error interpolation variables. 2016-08-05 11:39:47 +12:00
Rafael Mendonça França fdc52ddb76
Add 4.2.Z back to the maintenance list 
Some Rails core members agreed to continue to maintain 4.2 until 5.1 is
released.

[ci skip]
 2016-08-02 17:07:01 -03:00
Vijay Dev 4d288f0b43 Merge branch 'master' of github.com:rails/docrails 2016-08-02 17:38:56 +00:00
Tekin Suleyman b605a6ac9e Correct usage for acceptance validator in guide 2016-08-02 11:24:09 +01:00
yuuji.yaginuma 987df0fea0 remove old links from debugging guide [ci skip] 2016-08-01 16:38:55 +09:00
Rafael França 4211a29902 Merge pull request #25948 from chetna1726/docs 
[ci skip] Add documentation for error using select with order
 2016-07-28 01:16:41 -03:00
Bonghyun Kim 8243434d9c Updated getting_started guide to reflect the change in error message for ActionController::UnknownFromat in ArticlesController#new 
Restored texts about XML and JS template handlers. [ci skip]
 2016-07-28 02:30:49 +09:00
Chetna Sharma a9dabd6939 [ci skip] Add documentation for error using select with order 2016-07-25 18:40:31 +05:30
प्रथमेश Sonpatki 56527bb737 Merge pull request #25928 from mechanicles/info-for-cache-fetch-block 
Add proper description for `Rails.cache.fetch` [ci skip]
 2016-07-24 10:13:41 +05:30
Santosh Wadghule d4f1b8090a Proper description for `Rails.cache.fetch` [ci skip] 2016-07-24 09:37:44 +05:30
Kasper Timm Hansen 1ca571cc47 Merge pull request #25908 from mechanicles/derives-from 
Explain meaning of the code very well and Remove confusion. [ci skip]
 2016-07-23 07:48:17 +02:00
Santosh Wadghule 8ad6260538 Explain meaning of the code very well and Remove confusion. [ci skip] 
Code like `render(topics) => render("topics/topic")` adds confusion
for the readers. On first impression, that code feels like hash kind
of data, but it's not. So make it more clear and meaningful.
 2016-07-23 09:56:35 +05:30
Xavier Noria 575dbeeefc define Range#match? if Ruby < 2.4 
See the rationale in the documentation included in this patch.

We are going to gradually introduce this predicate in the code base.
 2016-07-22 00:15:52 +02:00
Iain Beeston a11abf19ee Removed reference to callback_terminator.rb in docs 
That file has been removed and replaced with new_framework_defaults.rb
 2016-07-21 13:00:17 +01:00
Rafael Mendonça França a8a3a8cc69
Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializer 
Setup default session store internally, no longer through an initializer
 2016-07-20 02:32:37 -03:00
Matthew Draper d8bc0964d2 Merge pull request #25780 from Ropeney/patch-1 
Update ActionCable Rebroadcasting a Message documentation
 2016-07-19 16:47:08 +09:30
Prathamesh Sonpatki a3c27be98b
Fix documentation of `error_on_ignored_order` option 
- Followup of 451437c6f5
 2016-07-18 09:30:16 +05:30
Prathamesh Sonpatki e5a6f7ee9e
Setup default session store internally, no longer through an application initializer 
- By default the session store will be set to cookie store with
  application name as session key.
- Older apps are not affected as they will have the session store
  initializer generated by Rails in older versions, and Rails will not
  overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
  will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
 2016-07-17 19:45:51 +05:30
Josh Justice 65132b9087 Update references generation docs to exclude index 
In #23179 the migration generator was changed to no longer output `index: true` for `references` migrations. This updates the migrations guide to remove `index: true` from relevant examples.

[ci skip]
 2016-07-16 05:23:17 -04:00
yuuji.yaginuma 777ae60ddf add missing braces [ci skip] 
Also modify to use Ruby 1.9+ syntax.
 2016-07-16 10:56:28 +09:00
Kazuhiro NISHIYAMA bd6d2ec604 Fix broken link 2016-07-15 21:31:33 +09:00
rbr 2f6832e2a2 Fix display of unsorted list in release notes of 5.0 [ci skip] 2016-07-14 16:56:13 +02:00
Xavier Noria df6684458b fixes a link in the release notes of 5.0 [ci skip] 2016-07-14 12:17:21 +02:00
Xavier Noria 07d3b588df finders guide: updates the section about batch processing [ci skip] 
There are several edits here, but in particular it updates the
guide to reflect 451437c.
 2016-07-14 09:40:31 +02:00
Vipul A M e1915e712d Merge pull request #25748 from CodingItWrong/generator-field-types-link 
Correct link for model generator field types
 2016-07-13 01:18:12 -07:00
Josh Justice 5ae7fc5e40 Correct link for model generator field types 
The most complete list of field types appears in the `SchemaStatements` docs rather than the `TableDefinition` docs.

The change to link to `SchemaStatements` means that the explanation for the `index` parameter is no longer available on the linked-to page. A brief explanation of the `index` parameter is added directly in the guide to make up for this.
 2016-07-13 04:15:04 -04:00
kei-s fe5c9fb76e [ci skip] Update redirecting links in guides 2016-07-12 20:12:24 +09:00
Santosh Wadghule d8575289a2 rails -> Rails [ci skip] 2016-07-12 12:21:36 +05:30
Joseph Mullins 931781b74f Update ActionCable Rebroadcasting a Message documentation 
Replace broadcast_to with ActionCable.server.broadcast to be inline with its partner, #stream_from
 2016-07-12 01:24:15 +09:30
Prathamesh Sonpatki bf06cdf773
The `to_query` method on Array objects uses `key[] as the prefix, not `_key_[]` [ci skip] 2016-07-10 21:46:20 +05:30
Prathamesh Sonpatki 3bc34f596b
Add `config.assets.quiet` to configuration guide [ci skip] 2016-07-10 21:17:10 +05:30
Prathamesh Sonpatki 816e15d626
Add note about `config.annotations.register_directories` option in the guides [ci skip] 
- Followup of #25692.
 2016-07-10 20:42:50 +05:30
Vijay Dev b76808602d Merge branch 'master' of github.com:rails/docrails 2016-07-10 10:58:39 +00:00
chen7897499 e3392642b8 Fix typo: caches_pages to caches_page. 
Fix a small typo on doc: "caches_pages" -> "caches_page".
 2016-07-07 14:34:31 +08:00
Gaurav Sharma ef4972a338 update doc for prefer require_relative over require + File.expand_path [ci skip] 2016-07-07 01:54:57 +05:30
willnet 9da3720ba9 [ci skip] Remove reference to Rails 4 in the initialization guide. 
Following commit removed reference to rails 4, but there is one left.

a9f50f87c3
 2016-07-06 22:57:24 +09:00
Santiago Pastorino 3a62dacd71 Merge pull request #25708 from maclover7/jm-master-bugreports 
Bump version for master bug report templates
 2016-07-06 08:57:34 -03:00
yuuji.yaginuma 2a45296114 remove `-t` option from default sendmail arguments [ci skip] 
Follow up to #24436
 2016-07-06 18:57:53 +09:00
Prathamesh Sonpatki 32426cec27
Fix documentation for number_with_precision helper in AV guide [ci skip] 
- It accepts `precision` option, not `number_with_precision`.
 2016-07-06 10:45:09 +05:30
Jon Moss d3165fc84d
Bump version for master bug report templates 2016-07-05 20:10:19 -04:00
Josh Justice 41c3ebaf38 Add header demarcation to Action Cable guide 
Guide generation is configured to detect a guide header by a 40-or-more-hyphen long line. The Action Cable guide was missing this line, so the page title on the guides site was only showing "Ruby on Rails Guides", and the section title in the Kindle index was "Ruby on Rails Guides". Adding the header demarcation line back in fixes both of these.

Fixes #25697

[ci skip]
 2016-07-05 08:13:18 -04:00
Xavier Noria 9bdf08c5a5 Merge pull request #25663 from vipulnsward/updated-syntax-highlighter 
Update Syntax Highlighter to version 4 [ci skip]
 2016-07-04 08:05:16 +02:00
Vipul A M 9a53b0f44a
- Update Syntax Highlighter to version 4. 
- Build Syntax Highlighter based on https://github.com/syntaxhighlighter/syntaxhighlighter/wiki/Building and use theme generated by fxn.
- This also bundles these brushes in the file itself- ruby,css,xml,sql,javascript,plain. Generation command used:
gulp build --compat --brushes=javascript,ruby,xml,sql,plain --theme=/Path/To/RailsSource/rails/guides/assets/stylesheets/syntaxhighlighter/shThemeRailsGuides.css
- rm all old js and css files
- Moved over how JS configuration is created for Syntax Highlighter
- Fixed layout for all imports
- Fixes bug with old copy paste, generating wrong space character on webkit 7caa9632e7/src/dom.js (L227)

 Fixes #25655
 2016-07-03 00:20:27 -07:00
Vipul A M 5324665e9f
Expand on Instance variables section with an example and specify when the instance variables are set.[ci skip] 2016-07-02 21:50:49 -07:00
William Johnston b96e5ea2e1 Update Rails 5 release notes with syntax fixes. 2016-07-02 18:13:35 -05:00
Aditya Kapoor 3f7d85bdd5 Correct guide generation command [ci skip] 2016-07-02 15:18:27 +05:30
Vipul A M 44c7507657
Fix number_with_precision documentation for precision [ci skip] 2016-07-02 02:42:43 -07:00
Ryuta Kamizono 7eb6443dde Deprecation passing of `start` value was removed [ci skip] 
ref #18961, #23099.
 2016-07-01 14:18:24 +09:00
Vipul A M 1cf1d02357
Mark Testing Guide as pubished and reword the title[ci skip] 2016-06-30 12:56:47 -07:00
Alex Kitchens e517a37cef [ci skip] Fix Typos and Punctuation in Guides - Upgrading 2016-06-30 14:36:44 -05:00
Rodrigo Rosenfeld Rosas 21a5841b1f Add a Rails 5 release note for ActionController::Live becoming a Concern 
Related to issue #25581

https://github.com/rails/rails/issues/25581
 2016-06-30 14:51:43 -03:00
Rodrigo Rosenfeld Rosas 39b576a31a Add an upgrade note related to ActionController::Live becoming a Concern 
See issue #25581:

https://github.com/rails/rails/issues/25581
 2016-06-30 14:37:39 -03:00
eileencodes d0a5f878d3 Fix styles of headings to follow guide rules 
From the style guide:
When writing headings, capitalize all words except for prepositions,
conjunctions, internal articles, and forms of the verb "to be":
 2016-06-30 12:38:35 -04:00
Alex Kitchens 9118ce596c Change wording & punctuation in Guides - Upgrading 2016-06-30 11:31:33 -05:00
Xavier Noria 11841527fc fixes config value [ci skip] 2016-06-30 17:58:45 +02:00
Xavier Noria b036b7a810 expands a bit a section of the upgrade guide [ci skip] 2016-06-30 17:50:37 +02:00
Eileen M. Uchitelle 21f72a4d34 Merge pull request #25587 from vipulnsward/publish-release-notes 
Publish Rails 5 release notes
 2016-06-30 11:25:37 -04:00
Eileen M. Uchitelle c34ca6d46f Merge pull request #25596 from prathamesh-sonpatki/testing-guide-50 
Update testing guide for Rails 5
 2016-06-30 11:25:26 -04:00
Eileen M. Uchitelle ff6173a967 Merge pull request #25598 from prathamesh-sonpatki/release-notes--1 
Update release notes for 5.0 [ci skip]
 2016-06-30 11:25:11 -04:00
Prathamesh Sonpatki 370507ba10
Add a note about autoloading being disabled in production env in upgrade guide [ci skip] 
- Also to_time_preserves_timezone config should be false for older apps getting upgraded to Rails 5 [ci skip]
 2016-06-30 20:45:45 +05:30
eileencodes f78c004fdc Update upgrade guides 
Mentions missing config options and fixes headers for section talking
about new framework defaults.
 2016-06-30 11:01:48 -04:00
Prathamesh Sonpatki 7266c6055d
Update release notes for 5.0 [ci skip] 2016-06-30 20:22:40 +05:30
Prathamesh Sonpatki 61ec678dff
Update testing guide for Rails 5 release [ci skip] 
- Update the testing guide as per output of test runner.
- Show how to see all the options provided by test runner.
- We no longer generate fixture named :first.
- Update the request methods with URL helpers and also fix few wrong occurrences.
- Generated test case does not have assert_includes for response body.
- This removes code from https://github.com/rails/rails/commit/ca83436d
  but I think that might be oversight. We don't generate such code in
  the generated controller test.
- Update the helper example to suite the integration style of tests.
- We can't modify session directly in new integration style controller
  tests.
- Show an example which matches with integration style request tests.
- Active Job default adapter for tests is async, not test.
- Fix the example of request headers and CGI variables.
 2016-06-30 19:56:20 +05:30
Prathamesh Sonpatki 60cc84bfdf
Update getting started guide for Rails 5 [ci skip] 
- Rails 5 will return 204 No Content by default for controller actions
  which do not have a template or do not specify how to render.
- The "Getting started" guide needs to be updated for this.
 2016-06-30 19:35:25 +05:30
eileencodes bb9a4f3f6d Merge branch 'add-test-runner-to-release-notes' 
This is an slight refactoring/improved version of #25586.
 2016-06-30 09:01:12 -04:00
Vipul A M a683240a32 Add test runner features to release notes [ci skip] 2016-06-30 08:22:43 -04:00
yuuji.yaginuma 93552cbe94 add missing things to release notes [ci skip] 
Add following.

* 05934d24af
* 38d2bf5fd1
* https://github.com/rails/rails/pull/25469
 2016-06-30 15:30:47 +09:00
Vipul A M 6836140090
Expand on #24071 for specifying custom locale fallbacks. [ci skip] 2016-06-29 19:05:19 -07:00
Vipul A M d04a360b8d
Publish Rails 5 release notes[ci skip] 2016-06-29 18:59:37 -07:00
Eileen M. Uchitelle fe054e02b2 Merge pull request #25583 from vipulnsward/add-api-apps-to-release-notes 
Add API Apps to release notes
 2016-06-29 21:08:27 -04:00
Vipul A M 5609e0021f
Add API Apps to release notes[ci skip] 2016-06-29 17:39:53 -07:00
eileencodes ed6eb8276a Fix release notes link 2016-06-29 20:01:03 -04:00
Eileen M. Uchitelle 178792ab34 Merge pull request #25584 from vipulnsward/upgrading-guide 
Pass over Upgrading guide
 2016-06-29 19:55:48 -04:00
Vipul A M 2dfcc87736
Pass over Upgrading guide [ci skip] 2016-06-29 16:53:28 -07:00
eileencodes 010548ab41 Add note about release notes in upgrade guide 
It's useful to have a link to the release notes in the upgrade guide for
a clearer view of what changed in Rails.
 2016-06-29 19:44:17 -04:00
eileencodes 2ee57cc9a0 Update release notes about legacy `mysql` adapter 
Make release notes about legacy `mysql` adapter clearer.
 2016-06-29 19:37:26 -04:00
eileencodes 3d252a02ae Update Rails 5 upgrade guides 
Adds missing upgrade items to the upgrade guides for Rails 5. Fixes some
typos and whitespace as well.
 2016-06-29 19:26:56 -04:00
yuuji.yaginuma e9a909c162 update description of `test_order` [ci skip] 
Follow up to 5f777e4b5e
 2016-06-29 17:15:41 +09:00
Godfrey Chan ffded19faf Clearify CHANGELOG for #23011 [ci skip] 2016-06-27 08:37:06 -07:00
Godfrey Chan bdf80369ef Add #16917 to 5.0.0 release notes 2016-06-27 08:28:24 -07:00
Vijay Dev 5343626ea8 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	actioncable/README.md
 2016-06-26 16:34:23 +00:00
yuuji.yaginuma df17f7e374 remove unecessary comments [ci skip] 
These comments were removed in 8b69f1e.
 2016-06-26 10:08:56 +09:00
Robin Dupret eb1c0e2283 Tiny documentation fixes [ci skip] 
Fix a tiny typo and vertical-align some return results in the
ActiveModel::Errors documentation.
 2016-06-25 16:10:04 +02:00
Jon Moss d5fea4f99a Update grammar for `config.enable_dependency_loading` docs 
[ci skip]

r? @rafaelfranca
 2016-06-24 17:34:21 -04:00
Rafael Mendonça França 80b416f5e6
Add option to enable dependency loading in production 
This will make easier to applications that rely on having const_missing
hooks in production upgrade to Rails 5.

This option is going to be remove in the future and the default behavior
will be to disable the dependency loading.
 2016-06-22 14:09:27 -03:00
Prathamesh Sonpatki 59f56c3a69
update_url is not `get` most of the times [ci skip] 2016-06-22 05:43:24 +08:00
Kasper Timm Hansen 7ad8093b0e Merge pull request #25450 from prathamesh-sonpatki/fix-testing-guide 
Fix the docs for supported keyword args or Rails 5 style integration controller tests [ci skip]
 2016-06-21 09:11:46 +02:00
Prathamesh Sonpatki 16283e7951
Fix the docs for supported keyword args for Rails 5 style integration controller tests [ci skip] 
- Fixes #25394.
 2016-06-21 12:05:38 +08:00
David Elliott 006cd081eb [ci skip] correction in command for generating api documentation 
reverts change in previous commit
https://github.com/rails/rails/commit/ea4f0e2

docs should prefer to use `rails` over `rake` in the context of an
application, but in the context of the Rails source this is not the case
 2016-06-20 09:20:28 -07:00
Vipul A M 87d80ba976
Make log tags example for ACa more generic and not BC specific [ci skip] 2016-06-15 21:57:09 -07:00
Prathamesh Sonpatki d66a3fe8c0
[ci skip] When instance_reader is false, attribute can still be assigned by the instance objects 2016-06-15 20:35:16 -07:00
Patrick Copeland acf9391c98 Example had results the wrong way round [ci skip] 2016-06-16 08:54:26 +12:00
Jun Wan Goh bce690a49e Add Rack doc link for request and response object [ci skip] 2016-06-14 23:48:51 +08:00
wynksaiddestroy c4861cc67d [skip ci] Fix typo and simplify after_commit example 
The beginning of the note on the :on option is not capitalised correctly.
The :destroy symbol in the after_commit example is unnecessarily wrapped in an array.
 2016-06-14 14:45:43 +02:00
Nikhil Thombare 891c3dfca5 Changed ActiveJob::Base to ApplicationJob in the Active Job guide [ci skip] 
@prathamesh-sonpatki
 2016-06-13 09:48:12 +05:30
Prathamesh Sonpatki 9f23b75926
Add missing things to Rails 5.0 release notes [ci skip] 
- https://github.com/rails/rails/pull/18288.
- https://github.com/rails/rails/commit/da9038e.
- 78dab2a856.
- https://github.com/rails/rails/pull/9065.
- https://github.com/rails/rails/pull/18314.
- https://github.com/rails/rails/pull/13434.
 2016-06-11 10:54:29 -07:00
Prathamesh Sonpatki f9a2968068
Action Cable routes are enabled by default now [ci skip] 
- Followup of 8b69f1eeba.
 2016-06-10 15:29:51 -07:00
Rafael França d2b08f2f6a Merge pull request #25321 from prathamesh-sonpatki/update-release-notes-1 
Add missing things to release notes [ci skip]
 2016-06-10 17:24:43 -04:00
Richard Schneeman 154f11663e Merge pull request #25315 from schneems/schneems/inclusion-doc 
[ci skip] Expand information on message options
 2016-06-08 15:08:32 -05:00
schneems 05b7c415c8 [ci skip] Expand information on message options 
Link to the more detailed message documentation when using a message option in validations.
 2016-06-08 08:59:51 -05:00
Xavier Noria b24b9e2751 Merge pull request #25327 from prathamesh-sonpatki/add-5-0-notes-to-the-index 
Add Rails 5.0 release notes to the index page of guides [ci skip]
 2016-06-08 06:47:16 -07:00
Prathamesh Sonpatki 928707fd50
Add Rails 5.0 release notes to the index page of guides [ci skip] 
- It is also marked as WIP as we are still refining it.
 2016-06-08 06:31:50 -07:00
David Heinemeier Hansson 84c90bbdfc Merge pull request #25323 from vipulnsward/ac-release-notes 
Add Action Cable introduction to release notes
 2016-06-08 14:09:53 +02:00
Vipul A M 2592e22ab7
Expand on AC introduction list [ci skip] 2016-06-07 17:34:28 -07:00
Vipul A M f0b9ebc43b
Add Action Cable introduction to release notes [ci skip] 2016-06-07 16:27:50 -07:00
Prathamesh Sonpatki ba5755172e
Add missing things to release notes [ci skip] 
- https://github.com/rails/rails/pull/18721
- https://github.com/rails/rails/pull/11898
- https://github.com/rails/rails/pull/18194
- https://github.com/rails/rails/pull/18225
- https://github.com/rails/rails/pull/18244
- edc2b77187
- https://github.com/rails/rails/pull/19686
 2016-06-07 16:26:45 -07:00
Jonne Haß 5e3fb2f7b0
Do not suggest nonsensical OpenSSL verify modes [ci skip] 
SSL_set_verify(3) explains:

SSL_VERIFY_FAIL_IF_NO_PEER_CERT
  Server mode: if the client did not return a certificate, the TLS/SSL
handshake is immediately terminated with a "handshake failure" alert.
This flag must
  be used together with SSL_VERIFY_PEER.

  Client mode: ignored

SSL_VERIFY_CLIENT_ONCE
  Server mode: only request a client certificate on the initial TLS/SSL
handshake. Do not ask for a client certificate again in case of a
renegotiation.
  This flag must be used together with SSL_VERIFY_PEER.

  Client mode: ignored

The SMTP connection here uses a OpenSSL socket in client mode,
suggesting invalid/ignored flags is rather misleading.
 2016-06-07 15:50:46 +02:00
David Heinemeier Hansson 3da81f89ab Merge pull request #25279 from maclover7/jm-add-backticks-1 
Add backticks to `ActiveRecord::Base.where`
 2016-06-06 18:59:25 +02:00
Alex Kitchens 63884a1e35 [ci skip] Update redirecting links in guides 2016-06-06 08:32:59 -05:00
Vipul A M 95ef0be951 Merge pull request #24071 from meinac/configuring_md_docs 
Added some useful configuration options into configuring.md [ci skip]
 2016-06-05 10:30:47 -07:00
Jon Moss d2a69d319b
Add backticks to `ActiveRecord::Base.where` 
[ci skip]
 2016-06-04 11:11:42 -04:00
Jon Moss d6d2fcb42d Merge pull request #25278 from mechanicles/fix-link 
[ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community
 2016-06-04 10:46:41 -04:00
Santosh Wadghule df0bfad26d [ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community. 2016-06-04 20:13:30 +05:30
Jon Moss bb6dc16424 Merge pull request #25277 from mechanicles/remove-pratik-from-core 
[ci skip] Remove Pratik Naik from Rails core team info.
 2016-06-04 10:41:00 -04:00
Santosh Wadghule 2ef1cd7837 [ci skip] Remove Pratik Naik from Rails core team info. 2016-06-04 19:59:55 +05:30
Vijay Dev 4e85538ddd Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/action_cable_overview.md
 2016-06-03 14:00:47 +00:00
Alex Kitchens e98caf81fe [skip ci] Make header bullets consistent in engines.md 2016-06-02 21:26:53 -05:00
Antonio Felguerez 5413d40318 add missing "as" 
it reads a bit awkwardly without it.
 2016-06-02 11:16:31 -04:00
Jon Moss cf2158cbbf
Grammar fixes for Contributing guide 
Not sure why #25239, but it had good changes, so I'm manually pulling in
the changes.

[Jon Moss, Rajat Bansal]

[ci skip]
 2016-06-02 09:35:52 -04:00
Jon Moss f832ebf496
`will be` --> `is` 
[ci skip]
 2016-05-31 10:47:34 -04:00
willnet 5693e54287 [ci skip]Fix wrong require path raising LoadError 2016-05-29 23:22:53 +09:00
yuuji.yaginuma fda13d51ac rename enum_prefix and enum_suffix options to _prefix and _suffix [ci skip] 
`:enum_prefix` and `:enum_suffix` was changed to `:_prefix` and `:_suffix`
in #20999.
 2016-05-29 20:59:08 +09:00
Jon Moss 350b7b6162
Light edits to Action Cable Overview guide 
[ci skip]
 2016-05-28 16:40:10 -04:00
yuuji.yaginuma 5e87e1faf6 fix incorrect class name [ci skip] 2016-05-28 15:08:47 +09:00
Ryuta Kamizono 997fd4d024 Use `add_index` instead of `execute` in guides [ci skip] 2016-05-28 14:26:30 +09:00
Mateusz Konieczny 1d91d4cd71 cometic updates to security guide - fixes #25058 [ci skip] 2016-05-27 20:42:26 +02:00
willnet 875ef00bda [ci skip] Fix ActionCable Guides 
Default worker pool size was changed from 100 to 4 at #24376
 2016-05-27 16:43:56 +09:00
Jared Beck f95fe79f27 Docs: Clarify when assoc. methods persist 
Because I can never remember if `collection_singular_ids=` persists
or not (it does).

[ci skip]
 2016-05-26 17:05:32 -04:00
Xavier Noria 28a7c98fe6 autoloading guide: specify autoload paths are set when the app boots [ci skip] 2016-05-26 07:42:31 +02:00
Vipul A M 1c030578d6
- ✂️ space in code to match previous defaults. 
- Grammar edits.
 2016-05-23 18:51:52 -07:00
yuuji.yaginuma 3c1c9fdf4e remove deprecated `Module#qualified_const_` from guide [ci skip] 
Follow up to #17845.
 2016-05-23 13:21:26 +09:00
Prathamesh Sonpatki 983fa3b29f
Update i18n guide about how to change locale and translations paths [ci skip] 
- config/application.rb no longer has comments about how to specify load paths
  or change default locale after
  https://github.com/rails/rails/commit/28dcadc0140dfdeb.
 2016-05-22 21:44:31 +08:00
Jon Moss 9c0791b045
Small grammar fixes for Action Controller Overview 
[ci skip]
 2016-05-21 11:16:52 -04:00