David Heinemeier Hansson
e95dd53a5d
Added two failing tests for partials with locals from controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 09:11:00 +00:00
David Heinemeier Hansson
4f40b2d8fb
Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
1ae0a53d86
Fixed regression for content_for #1820 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
b366dbd952
Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985
Added test for template to layout variable transfer
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
Jamis Buck
d76439239d
Add unit test to ensure that session management options are inherited and overridable in subclasses
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794
Added support for per-action session management #1763
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
bd558ef98e
Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
Nicholas Seckar
741316dc71
Fixed construction of get parameters for arrays
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8
Fix assert_routing with nested controllers. Closes #1582 and #1386 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 15:00:39 +00:00
David Heinemeier Hansson
7073abe159
Fixed bug with :success/:failure callbacks for the JavaScriptHelper methods #1730 [court3nay/Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 11:38:55 +00:00
Nicholas Seckar
bf0b7588ee
Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602
Provide correct defaults for Named Routes which do not specify :action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2
Made pagination faster #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
807df4fcf0
Made test_rendering_nothing_on_layout acknowledge the space
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 07:19:26 +00:00
Nicholas Seckar
2bd4ff11f8
Generate URLs for :action => index when :action => nil is supplied.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239
Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Jamis Buck
847f738cfd
Make Request#subdomains handle "foo.foo.com" correctly
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
David Heinemeier Hansson
1666977490
Script.aculo.us: latest rev, new autocompleter features, memory leaks fixed #1695 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 05:17:22 +00:00
David Heinemeier Hansson
383b6afd1c
Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:11:23 +00:00
Jeremy Kemper
c697be5b69
r2992@asus: jeremy | 2005-07-10 02:43:49 -0700
...
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:05:06 +00:00
David Heinemeier Hansson
2abe3d2cd9
Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:28:35 +00:00
Jamis Buck
8266867881
Improved error message for DoubleRenderError
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
Jeremy Kemper
34df31455a
r2948@asus: jeremy | 2005-07-08 16:00:23 -0700
...
Use save instead of save! in ARStore test also.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 18:13:07 +00:00
Nicholas Seckar
c18961f185
Routes now raise an exception if a path component is misconfigured.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62
Fix routes to generate proper URLs when given Fixnum defaults
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
David Heinemeier Hansson
05230c13f6
Include Javascript tests in rake #1655 [courtney]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 05:34:13 +00:00
Nicholas Seckar
f4bfacb24f
Enable routes to recognize uppercase controller names. Closes #1635
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42
Properly unescape recognized path components. Fixes #1651 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b
Improved testing of functional test setup.
...
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.
Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
75157bbf64
Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
Jeremy Kemper
afbf54bc3d
Add test for dynamic dispatch based on action_name accessor.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 13:45:31 +00:00
David Heinemeier Hansson
212cc3845a
Fixed routing snafu
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
2186ed83dd
Make new AJAX helpers aware of more of their options #1622 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:32:04 +00:00
David Heinemeier Hansson
93ec99c246
Partly tuned docs for release (AP)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:27:11 +00:00
Jeremy Kemper
c9901176be
benchmark helper takes an optional log level, defaults to :info. Chose symbols log levels rather than Logger::FOO constants for simplicity. Added benchmark helper test suite.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 19:33:25 +00:00
Jeremy Kemper
063956b93c
r2879@asus: jeremy | 2005-07-05 16:15:16 -0700
...
Rollback changesets for Ticket #1229 .
r2880@asus: jeremy | 2005-07-05 16:17:08 -0700
Ticket #1229 does not affect Ticket #1614 . Reinstating the changesets.
r2881@asus: jeremy | 2005-07-05 16:24:04 -0700
@test_unchanged in deprecated render test :partials_list action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:31:51 +00:00
Jeremy Kemper
8a2fec8d31
r2874@asus: jeremy | 2005-07-05 16:13:39 -0700
...
Unit test for Ticket #1614 .
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:21:26 +00:00
David Heinemeier Hansson
4fe0248f57
Fixed routing regression on index exception
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02
Routing fix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:06:09 +00:00
Jeremy Kemper
1e6603e6e7
r2850@asus: jeremy | 2005-07-05 13:08:32 -0700
...
Don't be strict about the order in which AR store methods are called. Allow e.g. session close followed by session close.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 14:50:07 +00:00
Jeremy Kemper
ed12b0cac0
r2836@asus: jeremy | 2005-07-05 00:33:12 -0700
...
Test sessid backward compatibility. DRY up the test classes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 02:29:37 +00:00
Jeremy Kemper
ac412ef1c7
r2822@asus: jeremy | 2005-07-04 21:14:30 -0700
...
silence warnings re. class redefinitions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:58 +00:00
Jeremy Kemper
79455b6d45
r2821@asus: jeremy | 2005-07-04 21:14:16 -0700
...
reuse path_to_ar
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1686 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:54 +00:00
Jeremy Kemper
5ab1df9e37
r2820@asus: jeremy | 2005-07-04 21:13:57 -0700
...
Bring in-mem SQLite goodness to active_record_assertions_test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:49 +00:00
Jeremy Kemper
7bcaf2b689
r2817@asus: jeremy | 2005-07-04 20:49:12 -0700
...
active_record_store_test falls back to SQLite2 if 3 is unavailable
r2818@asus: jeremy | 2005-07-04 20:52:25 -0700
update changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 22:48:01 +00:00
Jeremy Kemper
ddb57d8ab8
r2815@asus: jeremy | 2005-07-04 19:49:35 -0700
...
Correct SqlBypass test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:46:01 +00:00
Jeremy Kemper
509bf53889
r2809@asus: jeremy | 2005-07-04 19:29:19 -0700
...
give CGI::Session options as strings, not symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:50 +00:00
Jeremy Kemper
50619549ee
r2808@asus: jeremy | 2005-07-04 19:08:48 -0700
...
test at dbman and at CGI::Session level. need to merge the test classes since they're the same tests for different backends..
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:45 +00:00
David Heinemeier Hansson
128e352614
Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 19:21:48 +00:00
Jeremy Kemper
452442dde8
r2790@asus: jeremy | 2005-07-04 16:30:58 -0700
...
smart active record session class. session class is pluggable; a basic SqlBypass class is provided. set CGI::Session::ActiveRecordStore.session_class = SqlBypass and set SqlBypass.connection = SomeARConnection. Further tests pending.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:27 +00:00
Jeremy Kemper
5900d4ff75
r2788@asus: jeremy | 2005-07-04 16:16:20 -0700
...
Don't unnecessarily pollute $:. Use SQLite3 instead of SQLite by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:17 +00:00
Jamis Buck
6e7e552b03
Fix broken capture test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:36:22 +00:00
Jamis Buck
fcdcd9b9fa
Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:31:37 +00:00
Jamis Buck
cf9c991d4c
Fix test broken by [1648]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:20:25 +00:00
David Heinemeier Hansson
bf3a0c5391
Improved update_element_function #1597 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 04:57:15 +00:00
David Heinemeier Hansson
c52edf2319
Added :prompt option to FormOptions#select (and the users of it, like FormOptions#select_country etc) to create "Please select" style descriptors #1181 [Michael Schuerig]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:23:16 +00:00
David Heinemeier Hansson
5524dedc06
Fixed routing bug #1592
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:01:06 +00:00
David Heinemeier Hansson
208291391c
Added JavascriptHelper#update_element_function, which returns a Javascript function (or expression) that'll update a DOM element according to the options passed #933 [mortonda@dgrmm.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 11:01:43 +00:00
David Heinemeier Hansson
481cac9658
AJAX error handling fix, Prototype event handling #1589 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 08:00:38 +00:00
David Heinemeier Hansson
c6ab8f5706
Added :field_name option to DateHelper#select_(year|month|day) to deviate from the year/month/day defaults #1266 [Marcel Molina]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:38:22 +00:00
David Heinemeier Hansson
b94e8af9a4
Update for JavaScript helper tests #1584 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:20:13 +00:00
David Heinemeier Hansson
177ed3e681
Added more tests on assert_redirected_to #1581 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:16:38 +00:00
David Heinemeier Hansson
a53372c273
Added that UrlHelper#mail_to will now also encode the default link title #749 [f.svehla@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:46:41 +00:00
David Heinemeier Hansson
5651a69130
Load models and frequency typo on upoad progress #1555 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
524d1b5e04
Uncommented request.recycle! as it breaks more than it fixes, left test case in, xal?
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-30 14:49:36 +00:00
David Heinemeier Hansson
94cae0d0a2
Got back to functional testing harmony
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 09:44:55 +00:00
David Heinemeier Hansson
2d8679993c
Fix JavaScriptHelper capitalization and make it compatible with Prototype #1545 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 08:09:00 +00:00
Jeremy Kemper
31e48939b1
r1475@iwill: jeremy | 2005-06-28 23:19:51 -0700
...
Ticket 1543 - Fix test_process
r1476@iwill: jeremy | 2005-06-29 00:20:53 -0700
Correct expected, actual order for assert_equal. Use new render method in TestController.
r1477@iwill: jeremy | 2005-06-29 00:23:45 -0700
Generate route and assign parameters without modifying the user's params.
r1480@iwill: jeremy | 2005-06-29 00:28:52 -0700
Update changelog.
r1481@iwill: jeremy | 2005-06-29 00:34:02 -0700
Directly generate paths with a leading slash instead of tacking it on later.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 02:41:00 +00:00
Jamis Buck
453ed15395
Routes fail with leading slash #1540 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 21:18:04 +00:00
David Heinemeier Hansson
beffb77e05
Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
b8689c77a4
Don't ignore :controller for urls made inside a controller module #1526 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 15:17:59 +00:00
David Heinemeier Hansson
a7116b6534
Make named routes work without hashes #1523 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 14:32:19 +00:00
David Heinemeier Hansson
2269c23699
Fixed assert_redirected_to to handle absolute controller paths properly #1472 [Rick Olson/Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 05:36:03 +00:00
David Heinemeier Hansson
930b59eb39
Fixed that Functional tests do not set request.path_parameters properly #1512 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 14:36:13 +00:00
David Heinemeier Hansson
7da736f929
Added script.aculo.us Javascripts (controls.js, dragdrop.js, effects.js) (NEEDS MORE DESCRIPTION) #1509 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 12:03:43 +00:00
David Heinemeier Hansson
6f6c6b8bcb
Updated assert_generates/routing to the new Routes code #1498 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:58:44 +00:00
Jamis Buck
17928b7347
Eliminate a "string literal in condition" warning from some routes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 09:20:38 +00:00
Jamis Buck
af33a6a6b1
Fix problem with symbol/string mismatch on some routes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 22:15:45 +00:00
David Heinemeier Hansson
8e56f5ea3e
Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
David Heinemeier Hansson
964a477340
Include Routing tests in rake run #1287
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:39:28 +00:00
David Heinemeier Hansson
c608ebeade
Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
1e0d9a642f
Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
bc6570dfcb
Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06
Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
a49a784dc7
More tests for JavascriptHelper #1460
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-18 05:17:39 +00:00
David Heinemeier Hansson
92473b8f96
Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-18 05:17:18 +00:00
Jeremy Kemper
959707bfb6
r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700
...
Ticket 1458 - distance_of_time_in_words
r1336@iwill: jeremy | 2005-06-17 11:44:50 -0700
Update changelog
r1337@iwill: jeremy | 2005-06-17 11:45:44 -0700
Applied patch.
r1361@iwill: jeremy | 2005-06-17 11:48:02 -0700
Merge changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a895be0259
Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:42:49 +00:00
David Heinemeier Hansson
a7a1c4e2cd
Added cuba to country list #1351 [todd]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
665ab93761
Added :extension option to NumberHelper#number_to_phone #1361 [delynnb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4
Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6
Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a
Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f
Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd
Its Iraq, not Irak #1443 [ivan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8
Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e
r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700
...
Ticket 1394 - Helper isolation
r1319@iwill: jeremy | 2005-06-15 01:10:00 -0700
Formulate a test case for helper isolation.
r1331@iwill: jeremy | 2005-06-15 15:21:07 -0700
Update changelog
r1332@iwill: jeremy | 2005-06-15 15:21:30 -0700
Remove superfluous, broken layout_test
r1333@iwill: jeremy | 2005-06-15 15:24:10 -0700
Use an anonymous Module to store helpers per-class instead of tossing them all in template_class. Create a new helper module for subclasses which includes its superclass' helper module. Remove unnecessary ActionView::Base.controller_delegate. Update helper tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f
render(:template) applies a layout by default. render("foo/bar") works with a layout again.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
cb79118111
Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216 , #1404 [nilsga]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 04:17:45 +00:00
Jamis Buck
ed7bfc9662
Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 15:19:03 +00:00
Jamis Buck
75fb0a32a8
Support :render option to :verify #1440 [TobiasLuetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39
Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 10:31:31 +00:00
Jeremy Kemper
3cb26e9cb3
r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700
...
Branch to have scaffold use new render methods
r2496@sedna: jeremy | 2005-05-28 10:50:51 -0700
axe unused process_request method
r2497@sedna: jeremy | 2005-05-28 10:51:58 -0700
sanity assertions in process method check that @controller , @request, @response are set
r2498@sedna: jeremy | 2005-05-28 10:53:42 -0700
clean up escaping. use instance_variable_get instead of instance_eval. put id in form action instead of hidden input (like the generated scaffolding)
r2499@sedna: jeremy | 2005-05-28 10:54:46 -0700
clean up interpolation, remove tabs from stylesheet
r2500@sedna: jeremy | 2005-05-28 10:56:40 -0700
modernize dynamic scaffolding. use params[:id] instead of @params[id]. use consolidated render method instead of render_action, render_file, etc. use builtin inflections rather than module methods.
r2501@sedna: jeremy | 2005-05-28 11:00:26 -0700
modernize generated scaffolding. use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
r2542@sedna: jeremy | 2005-06-12 02:24:06 -0700
use :id => model instead of :id => model.id. clean up the form helper method. use flash[:notice] instead of flash['notice'].
r2543@sedna: jeremy | 2005-06-12 02:33:22 -0700
whitespace
r2544@sedna: jeremy | 2005-06-12 02:56:57 -0700
update changelogs
r2545@sedna: jeremy | 2005-06-12 03:26:23 -0700
test dynamic form help when @post is not a new record
r2546@sedna: jeremy | 2005-06-12 03:44:14 -0700
touch up TestCase#process sanity assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-12 05:33:23 +00:00
Jamis Buck
f6ec9e3d66
Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-10 12:21:25 +00:00
Jamis Buck
e4c047e489
render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5
render(:inline) defaults to :layout => false
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3
Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1
render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b
verify with :redirect_to won't redirect if a redirect or render has already been performed #1350
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa
render(:partial => "...") uses an empty hash for the local assigns #1365 . render(:partial => true) is identical to the older render_partial()
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
79d9794f09
Updated unit test style
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720
Test for no layout on nothing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
da0c4c5c96
Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6
Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
d3704f888b
Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
dd8c92ea5b
Fixed Request#remote_ip in testing #1251 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
473e5bde74
Fixed that compute_public_path should recognize external URLs, so image_tag(" http://www.example.com/images/icon.gif ") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751
Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
496ee0cd1b
Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
aa20834222
Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
45780be2a7
Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
dacb61c8ca
Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all"
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
e6f3e5d900
Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
98306bed05
Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
b4fe4daa84
Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
3b9bf64130
Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
806cf6d76a
Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
dca7efa67e
Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9
Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d
Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
e5b3d08a0a
Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
ffdd4bc251
Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
68dfe3e046
Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
7f558cbd05
Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
c29db9f210
Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
988dc1e862
Improved tests for NumberHelper
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
7140f65355
Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
ac4b4701c0
Fixed that radio buttons shouldn't have a default size attribute #1074 [hendrik@mans.de] Added ActionView::Helpers::InstanceTag::DEFAULT_RADIO_OPTIONS that contains a hash of default options for radio buttons #1074 [hendrik@mans.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:11:15 +00:00
David Heinemeier Hansson
25d27b39ea
Fixed a few tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:07:52 +00:00
David Heinemeier Hansson
4ab40059b7
Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
808d76a858
Fixed autolinking to work better in more cases #1013 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-06 15:22:46 +00:00
David Heinemeier Hansson
7c8d2f28e1
Removed broken attempt to DRY module ClassMethod #970
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
ce96c5b30b
Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
00121b2ca2
Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
f7c61b629e
Added options to set cc, bcc, subject, and body for UrlHelper#mail_to #966 [DeLynn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:16:57 +00:00
David Heinemeier Hansson
7d09b8d723
Fixed include_blank for select_hour/minute/second #527 [edward@debian.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 07:54:01 +00:00
David Heinemeier Hansson
520dae295b
Added include_seconds option as the third parameter to distance_of_time_in_words which will render "less than a minute" in higher resolution ("less than 10 seconds" etc) #944 [thomas@fesch.at]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 22:00:23 +00:00
David Heinemeier Hansson
9fb6a54a16
Added fourth option to process in test cases to specify the content of the flash #949 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:43:25 +00:00
David Heinemeier Hansson
f569a14318
Added Verifications that allows you to specify preconditions to actions in form of statements like <tt>verify :only => :update_post, :params => "admin_privileges", :redirect_to => { :action => "settings" }</tt>, which ensure that the update_post action is only called if admin_privileges is available as a parameter -- otherwise the user is redirected to settings. #897 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:41:10 +00:00
David Heinemeier Hansson
3fe9d8ac35
Added JavascriptHelper#escape_javascript as a public method (was private) and made it escape both single and double quotes and new lines #940 [mortonda@dgrmm.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 14:03:55 +00:00
David Heinemeier Hansson
a5b55c6b9f
Removed old UrlWriter methods that are no longer in use after Routes #942
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:31:01 +00:00
David Heinemeier Hansson
b88fa4d1df
Routes: *path items should use arrays #883
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-21 00:40:51 +00:00
David Heinemeier Hansson
0919dbf6b6
Routes: Convert results of #to_param to strings #879
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 22:44:12 +00:00
David Heinemeier Hansson
a61360688c
Changed .htaccess to allow dispatch.* to be called from a sub-directory as part of the push with Action Pack to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke] Fixed routing and helpers to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 22:02:22 +00:00
David Heinemeier Hansson
a35cf348bf
Added a much improved Flash module that allows for finer-grained control on expiration and allows you to flash the current action #839 [Caio Chassot]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 19:12:53 +00:00
David Heinemeier Hansson
6cd3bda32f
Fixed form helpers to query Model#id_before_type_cast instead of Model#id as a temporary workaround for Ruby 1.8.2 warnings #818 [DeLynn B]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 15:08:30 +00:00
David Heinemeier Hansson
1b93da3262
Added TextHelper#simple_format as a non-dependency text presentation helper.Fixed TextHelper#markdown to use blank? instead of empty? so it can deal with nil strings passed #814 [Johan Sorensen]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 15:03:32 +00:00
David Heinemeier Hansson
ebf6637918
Added that the html options disabled, readonly, and multiple can all be treated as booleans. So specifying <tt>disabled => :true</tt> will give <tt>disabled="disabled"</tt>. #809 [mindel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 14:49:37 +00:00
David Heinemeier Hansson
37a46151ec
Added path collection syntax for Routes that will gobble up the rest of the url and pass it on to the controller #830 [rayners]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 14:04:33 +00:00
David Heinemeier Hansson
f32cbb52a5
Added more FormTagHelper test cases #860 [Eric Hodel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@925 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 13:51:01 +00:00
David Heinemeier Hansson
9015ce4cc2
Fixed options_for_select on selected line issue #624 [Florian Weber]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-15 00:13:14 +00:00
David Heinemeier Hansson
193edfbfdb
Removed the reliance on PATH_INFO as it was causing problems for caching and inhibited the new non-vhost support #822 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-14 00:25:24 +00:00
David Heinemeier Hansson
9790233dfd
Moved image_tag to AssetTagHelper
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-14 00:18:12 +00:00
David Heinemeier Hansson
5a4846a0d3
Added TagHelper#image_tag and deprecated UrlHelper#link_image_to (recommended approach is to combine image_tag and link_to instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-09 13:53:47 +00:00
David Heinemeier Hansson
688f0f6712
Fixed that map.connect should convert arguments to strings #780 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 14:16:25 +00:00
David Heinemeier Hansson
fd9967bca2
Added UrlHelper#link_to_if/link_to_unless to enable other conditions that just link_to_unless_current #757 [mindel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 14:06:33 +00:00
David Heinemeier Hansson
a22ed3d8c2
Use example.com domains to make rails RFC2606 compliant #708
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@840 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:27:06 +00:00
David Heinemeier Hansson
25b656fefa
Fixed that single quote was not escaped in a UrlHelper#link_to javascript confirm #549 [Scott Barron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:07:13 +00:00
David Heinemeier Hansson
eb5ca2ea5f
Removed the default border on link_image_to (it broke xhtml strict) -- can be specified with :border => 0 #517 [?/caleb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@836 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:02:17 +00:00
David Heinemeier Hansson
dfac1cea3d
Fixed that form helpers would treat string and symbol keys differently in html_options (and possibly create duplicate entries) #112 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 11:50:41 +00:00
David Heinemeier Hansson
28a11969ce
Fix request.path_info and clear up LoadingModule behavior #754 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-01 02:04:54 +00:00
David Heinemeier Hansson
630638b00e
Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
8cddbf0d37
Added PATH_INFO access from the request that allows urls like the following to be interpreted by rails: http://www.example.com/dispatcher.cgi/controller/action -- that makes it possible to use rails as a CGI under lighttpd and would also allow (for example) Rublog to be ported to rails without breaking existing links to Rublog-powered blogs. #728 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:11:05 +00:00
David Heinemeier Hansson
02df588cf7
Fixed tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 11:50:59 +00:00
David Heinemeier Hansson
b7889524bf
Fix empty url_for with nested modules #707
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
11a2bb91f5
Added some unit tests #706
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 23:53:55 +00:00
David Heinemeier Hansson
fd6abf0a59
Fixed tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 15:05:04 +00:00
David Heinemeier Hansson
41ea6963a3
Added Base#render_to_string to parse a template and get the result back as a string #479
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
2bf29b3485
Added FormOptionsHelper#time_zone_select and FormOptionsHelper#time_zone_options_for_select to work with the new value object TimeZone in Active Record #688 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:54:58 +00:00
David Heinemeier Hansson
cd689cf22b
Fixed some tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:52:38 +00:00
David Heinemeier Hansson
f153f42469
Never end generated paths with a '/' #683
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 20:54:40 +00:00
David Heinemeier Hansson
acb3d2cf75
Fixed internal calling
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a
Tests and tweaks for components
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
0011116592
Unit tests for rendering components
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:49:12 +00:00
David Heinemeier Hansson
cae0f46eda
Fixed a few tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:21:08 +00:00
David Heinemeier Hansson
9a5d6d6388
Added ActionView::Base.register_template_handler for easy integration of an alternative template language to ERb and Builder. See test/controller/custom_handler_test.rb for a usage example #656 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 17:22:37 +00:00
David Heinemeier Hansson
2a5fc27cea
Added AssetTagHelper that provides methods for linking a HTML page together with other assets, such as javascripts, stylesheets, and feeds.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 16:04:50 +00:00
David Heinemeier Hansson
ad1fe7dd27
Completed FormTagHelper by adding radio_button_tag and select_tag
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 13:09:09 +00:00
David Heinemeier Hansson
967339e4d3
Added FormTagHelper that provides a number of methods for creating form tags that doesn't rely on conventions with an object assigned to the template like FormHelper does. With the FormTagHelper, you provide the names and values yourself.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:49:14 +00:00
David Heinemeier Hansson
5eac7ad1d9
Updated tests for TextHelper#auto_link
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:19:20 +00:00
David Heinemeier Hansson
5760a6cb3e
Clear route defaults using :name => nil #663
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:53:18 +00:00
David Heinemeier Hansson
519fe7ccbc
Added URL escaping for routing #664
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:52:28 +00:00
David Heinemeier Hansson
37249f6a86
Fixed that assert_template_xpath_matches did not indicate when a path was not found #658 [Eric Hodel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 17:13:57 +00:00
David Heinemeier Hansson
b305756d9f
Added TextHelper#auto_link, TextHelper#auto_link_urls, and TextHelper#auto_link_email_addresses to turn those elements into ahrefs
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 14:06:36 +00:00
David Heinemeier Hansson
bc574a86ac
Skip Active Record tests in Action Pack if the SQLite database cant be brought up
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:28:13 +00:00
David Heinemeier Hansson
02e382a765
More tests for Routing related stuff
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:00:21 +00:00
David Heinemeier Hansson
6a48e89ae7
Fix that routes werent being loaded in production environment
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 02:04:37 +00:00
David Heinemeier Hansson
29066036f2
Make Routes drop the default for action when the controller changes #651
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 01:46:29 +00:00
David Heinemeier Hansson
b1999be5a7
A hopefully more successful attempt at the Routing branch merge
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5
Backed out of routing merge.. investigating missing patches
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a
Merged back the Routing branch
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
65f834ad45
Stringify the parameters on follow_redirect
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 21:54:34 +00:00
David Heinemeier Hansson
61a6a440cb
Added follow_redirect method for functional tests that'll get-request the redirect that was made.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 19:35:30 +00:00
David Heinemeier Hansson
098fa94356
Fixed documentation snafus #575 , #576 , #577 , #585
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
b69d337527
Applied the dblack patch
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 15:35:30 +00:00
David Heinemeier Hansson
80b656637a
Added :application_prefix to url_for and friends that makes it easier to setup Rails in non-vhost environments #516 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:50:58 +00:00
David Heinemeier Hansson
45db66de56
Added :encode option to mail_to that'll allow you to masquarede the email address behind javascript or hex encoding #494 [Lucas Carlson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:48:24 +00:00
David Heinemeier Hansson
dfed3d309e
A few missing files
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
2ee84cc6f9
Fixed that all redirect and render calls now return true, so you can use the pattern of "do and return". Added that renders and redirects called in before_filters will have the same effect as returning false: stopping the chain. Added that only one render or redirect can happen per action. The first call wins and subsequent calls are ignored.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:13:34 +00:00
David Heinemeier Hansson
9c09f81bc6
Added arrays as a value option for params in url_for and friends #467 [Eric Anderson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:06:33 +00:00
David Heinemeier Hansson
96e54780b3
Fixed that send_file would "remember" all the files sent by adding to the headers again and again #458 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:29:49 +00:00
David Heinemeier Hansson
d3a8d5f93c
Fixed url rewriter confusion when the controller or action name was a substring of the controller_prefix or action_prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 16:23:18 +00:00
David Heinemeier Hansson
cb8a020ec9
Fixed url rewriter confusion when the controller name was a substring of the controller_prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 15:21:09 +00:00
David Heinemeier Hansson
11f766d3eb
Removed authentication framework as xal made me realize that with noradios conditional filters, it was actually more code to use the framework than doing it by hand. Killing a darling! Props to noradio for the patch and xal for the nerve to stand up and question the captain before the plane crashed. Oh, and a pad on my own back for walking away from a couple of hours of work without getting pissy
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:21:29 +00:00
David Heinemeier Hansson
677d92299b
Added conditional filters #431 [Marcel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:14:47 +00:00
David Heinemeier Hansson
cbd367b7fa
Added :before option to authentication
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 16:43:21 +00:00
David Heinemeier Hansson
75fca04590
Added authentication framework to protect actions behind a condition and redirect on failure. See ActionController::Authentication for more.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 15:20:00 +00:00
David Heinemeier Hansson
0b6fe2244e
Taken out as noradio took over
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-08 23:41:42 +00:00
David Heinemeier Hansson
efe0348486
Added the possibility of passing nil to UrlHelper#link_to to use the link itself as the name
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@338 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-05 00:38:09 +00:00
David Heinemeier Hansson
3e7a4ecc57
Fixed redirects when the controller and action is named the same. Still haven't fixed same controller, module, and action, though #201 [Josh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-02 20:10:11 +00:00
David Heinemeier Hansson
ce58e5cd06
Added DateHelper#select_time and DateHelper#select_second #373 [Scott Baron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-02 15:32:01 +00:00
David Heinemeier Hansson
3b05d412de
Fixed some test cases
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-01 16:41:14 +00:00
David Heinemeier Hansson
00deaf6d56
Added :host and :protocol options to url_for and friends to redirect to another host and protocol than the current.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 18:59:24 +00:00
David Heinemeier Hansson
d91405a415
Fixed UrlHelper#link_to_unless so it doesn't care if the id is a string or fixnum [zenspider]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 22:50:44 +00:00
David Heinemeier Hansson
a04b1f3d8a
Added more informative exception when using helper :some_helper and the helper requires another file that fails, you'll get an error message tells you what file actually failed to load, rather than falling back on assuming it was the helper file itself #346 [dblack]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:44:16 +00:00
David Heinemeier Hansson
7b5ed66122
Added respondence to *_before_type_cast for all attributes to return their string-state before they were type casted by the column type. Added use of *_before_type_cast for all input and text fields.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:25:55 +00:00
David Heinemeier Hansson
61960e7b37
Added Request#port_string to get something like ":8080" back on 8080 and "" on 80 (or 443 with https).
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 18:01:28 +00:00
David Heinemeier Hansson
a7532f9d5f
Added Request#domain (returns string) and Request#subdomains (returns array).
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 17:19:15 +00:00
David Heinemeier Hansson
db6179d12f
Fixed DateHelper#date_select so that you can pass include_blank as an option even if you don't use start_year and end_year #59 [what-a-day]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-15 12:47:50 +00:00
David Heinemeier Hansson
c80f974fa3
Added FormHelper#radio_button to work with radio buttons like its already possible with check boxes [Michael Koziarski]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-14 13:48:27 +00:00
David Heinemeier Hansson
922f817a5a
Added the option of passing false to :module or :controller_prefix in order to "break out" of a module or prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-13 11:35:48 +00:00
David Heinemeier Hansson
0cce17f811
Updated unit tests to reflect lowercase post as method in form tags
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-13 11:08:21 +00:00
David Heinemeier Hansson
0990c1309d
Fixed all helpers so that they use XHTML compliant double quotes for values instead of single quotes [htonl/bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-12 11:31:54 +00:00
David Heinemeier Hansson
85a5deacdc
Use lower-case post instead of POST as form method for XHTML compliance #290 [Scott Baron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-12 11:17:25 +00:00
David Heinemeier Hansson
1188d3005a
Fixed problem with cookies not being set to path=/ by default and a test buggerboo
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-10 17:16:11 +00:00
David Heinemeier Hansson
e1917cab32
Added link_to_image(src, options = {}, html_options = {}, *parameters_for_method_reference)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-09 23:18:25 +00:00
David Heinemeier Hansson
c8d68dfed3
Killed the out of place alias and made sure you can use the different HTTP methods within the same testaction
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@80 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-08 10:43:24 +00:00
David Heinemeier Hansson
465e0c0c26
Added the possibility of having validate be protected for assert_(in)valid_column #263 [Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@67 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 12:18:33 +00:00
David Heinemeier Hansson
1e4a936bd0
Trick tests on url_for
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@66 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 12:17:17 +00:00
David Heinemeier Hansson
a544d7aa37
Added all the HTTP methods as alternatives to the generic "process" for functional testing #276 [Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@58 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 11:10:46 +00:00
David Heinemeier Hansson
005371e16c
Added options to tailor header tag, div id, and div class on ActiveRecordHelper#error_messages_for [josh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@41 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 13:59:16 +00:00
David Heinemeier Hansson
50f333b203
Added graceful handling of non-alphanumeric names and misplaced brackets in input parameters [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@39 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 12:57:16 +00:00
David Heinemeier Hansson
177cae5483
Allow symbols to be used as names for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@22 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:11:42 +00:00
David Heinemeier Hansson
defda16b83
Allow symbols to be used as keys for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@21 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:09:38 +00:00
David Heinemeier Hansson
d0c90331f1
Added a new container for cookies that makes them more intuative to use. The old methods of cookie and @cookies have been deprecated.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@20 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:04:35 +00:00
David Heinemeier Hansson
db045dbbf6
Initial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00