rails/rails@957a3e5 allowed the BACKTRACE env to unsilence backtraces in normals runs not just tests. However, the implementation achieves this by removing the silences in an initializer. This means that the state of backtrace silencer becomes cached by spring and the developer needs to reset spring every time they want to silence or unsilence the backtrace. It also means custom silencers added in an initializer need to be added after the :configure_backtrace_cleaner initializer or else they won't be un-silenced properly.
Instead, let's teach Rails::BacktraceCleaner to unsilence the backtrace if the BACKTRACE variable is set. ActiveSupport::BacktraceCleaner#clean already allows this by passing nil as the second argument, which just filters but does not silence the backtrace. So, in Rails::BacktraceCleaner#clean we can call super with nil in the second argument if the BACKTRACE variable is present. That way we do not need to remove the silencers in an initializer, and we don't have to reset spring to silence the backtrace.
```
2024-04-26 09:36:45 INFO Selenium [:logger_info] Details on how to use and modify Selenium logger:
https://selenium.dev/documentation/webdriver/troubleshooting/logging
2024-04-26 09:36:45 WARN Selenium [DEPRECATION] DriverFinder.path(options, service_class) is deprecated. Use DriverFinder.new(options, service).driver_path instead.
```
This commit will not install the selenium-webdriver` version 4.20.0
because `Selenium::WebDriver::DriverFinder.path` was dropped in `selenium-webdriver` 4.20.0 that was not intentional.
It will be restored once the newer version of `selenium-webdriver` that includes https://github.com/SeleniumHQ/selenium/pull/13877 .
Fix#51658
[ci skip] Add more gem docs in Rails Application Templates guide
Added doc on how to add a gem with a specific version.
Added doc on how to add a comment.
As is the case with the `rake preview_docs` task.
```
Error reading assets/stylesrc/style.scss: Cannot open file.
Error reading assets/stylesrc/highlight.scss: Cannot open file.
Error reading assets/stylesrc/print.scss: Cannot open file.
```
This mirrors the documentation on `preload_link_tag` for the following:
- `javascript_include_tag`
- `stylesheet_link_tag`
These methods have a similar API with a different default behavior. The
methods for these methods default to including a `nopush` with the
corresponding link header.
Update activerecord/lib/active_record/connection_adapters/postgresql/oid/cidr.rb
Co-authored-by: Yasuo Honda <yasuo.honda@gmail.com>
Updated to keep the argument order
Added note to remove `changed?` method when `IPAddr#==` compares `IPAddr#prefix`
Update guides: Replace filter with action callback [ci skip]
Rails 4.2 onwards replaced filter with action callback. However, the term has remained in the rails guides and this PR fixes this.
Types of change:
* Filter(s) => Action callback(s)
* Generalized the word "Action callbacks" as it is longer.
* actions => "controller actions" to make "controller actions" more distinct from "action callbacks".
Rails 4.2 onwards replaced filter with action callback. However,
the term has remained in the rails guides and this PR fixes this.
Term used is "action callbacks" as this was used in the changelog:
> Deprecate all *_filter callbacks in favor of *_action callbacks.
[Original Change](489a8f2a44)
Types of change:
- Filter(s) => Action callback(s)
- Generalized the word "Action callbacks" as it is longer.
- actions => "controller actions" to make "controller actions"
more distinct from "action callbacks".
Improve migration.rb documentation consistency [ci skip]
* Reference the method name as it in the code
* Replace version for number everywhere to avoid confusion
Jean Boussier