bde5f3bfc6
Merge pull request #35761 from koic/bump_rubocop_to_0_66_0
...
Bump RuboCop to 0.66.0
2019-03-27 08:38:57 +09:00
c2093cdf8e
Merge pull request #35753 from Edouard-chin/ec-mimetype-rescue
...
Add the `Mime::Type::InvalidMimeType` error in the default rescue_response:
2019-03-26 19:08:55 -04:00
1e1adadb41
Bump RuboCop to 0.66.0
...
### Summary
RuboCop 0.66.0 has been released.
https://github.com/rubocop-hq/rubocop/releases/tag/v0.66.0
And rubocop-0-66 channel is available in Code Climate.
https://github.com/codeclimate/codeclimate/releases/tag/v0.84.0
RuboCop 0.66.0 fixed the false negative to indentation for
modifier. And this PR applied the auto-correction fixed by it.
https://github.com/rubocop-hq/rubocop/pull/6792
In addtion, this PR is also updating the following 4 gems that
RuboCop depends on.
- Update Psych gem ... https://github.com/rubocop-hq/rubocop/pull/6766
- Update Parser gem to 2.6.2.0 that supports Ruby 2.5.5 and 2.6.2 ...
https://github.com/whitequark/parser/blob/v2.6.2.0/CHANGELOG.md#changelog
- Remove powerpack gem ... https://github.com/rubocop-hq/rubocop/pull/6806
- Update unicode-display_width gem ... https://github.com/rubocop-hq/rubocop/pull/6813
2019-03-27 07:57:43 +09:00
2cf3974712
Merge pull request #35760 from jhawthorn/deprecate_custom_resolver_patterns
...
Deprecate custom patterns for PathResolver
2019-03-26 18:30:25 -04:00
573e361a3c
Deprecate custom patterns for PathResolver
...
Custom glob patterns tie the implementation (Using Dir.glob) to the API
we provide.
It also doesn't really work. extract_handler_and_format_and_variant
expects the handler, format, and variant to be at the end of the
template path, and in the same order as they are in the default pattern.
This deprecates specifying a custom path for FileSystemResolver and
removes the pattern argument of OptimizedFileSystemResolver#initialize,
which does not work with a custom pattern.
2019-03-26 14:19:31 -07:00
c0f29ab75e
includes bootsnap 1.4.2-java in Gemfile.lock
...
Was just pushed.
2019-03-26 21:32:17 +01:00
379d7e8bfa
bumps Zeitwerk and Bootsnap
2019-03-26 20:30:18 +01:00
d2f0cb1615
Remove useless = [ci skip]
2019-03-26 23:48:20 +05:30
c546f9040e
Aligned the order of the arguments of render_template and render_with_layout
2019-03-27 01:09:34 +09:00
3296dc2589
Merge pull request #31442 from ebeigarts/weak_descendants_tracker
...
Use weak references in descendants tracker
2019-03-27 00:14:40 +10:30
25f2e0c39d
Raise if resource custom params contain colons
...
After this change it's not possible anymore to configure routes
like this:
routes.draw do
resources :users, param: "name/:sneaky"
end
Fixes #30467 .
2019-03-26 13:53:41 +01:00
7432c9226e
Use weak references in descendants tracker
...
It allows anonymous subclasses to be garbage collected.
2019-03-26 12:11:37 +02:00
08a435fa8c
Merge pull request #35756 from sergioro9/patch-1
...
Grammar error
2019-03-26 09:49:13 +01:00
3c7ab1a45a
Spelling error
2019-03-26 02:04:04 -06:00
5917e50382
Merge pull request #35743 from soartec-lab/update_guide_active_support_deprecation_silenced
...
Add default value `ActiveSupport::Deprecation.silenced` [ci skip]
2019-03-26 12:46:57 +05:30
b2b559c75c
Fix CI failure due to remaining tagging records
...
`TRUNCATE TABLE posts` also resets `AUTO_INCREMENT`. If newly created a
post, it is wrongly associated with remaining tagging records.
To un-associate remaining tagging record, use `post.create_tagging!`
instead.
Fixes #35751 .
2019-03-26 12:59:16 +09:00
5883a72092
Merge pull request #35754 from yahonda/diag35665
...
Use `assert_queries(0)` instead of `assert_no_queries`
2019-03-26 12:41:41 +09:00
4dd3b2bd9a
Use `assert_queries(0)` instead of `assert_no_queries` to ignore metadata queries
...
Fix #35665
```ruby
$ ARCONN=mysql2 bin/test test/cases/scoping/named_scoping_test.rb test/cases/tasks/database_tasks_test.rb test/cases/associations/cascaded_eager_loading_test.rb test/cases/associations/eager_singularization_test.rb -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818
Using mysql2
Run options: -n "/^(?:NamedScopingTest#(?:test_many_should_not_fire_query_if_scope_loaded)|ActiveRecord::DatabaseTasksDumpSchemaCacheTest#(?:test_dump_schema_cache)|CascadedEagerLoadingTest#(?:test_eager_association_loading_with_has_many_sti_and_subclasses)|EagerSingularizationTest#(?:test_eager_no_extra_singularization_has_many_through_belongs_to))$/" --seed 16818
...F
Failure:
CascadedEagerLoadingTest#test_eager_association_loading_with_has_many_sti_and_subclasses [/home/yahonda/git/rails/activerecord/test/cases/associations/cascaded_eager_loading_test.rb:124]:
1 instead of 0 queries were executed.
Queries:
SHOW FULL FIELDS FROM `topics`.
Expected: 0
Actual: 1
bin/test test/cases/associations/cascaded_eager_loading_test.rb:119
Finished in 6.894609s, 0.5802 runs/s, 1.0153 assertions/s.
4 runs, 7 assertions, 1 failures, 0 errors, 0 skips
$
```
2019-03-26 02:51:03 +00:00
378b4fedb1
Add the `Mime::Type::InvalidMimeType` error in the default rescue_response:
...
- https://github.com/rails/rails/pull/35604 introduced a vulnerability fix
to raise an error in case the `HTTP_ACCEPT` headers contains malformated
mime type.
This will cause applications to throw a 500 if a User Agent sends an
invalid header.
This PR adds the `InvalidMimeType` in the default `rescue_responses` from
the ExceptionWrapper and will return a 406. I looked up the HTTP/1.1
RFC and it doesn't stand what should be returned when the UA
sends malformated mime type. Decided to get 406 as it seemed to be the
status the better suited for this.
2019-03-26 02:03:47 +01:00
b574d283e5
Add saved changes helpers for store accessors
2019-03-25 18:53:07 -04:00
61a39ffcc6
Add dirty methods for store accessors
2019-03-25 18:49:44 -04:00
e1865d70ec
Add default value `ActiveSupport::Deprecation.silenced` [ci skip]
2019-03-25 21:29:12 +09:00
15ca8ad0c1
Merge pull request #35740 from sharang-d/change-test-wording
...
Reword test names in credentials_test.rb
2019-03-25 17:03:16 +09:00
299c492a7a
Merge pull request #35741 from chiraggshah/patch-1
...
[ci skip] Fixed typo in CHANGELOG.md
2019-03-25 13:05:30 +05:30
20a8d2974d
[ci skip] Fixed typo
2019-03-25 12:49:58 +05:30
598ba6e419
Merge pull request #35739 from sharang-d/unique_by-changes
...
Format 'RETURNING' text in the docs [ci skip]
2019-03-25 12:46:24 +05:30
51171413bb
Reword test names in credentials_test.rb
2019-03-25 12:44:51 +05:30
2b205c8fa7
Format 'RETURNING' text in the docs [ci skip]
2019-03-25 12:37:28 +05:30
6a5c8b9199
Cleanup guide for configuring config.disable_sandbox and related changelog [ci skip] ( #35733 )
2019-03-25 03:14:51 +05:30
df51b75f12
Merge pull request #35732 from rails/webdrivers
...
Replace chromedriver-helper with webdrivers
2019-03-24 16:33:24 -05:00
b4ca05ea43
Merge pull request #35723 from sikachu/disable-sandbox-flag
...
Add config.disable_sandbox option to Rails console
2019-03-24 16:22:21 -05:00
895edbcf40
Use webdrivers instead of chromedriver-helper in new apps
2019-03-24 16:08:09 -05:00
2512f24ef4
Use webdrivers instead of chromedriver-helper for AV UJS tests
2019-03-24 16:05:30 -05:00
4ec4861452
Merge pull request #35690 from soartec-lab/update_guide_sending_log_messages
...
Add `unknown` method to list of methods to write current log [ci skip]
2019-03-24 15:29:02 +09:00
3cc4380f20
Merge pull request #35724 from soartec-lab/update_guide_raise_on_missing_translations_default
...
Add default `config.action_view.raise_on_missing_translations` [ci skip]
2019-03-24 14:11:54 +09:00
122853dc54
Merge pull request #35718 from y-yagi/add_secret_key_base_when_creating_new_credentials
...
Add `secret_key_base` when creating new credential file
2019-03-24 09:44:13 +09:00
0f8db2126d
[ci skip] Update doc for unnecessary #references
...
Update doc for #includes to clarify that #references is unnecessary when conditions are passed into #includes as a hash.
2019-03-23 13:46:10 -07:00
44316b60e2
Add default `config.action_view.raise_on_missing_translations` [ci skip]
2019-03-24 01:53:39 +09:00
ff7948b1c2
Avoid creating ActionText::RichText records unnecessarily
...
Assigning a has_one association for a persisted record saves the change immediately, so attempting to read a rich-text attribute on a persisted record without a corresponding ActionText::RichText would eagerly create one. Avoid assigning the rich text association to fix.
2019-03-23 10:04:48 -04:00
3acf5f71f0
Depend on Zeitwerk 1.4.2
2019-03-23 14:42:24 +01:00
b27105252b
Add config.disable_sandbox option to Rails console
...
A long-running `rails console --sandbox` could cause a database server
to become out-of-memory as it's holding on to changes that happen on the
database.
Given that it's common for Ruby on Rails application with huge
traffic to have separate write database and read database, we should
allow the developers to disable this sandbox option to prevent someone
from accidentally causing the Denial-of-Service on their server.
2019-03-23 19:31:03 +09:00
430b841951
Merge pull request #35683 from Kukunin/master
...
Bugfix: Fix false autosave for has_one :through association
2019-03-23 18:54:20 +09:00
5851ac69e1
Merge pull request #35719 from shailesh-kalamkar/fix-change-log-typo
...
[ci skip] Fixed CHANGELOG typo
2019-03-22 21:08:35 -05:00
839328c700
[ci skip] Fixed typo
2019-03-23 07:22:52 +05:30
d0334b8f01
Update comment for how secret key is calculated
...
This updates the comment to reflect how the secret key is generated
since 4c743587adFixes #35717
2019-03-22 17:59:41 -07:00
0e9e59953f
Add `secret_key_base` when creating new credential file
...
Since `secret_key_base` is expected to be included in credential file,
`secret_key_base` should be included even if re-create the file. This is
the same behavior as creating a new app.
When env is specified, it may be unnecessary, so I added it only when not
specifying env.
2019-03-23 09:07:57 +09:00
56723964ce
Merge pull request #35713 from gmcgibbon/drop_nsec_in_job_argument_assertions
...
Drop microseconds in job argument assertions
2019-03-22 17:38:37 -04:00
7f038621df
Drop microseconds in job argument assertions
2019-03-22 17:04:56 -04:00
b27885c6c2
Merge pull request #35715 from jhawthorn/changelog_for_cves_6_0
...
Update CHANGELOGs for 6.0.0.beta3 release
2019-03-22 13:43:56 -07:00
5c2d695993
Update CHANGELOGs for 6.0.0.beta3 release
2019-03-22 13:13:01 -07:00
Ryuta Kamizono