Commit Graph

259 Commits

Author SHA1 Message Date
David Heinemeier Hansson 8e413262d6 WordNet not Nets
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 01:11:41 +00:00
David Heinemeier Hansson 1f94ac2c45 Touched up wording on the new recommendation stuff for generate models
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 01:08:51 +00:00
David Heinemeier Hansson 4ff4afa579 Added protection for creating a model through the generators with a name of an existing class, like Thread or Date. It'll even offer you a synonym using wordnet.princeton.edu as a look-up. No, I'm not kidding :) [Florian Gross]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 00:52:34 +00:00
David Heinemeier Hansson 4ce65f434a Ignore doc and pkg directories
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 00:15:27 +00:00
David Heinemeier Hansson d9c0a37f37 Releasing Rails 0.9.2
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 23:56:17 +00:00
David Heinemeier Hansson ab4c640b96 Added scope option to validation_uniqueness #349 [Kent Sibilev]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 23:40:44 +00:00
David Heinemeier Hansson d834b65b54 Added allow_nil options to validates_inclusion_of so that validation is only triggered if the attribute is not nil [what-a-day]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 23:25:45 +00:00
David Heinemeier Hansson 2ec81dcd28 Added work-around for PostgreSQL and the problem of getting fixtures to be created from id 1 on each test case. This only works for auto-incrementing primary keys called "id" for now #359 [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 23:09:30 +00:00
David Heinemeier Hansson d91405a415 Fixed UrlHelper#link_to_unless so it doesn't care if the id is a string or fixnum [zenspider]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 22:50:44 +00:00
David Heinemeier Hansson a89e36a22a You should redirect externally on the default action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 14:38:36 +00:00
David Heinemeier Hansson 822742164e Forgot to include the new session module
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 14:30:29 +00:00
David Heinemeier Hansson edbeec91ba Fixed mixin test and fixtures to work with postgresql #353 [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 14:14:45 +00:00
David Heinemeier Hansson 4b229d1034 Added Base#clear_association_cache to empty all the cached associations #347 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:54:44 +00:00
David Heinemeier Hansson 951c9426ad Added search through session to clear out association caches at the end of each request. This makes it possible to place Active Record objects in the session without worrying about stale data in the associations (the main object is still subject to caching, naturally) #347 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:53:47 +00:00
David Heinemeier Hansson a04b1f3d8a Added more informative exception when using helper :some_helper and the helper requires another file that fails, you'll get an error message tells you what file actually failed to load, rather than falling back on assuming it was the helper file itself #346 [dblack]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:44:16 +00:00
David Heinemeier Hansson f408fcd610 Added more informative exceptions in establish_connection #356 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:39:19 +00:00
David Heinemeier Hansson dbe8a26d7d Fixed that options[:counter_sql] was overwritten with interpolated sql rather than original sql #355 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:35:42 +00:00
David Heinemeier Hansson 91eaeb2803 Fixed that overriding an attribute's accessor would be disregarded by add_on_empty and add_on_boundary_breaking because they simply used the attributes[] hash instead of checking for @base.respond_to?(attr.to_s). [Marten]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:27:20 +00:00
David Heinemeier Hansson 78c6de9daf Fixed CTRL-C exists from the Breakpointer to be a clean affair without error dumping [Kent Sibilev]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:17:35 +00:00
David Heinemeier Hansson ebf2b12b07 Fixed "rake stats" to work with sub-directories in models and controllers and to report the code to test ration [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:08:26 +00:00
David Heinemeier Hansson dcc486805e Fixed that Base.table_name would expect a parameter when used in has_and_belongs_to_many joins [Anna Lissa Cruz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:00:15 +00:00
David Heinemeier Hansson 3f3cbb51dc The dispatcher should reload the associations AFTER clearing the inheritable variables, not before, or callbacks and others wont work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 02:00:41 +00:00
David Heinemeier Hansson 44819b4717 Fixed that nested transactions now work by letting the outer most transaction have the responsibilty of starting and rolling back the transaction. If any of the inner transactions swallow the exception raised, though, the transaction will not be rolled back. So always let the transaction bubble up even when you've dealt with local issues. Closes #231 and #340.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 00:48:24 +00:00
David Heinemeier Hansson 58f2bd0cfc Fixed validates_{confirmation,acceptance}_of to only happen when the virtual attributes are not nil #348 [dpiddy@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-21 23:41:07 +00:00
David Heinemeier Hansson 913f229e21 Added acts instead of mixins
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-21 13:58:04 +00:00
David Heinemeier Hansson 1eb751a021 Fixed regression with Base#reset_session that wouldn't use the the DEFAULT_SESSION_OPTIONS [adam@the-kramers.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-21 10:47:02 +00:00
David Heinemeier Hansson 506fd8ea57 Fixed error rendering of rxml documents to not just swallow the exception and return 0 (still not guessing the right line, but hey)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-21 02:05:12 +00:00
David Heinemeier Hansson 6ea54a630a Deal with associated classes that doesnt reside in their own files
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-20 21:48:38 +00:00
David Heinemeier Hansson 2e3106b617 Checked in the proper version of const_missing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-20 16:57:56 +00:00
David Heinemeier Hansson 5df6128bfd Forgot a "or" in Inflector
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-20 16:55:26 +00:00
David Heinemeier Hansson 3e5a880987 Switched strategy on the id_before_type_cast problem and just did an explicit method so postgresql wouldnt choke on id is null
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-20 13:32:09 +00:00
David Heinemeier Hansson 8537d5eb93 Added a require_association hook on const_missing that makes it possible to use any model class without requiring it first. Added that Active Record associations are now reloaded instead of cleared to work with the new const_missing hook in Active Record.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-20 13:21:01 +00:00
David Heinemeier Hansson ef489ca2ad Pulling attributes_from_column_definition should set the primary id to nil instead of not at all
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 23:11:06 +00:00
David Heinemeier Hansson 2f26785425 Scrap that
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 22:49:56 +00:00
David Heinemeier Hansson c489b87d9d Dont define respond_to? lookups for primary key
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 22:40:09 +00:00
David Heinemeier Hansson dad37cfafa FormHelper should only use *_before_type_cast if they available on the model
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 16:39:56 +00:00
David Heinemeier Hansson 69cb942d9b Changed the interface on AbstractAdapter to require that adapters return the number of affected rows on delete and update operations. Added that Base.update_all and Base.delete_all return an integer of the number of affected rows #341
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 16:21:55 +00:00
David Heinemeier Hansson 88192b9b1b Added that query benchmarking will only happen if its going to be logged anyway #344
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 14:24:16 +00:00
David Heinemeier Hansson 830c561e71 Reworded a few doc things for better comprehension [dblack]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 14:17:28 +00:00
David Heinemeier Hansson 0f478181e4 Fixed small doc bug [dblack]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 13:59:23 +00:00
David Heinemeier Hansson c8b24915c6 Fixed that textilize and markdown would instantiate their engines even on empty strings. This also fixes #333 [Ulysses]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 13:33:51 +00:00
David Heinemeier Hansson b586c7a97a Added graceful handling of an inaccessible log file by redirecting output to STDERR with a warning #330 [rainmkr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 13:29:39 +00:00
David Heinemeier Hansson 3b56b85906 Updated the documentation #329 [rainmkr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@222 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 13:10:18 +00:00
David Heinemeier Hansson 356f16006b Added higher_item and lower_item as public methods for acts_as_list #342 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 13:01:47 +00:00
David Heinemeier Hansson eeae1eecb9 Added documentation for automatic layout inclusion #328 [Marcel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 12:56:31 +00:00
David Heinemeier Hansson d19b1810db Added support for a -h/--help parameter in the generator #331 [Ulysses]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@219 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 12:55:22 +00:00
David Heinemeier Hansson 01f05551c0 Added breakpoints to stand-alone Active Record, so we can use them in tests for AR
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@218 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:49:08 +00:00
David Heinemeier Hansson a2130c22d7 Set a high default salary within the validation range
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:44:59 +00:00
David Heinemeier Hansson 87b0d72fe6 Added Developer#salary for the type tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:41:34 +00:00
David Heinemeier Hansson 7b5ed66122 Added respondence to *_before_type_cast for all attributes to return their string-state before they were type casted by the column type. Added use of *_before_type_cast for all input and text fields.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:25:55 +00:00