mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
73,333 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

73333 Commits

Author SHA1 Message Date
David Heinemeier Hansson 670fa63342 Fixed that @request.remote_ip didn't work in the test environment #369 [Bruno Mattarollo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-31 16:47:08 +00:00
David Heinemeier Hansson 256d387159 Fixed quoting in validates_format_of that would allow some rules to pass regardless of input #390 [Dmitry V. Sabanin] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-31 16:42:25 +00:00
David Heinemeier Hansson 43f5ab93e0 Fixed that generated action_mailers doesnt need to require the action_mailer since thats already done in the environment #382 [Lucas Carlson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-31 16:38:24 +00:00
David Heinemeier Hansson 13273f7a55 Fixed broken transactions that were actually only running object-level and not db level transactions [andreas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 14:52:42 +00:00
David Heinemeier Hansson 50562c2a7e Restored thread safety to Active Record [andreas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@285 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 14:51:04 +00:00
David Heinemeier Hansson 3be52ef47c Transactions are now actually working on the database level on save, but thread safety is currently out the window. Andreas is working on it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 14:29:44 +00:00
David Heinemeier Hansson 26b7cb7506 Updated Rakefiles for the server move 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 00:26:14 +00:00
David Heinemeier Hansson 3d691ab390 Fixed dependency management to happen in a unified fashion for Active Record and Action Pack using the new Dependencies module. This means that the environment options needs to change. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 00:20:52 +00:00
David Heinemeier Hansson 7fcf07d632 Include as loaded regardless of success 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-30 00:12:39 +00:00
David Heinemeier Hansson fa1f5e062e Switch dispatcher to use the new shared Dependencies approach 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:26:20 +00:00
David Heinemeier Hansson 595a4a591b Rearranging dependencies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:19:37 +00:00
David Heinemeier Hansson 6b5df896fa git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2004-12-29 21:15:56 +00:00
David Heinemeier Hansson 4290267959 Moved support into Active Support 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:14:58 +00:00
David Heinemeier Hansson 84d5519b74 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2004-12-29 21:12:47 +00:00
David Heinemeier Hansson 8efa1513ed Moved support files into Active Support 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:09:59 +00:00
David Heinemeier Hansson 5d0f633239 Moved the cookies fix to cgi_ext 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:07:50 +00:00
David Heinemeier Hansson bd323b3c99 Moved support from both Action Pack and Active Record into a separate module called Active Support that can be included using svn:externals in both 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 21:03:21 +00:00
David Heinemeier Hansson 1b0da48fe9 Added documentation for using render_with_layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-29 13:36:27 +00:00
David Heinemeier Hansson 60de8c1108 Added Base.default_timezone accessor that determines whether to use Time.local (using :local) or Time.utc (using :utc) when pulling dates and times from the database. This is set to :local by default. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-28 17:30:17 +00:00
David Heinemeier Hansson 8a9b998b79 Fixed that the const_missing autoload assumes the requested constant is set by require_association and calls const_get to retrieve it. If require_association did not set the constant then const_get will call const_missing, resulting in an infinite loop #380 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-28 16:27:08 +00:00
David Heinemeier Hansson 4cd9c9561a Added the possibility for adapters to overwrite add_limit! to implement a different limiting scheme than "LIMIT X" used by MySQL, PostgreSQL, and SQLite. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-28 16:26:06 +00:00
David Heinemeier Hansson 3755816266 Added ActionMailer::Base.deliver_method = :test to the test environment so that mail objects are available in ActionMailer::Base.deliveries for functional testing. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 23:34:39 +00:00
David Heinemeier Hansson f6d2bc30fe Added ActionMailer::Base.raise_delivery_errors = false to the test environment as we checks will be performed against deliveries array instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 19:12:07 +00:00
David Heinemeier Hansson 00deaf6d56 Added :host and :protocol options to url_for and friends to redirect to another host and protocol than the current. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 18:59:24 +00:00
David Heinemeier Hansson 8e413262d6 WordNet not Nets 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 01:11:41 +00:00
David Heinemeier Hansson 1f94ac2c45 Touched up wording on the new recommendation stuff for generate models 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 01:08:51 +00:00
David Heinemeier Hansson 4ff4afa579 Added protection for creating a model through the generators with a name of an existing class, like Thread or Date. It'll even offer you a synonym using wordnet.princeton.edu as a look-up. No, I'm not kidding :) [Florian Gross] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 00:52:34 +00:00
David Heinemeier Hansson 4ce65f434a Ignore doc and pkg directories 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-23 00:15:27 +00:00
David Heinemeier Hansson d9c0a37f37 Releasing Rails 0.9.2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 23:56:17 +00:00
David Heinemeier Hansson ab4c640b96 Added scope option to validation_uniqueness #349 [Kent Sibilev] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 23:40:44 +00:00
David Heinemeier Hansson d834b65b54 Added allow_nil options to validates_inclusion_of so that validation is only triggered if the attribute is not nil [what-a-day] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 23:25:45 +00:00
David Heinemeier Hansson 2ec81dcd28 Added work-around for PostgreSQL and the problem of getting fixtures to be created from id 1 on each test case. This only works for auto-incrementing primary keys called "id" for now #359 [Scott Baron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 23:09:30 +00:00
David Heinemeier Hansson d91405a415 Fixed UrlHelper#link_to_unless so it doesn't care if the id is a string or fixnum [zenspider] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 22:50:44 +00:00
David Heinemeier Hansson a89e36a22a You should redirect externally on the default action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 14:38:36 +00:00
David Heinemeier Hansson 822742164e Forgot to include the new session module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 14:30:29 +00:00
David Heinemeier Hansson edbeec91ba Fixed mixin test and fixtures to work with postgresql #353 [Scott Baron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 14:14:45 +00:00
David Heinemeier Hansson 4b229d1034 Added Base#clear_association_cache to empty all the cached associations #347 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:54:44 +00:00
David Heinemeier Hansson 951c9426ad Added search through session to clear out association caches at the end of each request. This makes it possible to place Active Record objects in the session without worrying about stale data in the associations (the main object is still subject to caching, naturally) #347 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:53:47 +00:00
David Heinemeier Hansson a04b1f3d8a Added more informative exception when using helper :some_helper and the helper requires another file that fails, you'll get an error message tells you what file actually failed to load, rather than falling back on assuming it was the helper file itself #346 [dblack] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:44:16 +00:00
David Heinemeier Hansson f408fcd610 Added more informative exceptions in establish_connection #356 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:39:19 +00:00
David Heinemeier Hansson dbe8a26d7d Fixed that options[:counter_sql] was overwritten with interpolated sql rather than original sql #355 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:35:42 +00:00
David Heinemeier Hansson 91eaeb2803 Fixed that overriding an attribute's accessor would be disregarded by add_on_empty and add_on_boundary_breaking because they simply used the attributes[] hash instead of checking for @base.respond_to?(attr.to_s). [Marten] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:27:20 +00:00
David Heinemeier Hansson 78c6de9daf Fixed CTRL-C exists from the Breakpointer to be a clean affair without error dumping [Kent Sibilev] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:17:35 +00:00
David Heinemeier Hansson ebf2b12b07 Fixed "rake stats" to work with sub-directories in models and controllers and to report the code to test ration [Scott Baron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:08:26 +00:00
David Heinemeier Hansson dcc486805e Fixed that Base.table_name would expect a parameter when used in has_and_belongs_to_many joins [Anna Lissa Cruz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 13:00:15 +00:00
David Heinemeier Hansson 3f3cbb51dc The dispatcher should reload the associations AFTER clearing the inheritable variables, not before, or callbacks and others wont work 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 02:00:41 +00:00
David Heinemeier Hansson 44819b4717 Fixed that nested transactions now work by letting the outer most transaction have the responsibilty of starting and rolling back the transaction. If any of the inner transactions swallow the exception raised, though, the transaction will not be rolled back. So always let the transaction bubble up even when you've dealt with local issues. Closes #231 and #340. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-22 00:48:24 +00:00
David Heinemeier Hansson 58f2bd0cfc Fixed validates_{confirmation,acceptance}_of to only happen when the virtual attributes are not nil #348 [dpiddy@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-21 23:41:07 +00:00
David Heinemeier Hansson 913f229e21 Added acts instead of mixins 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-21 13:58:04 +00:00
David Heinemeier Hansson 1eb751a021 Fixed regression with Base#reset_session that wouldn't use the the DEFAULT_SESSION_OPTIONS [adam@the-kramers.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2004-12-21 10:47:02 +00:00