Commit Graph

78278 Commits

Author SHA1 Message Date
Rafael Mendonça França fd24cf1c5d
Return `false` when enqueuing a job is aborted 2020-10-30 00:25:31 +00:00
Rafael Mendonça França 6583895ebe
Remove deprecated `escape_whitelist` from `ActionView::Template::Handlers::ERB` 2020-10-30 00:25:30 +00:00
Rafael Mendonça França dafa49bb4c
Remove deprecated `find_all_anywhere` from `ActionView::Resolver` 2020-10-30 00:25:29 +00:00
Rafael Mendonça França db5a2dfe3e
Remove deprecated `formats` from `ActionView::Template::HTML` 2020-10-30 00:25:29 +00:00
Rafael Mendonça França 6124294684
Remove deprecated `formats` from `ActionView::Template::RawFile` 2020-10-30 00:25:28 +00:00
Rafael Mendonça França 217eb5dc4a
Remove deprecated `formats` from `ActionView::Template::Text` 2020-10-30 00:25:27 +00:00
Rafael Mendonça França 71904857d4
Remove deprecated `find_file` from `ActionView::PathSet` 2020-10-30 00:25:27 +00:00
Rafael Mendonça França b57e227f6d
Remove deprecated `rendered_format` from `ActionView::LookupContext` 2020-10-30 00:25:26 +00:00
Rafael Mendonça França 806e4874f5
Remove deprecated `find_file` from `ActionView::ViewPaths` 2020-10-30 00:25:25 +00:00
Rafael Mendonça França 469c4ccad7
Require that `ActionView::Base` subclasses implement `#compiled_method_container` 2020-10-30 00:25:24 +00:00
Rafael Mendonça França cd0c99c991
Make the arguments of ActionView::Base#initialize required 2020-10-30 00:25:24 +00:00
Rafael Mendonça França 05f234dbbd
Remove deprecated support to pass an object that is not a `ActionView::LookupContext` as the first argument in `ActionView::Base#initialize` 2020-10-30 00:25:23 +00:00
Rafael Mendonça França c3b08725a1
Remove deprecated `format` argument `ActionView::Base#initialize` 2020-10-30 00:25:22 +00:00
Rafael Mendonça França db82d4da62
Remove deprecated `ActionView::Template#refresh` 2020-10-30 00:25:21 +00:00
Rafael Mendonça França 9d2a0c903d
Remove deprecated `ActionView::Template#original_encoding` 2020-10-30 00:25:21 +00:00
Rafael Mendonça França d6575dc42e
Remove deprecated `ActionView::Template#variants` 2020-10-30 00:25:20 +00:00
Rafael Mendonça França 2a10775ac1
Remove deprecated `ActionView::Template#formats` 2020-10-30 00:25:19 +00:00
Rafael Mendonça França aa7d6f0c64
Remove deprecated `ActionView::Template#virtual_path=` 2020-10-30 00:25:19 +00:00
Rafael Mendonça França b88615e875
Remove deprecated `ActionView::Template#updated_at` 2020-10-30 00:25:18 +00:00
Rafael Mendonça França d25840eb49
Make `locals` argument required on `ActionView::Template#initialize` 2020-10-30 00:25:17 +00:00
Rafael Mendonça França 71ddfd78d4
Remove deprecated finalize_compiled_template_methods 2020-10-30 00:25:16 +00:00
Rafael Mendonça França 0de9560e3e
Remove deprecated support to calling `ActionView::ViewPaths#with_fallback` with a block 2020-10-30 00:25:16 +00:00
Rafael Mendonça França 2759addf2c
Remove deprecated support to passing absolute paths to `render template:` 2020-10-30 00:25:15 +00:00
Rafael Mendonça França d52d773946
Remove deprecated support to passing relative paths to `render file:` 2020-10-30 00:25:14 +00:00
Rafael Mendonça França 4d77dcad09
Remove support to template handlers that don't accept two arguments 2020-10-30 00:25:13 +00:00
Rafael Mendonça França 320e7f7c95
Remove deprecated pattern argument in `ActionView::Template::PathResolver` 2020-10-30 00:25:13 +00:00
Rafael Mendonça França 71f2f6ebc0
Make type a required argument in ActionView::Template::HTML#initialize 2020-10-30 00:25:12 +00:00
Rafael Mendonça França 5b8fe6c37e
Remove deprecated support to call private methods from object in some view helpers 2020-10-30 00:25:11 +00:00
Rafael Mendonça França 3e2552db89
Remove deprecated `ActionDispatch::Http::ParameterFilter` 2020-10-30 00:25:10 +00:00
Eugene Kenny 6e7147ecf3
Merge pull request #40488 from eugeneius/share_non_default_shards
Share connection pools for non-default shards
2020-10-30 00:21:44 +00:00
Eugene Kenny 12ce3e7723
Merge pull request #40478 from eugeneius/undeprecate_use_sha1_digests
Improve config.active_support.use_sha1_digests deprecation message
2020-10-30 00:10:29 +00:00
Eugene Kenny 348d6c624c Share connection pools for non-default shards
Unless `legacy_connection_handling` was set to `false`, only the default
shard's connection pools were shared during transactional tests.
2020-10-29 22:52:23 +00:00
Eugene Kenny 03d5fad310
Merge pull request #40487 from eugeneius/only_replace_existing_pools
Only replace existing pools in transactional tests
2020-10-29 22:36:15 +00:00
Rafael França f8d7ab5f3c
Merge pull request #39705 from Shopify/actioncontroller-testcase-parameters-fix
Fix the ActionController::TestCase#process parameters serialization
2020-10-29 17:43:32 -04:00
Rafael França 60546a0c23
Merge pull request #39718 from jonathanhefner/listen-on-fork
Listen on fork in EventedFileUpdateChecker
2020-10-29 17:39:13 -04:00
Eileen M. Uchitelle 2c327e64f9
Merge pull request #40486 from eileencodes/add-method-to-set-specific-connection
Implement `connecting_to` method
2020-10-29 17:31:02 -04:00
John Hawthorn ec645d00c4
Merge pull request #40485 from rails/revert-39497-render_with_invalid_options
Revert "Raise when calling render with invalid options"
2020-10-29 14:16:57 -07:00
Eugene Kenny 5c562a6351 Only replace existing pools in transactional tests
`setup_shared_connection_pool` replaces reading connection pools with
writing ones, so that replica reads work as they would in production.

If a shard doesn't have a reading connection we should skip it, since
adding one could lead to code that only works in the test environment.
2020-10-29 21:15:15 +00:00
eileencodes 231bcc7cd2
Implement `connecting_to` method
Sometimes you need to have a different default connection but aren't
calling the connection with a block. An example is booting a console in
`reading` mode. This adds the ability for a script to set a specific
connection on boot while preserving the behavior of `connected_to` for
application code.
2020-10-29 17:13:58 -04:00
Eugene Kenny 00e70666ed
Merge pull request #40368 from eugeneius/shard_test_transactions
Eagerly establish test transactions for shards
2020-10-29 21:11:37 +00:00
eileencodes 77087bbc15
Merge branch 'option_to_mute_multiple_database_yml_error' 2020-10-29 16:59:02 -04:00
Omri Gabay 43d83e96c9
Add option to mute multiple database yaml warning
Adds an option to silence the warning that database configurations can
throw when it's unparsable.
2020-10-29 16:57:57 -04:00
John Hawthorn e3130f1b84
Revert "Raise when calling render with invalid options" 2020-10-29 13:49:30 -07:00
Eileen M. Uchitelle a50333b51e
Merge pull request #40484 from eileencodes/add-docs-for-per-db-connection-switching
Add documentation for granular connection switching
2020-10-29 16:48:37 -04:00
eileencodes 315198f3da
Add documentation for granular connection switching
Implement docs for https://github.com/rails/rails/pull/40370
2020-10-29 16:48:15 -04:00
Eugene Kenny a03a2c4188 Improve use_sha1_digests deprecation message
We now provide the full setting that maintains the existing behaviour.
2020-10-29 18:46:21 +00:00
Jonathan Hefner 5f085fac74 Add GS guide § MVC and You [ci-skip]
Fixes #39920.
Resolves #38288.
Resolves #40040.

Co-Authored-By: Ryan Bigg <me@ryanbigg.com>
Co-Authored-By: Eileen M. Uchitelle <eileencodes@gmail.com>
Co-Authored-By: Petrik de Heus <petrik@deheus.net>
Co-Authored-By: Tasos Latsas <tlatsas2000@gmail.com>
2020-10-29 10:11:42 -05:00
Jonathan Hefner 428a95170c Edit GS guide § Setting the Application Home Page [ci-skip]
Fixes #39920.
Resolves #38288.
Resolves #40039.
Resolves #40326.

Co-Authored-By: Ryan Bigg <me@ryanbigg.com>
Co-Authored-By: Eileen M. Uchitelle <eileencodes@gmail.com>
Co-Authored-By: Petrik de Heus <petrik@deheus.net>
Co-Authored-By: Tasos Latsas <tlatsas2000@gmail.com>
Co-Authored-By: Ian Robinson <ian@ianrobinson.net>
2020-10-29 10:11:19 -05:00
Jonathan Hefner 3e182a2d4d Edit GS guide § Say "Hello", Rails [ci-skip]
Resolves #40326.

Co-Authored-By: Ian Robinson <ian@ianrobinson.net>
2020-10-29 10:10:58 -05:00
Jonathan Hefner fce160f00e Edit Getting Started guide introductory sections [ci-skip] 2020-10-29 10:10:41 -05:00