mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
20,411 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

20411 Commits

Author SHA1 Message Date
Neeraj Singh 27d0d4fffd while defining callbacks option :rescuable => true 
can be passed. There were no tests for this case.

This patch adds a test for :rescuable => true
option.
 2010-12-29 05:32:23 +08:00
Vijay Dev dd166c60c4 fixed incorrect spacing from 9836854671 2010-12-29 02:09:47 +05:30
Vijay Dev 9836854671 fixed examples & minor typos 2010-12-29 02:07:22 +05:30
Xavier Noria 6b43a3a627 complete revision of the Contributing to Ruby on Rails guide 
* adds instructions for PostgreSQL
* adds references to mysql2 here and there
* puts documentation contributions on par with code contributions
* adds a section about Rails Contributors
* documents C dependencies for Nokogiri and the database libs
* everything double-checked and revised step by step
* adds a section about warnings in the test suite
* removes section about the Rails wiki
* title and filename renamed
* overall rewording
 2010-12-28 20:36:42 +01:00
Santiago Pastorino eb2ebe7680 Simplify inspect implementation 
After 304d38c053 we don't need the
new_record? check anymore.
 2010-12-28 15:45:35 -02:00
Karel Minarik 9f75545e5d Added information about invoking migrations in non-default environments to NOTE box in the "Getting Started" guide 
Reason: When the guide already mentions "default environment", I think it is more then appropriate to tell the whole story.
 2010-12-28 17:30:13 +01:00
Karel Minarik cb4b5c8ad3 Adding information and link to guide on customizing generators into "Getting Started" guide. 2010-12-28 16:38:50 +01:00
Santiago Pastorino 304d38c053 Allow primary_key to be an attribute when the model is a new record 2010-12-28 10:11:27 -02:00
Karel Minarik 8031b7e42b Fixed incorrect instructions for calling the `rails` command explicitely in the "Getting Started" guide 2010-12-28 10:25:55 +01:00
Karel Minarik e2c2c2983a Added TIP box with information about the `--database` switch for the application generator in the "Getting Started" guide 2010-12-28 09:25:18 +01:00
Karel Minarik 8e8c13ab1e Fixed incorrect command for displaying options for new application Generator in Getting Started guide 2010-12-28 08:45:09 +01:00
Ryan Bigg bb99c944d3 There's a couple -> There are a couple 2010-12-28 17:32:41 +10:00
Ryan Bigg 777a1f125d Init guide: begin down the rabbit warren that is active_record/railtie 2010-12-28 16:01:16 +10:00
Ryan Bigg 591c011238 Init: finish coverage of railties/lib/rails.rb 2010-12-28 15:10:13 +10:00
Ryan Bigg 8447754343 init guide: Cover the action_dispatch/railtie require from rails.rb 2010-12-28 15:06:26 +10:00
Ryan Bigg 02bb7e9b98 Remove old initialization guide text. Too much has changed for all of this to be useful. 2010-12-28 14:22:42 +10:00
Ryan Bigg 5196333d6c init guide: cover active_support/railtie.rb 2010-12-28 14:19:49 +10:00
Ryan Bigg 61e6a9f9d4 Init guide: Segue between rails/version and active_support/railtie requires 2010-12-28 14:19:05 +10:00
Ryan Bigg 0dd5433b98 Cover the inherited method from Rails::Railtie being used when I18n::Railtie is loaded. 2010-12-28 14:13:43 +10:00
Ryan Bigg 6777b7a886 Init guide: finish covering the process of the i18n_railtie.rb file. 2010-12-28 14:04:19 +10:00
Ryan Bigg 7b7537317c init guide: active_support/railtie does not require itself, actually requires i18n_railtie 2010-12-28 14:04:02 +10:00
Ryan Bigg 2f57353023 Init guide: finish covering initializers for i18n_railtie, moving on to covering after_initialize 2010-12-28 13:23:50 +10:00
Ryan Bigg 01febdadea init guide: active_support/inflector/methods is loaded by active_support/autoload first. 2010-12-28 13:22:28 +10:00
Aaron Patterson 897b56bb2f I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. 2010-12-27 12:47:30 -07:00
José Valim ecc83c1e6e Clean up PathSet. 2010-12-27 10:15:54 +01:00
Ryan Bigg 62dd85cc83 Init guide: cover Railtie::Configuration and begin to cover the Initializer class and friends. 2010-12-27 19:14:44 +10:00
José Valim 6b099975fa No need to symbolize these. 2010-12-27 09:30:36 +01:00
José Valim 51a7d9acdd Final tidy up on templates inheritance. 2010-12-27 09:14:13 +01:00
wycats e03e1fdbc8 Speed up template inheritance and remove template inheritance option 2010-12-26 23:56:09 -08:00
wycats 7c568fda6b A bunch of cleanup on the inherited template patch 2010-12-26 23:44:51 -08:00
artemave 6c5a3bb312 all tests pass 2010-12-26 22:32:15 -08:00
artemave ce21ea7832 #948 make template inheritance optional 2010-12-26 22:32:15 -08:00
artemave ddd85ef9c6 #948 template_inheritance 2010-12-26 22:32:15 -08:00
Aaron Patterson 9bac649fa4 try not to make so many funcalls 2010-12-26 20:22:13 -07:00
Aaron Patterson 67da590979 make our hash of klasses and ids actually have classes for keys 2010-12-26 20:15:09 -07:00
Ryan Bigg a78e5bcfe4 Init guide: Cover the config variable set up which is referenced in i18n_railtie 2010-12-27 13:02:51 +10:00
Aaron Patterson 7e91ad3f89 stop calling deprecated apis 2010-12-26 19:56:18 -07:00
Jon Leighton 9f5c18ce07 Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst other things 2010-12-26 16:27:12 -07:00
Xavier Noria 57420dffb6 small rewording of my entry in the credits 2010-12-26 21:27:00 +01:00
Xavier Noria 71775807c1 no docs credits are written in first person, thanks to Vijay Dev for spotting this 2010-12-26 21:15:33 +01:00
Jon Leighton b0498372a1 Add a HasAssociation module for common code for has_* associations 2010-12-26 19:38:04 +00:00
Jon Leighton 0c272471fe Remove AssociationProxy#dependent? - it's badly named and only used in one place 2010-12-26 19:38:04 +00:00
Jon Leighton e8ada11aac Associations: DRY up the code which is generating conditions, and make it all use arel rather than SQL strings 2010-12-26 19:38:04 +00:00
Jon Leighton f2230c06ed Fix dodgy tests which were effectively asserting nil == nil 2010-12-26 19:38:04 +00:00
Jon Leighton 7021b6b851 Remove custom_select param from construct_select, as it isn't used 2010-12-26 19:38:04 +00:00
Jon Leighton d7a659334c Remove construct_from from ThroughAssociationScope - it's not called from anywhere 2010-12-26 19:38:04 +00:00
Jon Leighton 93861d19e3 Set the create scope to an empty hash in ThroughAssociationScope. For reasoning please see the inline code comments. 2010-12-26 18:46:58 +00:00
Jon Leighton ac67eee4e6 Use conditionals and implicit returns rather than explicit returns and postfix ifs (it's easier to read) 2010-12-26 18:46:58 +00:00
Jon Leighton 739ea1fbfe Remove has_cached_counter? and cached_counter_attribute_name from HasManyThroughAssociation, as the exact same methods are inherited from HasManyAssociation 2010-12-26 18:46:58 +00:00
Jon Leighton 99db97a322 Remove pointless use of 'private' 2010-12-26 18:46:58 +00:00