mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
72,872 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

5587 Commits

Author SHA1 Message Date
Alex Kitchens 44161582d5 [ci skip] Add 6.0 Release Notes for Active Record 2019-04-08 07:18:50 -05:00
प्रथमेश Sonpatki 808c589fd8
The default value without loading railtie is false [ci skip] (#35881) 
See https://github.com/rails/rails/pull/35873#issuecomment-480333333
for reference

[Prathamesh Sonpatki, bogdanvlviv]
 2019-04-05 22:13:03 +05:30
Eileen M. Uchitelle 8c6fedffa1
Merge pull request #35873 from prathamesh-sonpatki/enqueuing-fixes 
Fix the deprecation warning about `config.active_job.return_false_on_aborted_enqueue`
 2019-04-05 11:45:48 -04:00
प्रथमेश Sonpatki a8328f61b6
Add Active Job release notes [ci skip] (#35872) 2019-04-05 15:42:01 +05:30
Prathamesh Sonpatki c35f7b5115
Fix the deprecation warning about `config.active_job.return_false_on_aborted_enqueue` 
- It will return false in Rails 6.1 not 6.0. Also fixed the default
  value which is true for new applications.
 2019-04-05 15:40:34 +05:30
Edward Rudd 1b645333bc fix typo in the guides (use Rails instead of rails) 2019-04-04 17:58:37 -04:00
Sharang Dashputre f154d5b43d Add documentation for 'after_save_commit' [ci skip] 2019-04-05 01:37:04 +05:30
Edward Rudd 90a8ce6450 add documentation about variants 2019-04-03 18:10:09 -04:00
Tim Wade af56c5c1c6 [skip ci] Add examples for has_{one,many} :through :source and :source_type (#35612) 
* Add example for has_many :through source/source_type

* Add example for has_one :through source/source_type
 2019-04-03 13:05:20 -04:00
Ryuta Kamizono 96f0114e08 Use official database name [ci skip] 
* s/Postgres/PostgreSQL/
* s/MYSQL/MySQL/, s/Mysql/MySQL/
* s/Sqlite/SQLite/

Replaced all newly added them after 6089b31.
 2019-04-03 13:08:54 +09:00
soartec-lab e27a511b66 Fixed description of the `cache_key_with_version` method [ci skip] 2019-04-03 09:46:29 +09:00
Sharang Dashputre 771973c13d url -> URL where apt except inside actionpack/ 2019-04-01 22:56:35 +05:30
Sharang Dashputre 4f5949cf9f url -> URL in Action Cable guide [ci skip] 2019-04-01 11:57:23 +05:30
Ryan Castner 6d488a22d3 feat(js): Dynamic ActionCable URL (#35579) 
* Failing test case

* feat: Dynamic Url Generation

Change createWebSocketURL to be a closure that allows url to be evaluated at the time the webSocket is established

* refactor: createWebSocketURL to Consumer, remove need for closure

Move initial call to createWebSocketURL in createConsumer

* docs: Add documentation for dynamic url and string args to createConsumer

Co-Authored-By: rmacklin <rmacklin@users.noreply.github.com>

[Ryan Castner, rmacklin]
 2019-03-31 19:41:12 +02:00
प्रथमेश Sonpatki 360ff0a593
Merge pull request #35797 from abhaynikam/35752-update-migration-doc-column-identifier 
[ci skip] Updated docs to reflect index: true option not available as column modifier
 2019-03-30 10:35:28 +05:30
Abhay Nikam 1d5a6a3d8c [ci skip] Add ActiveRecord::Relation#extract_associated method to the active_record_querying.md 2019-03-30 10:14:54 +05:30
Abhay Nikam 098d857fbf [ci skip] Updated docs to reflect index: true option not available as column modifier 2019-03-30 09:12:56 +05:30
Rafael França 8638c7a643
Merge pull request #35789 from prathamesh-sonpatki/customize-full-message 
Rename `i18n_full_message` config option to `i18n_customize_full_message`
 2019-03-29 13:27:42 -04:00
प्रथमेश Sonpatki 7e45911a34
Add Active Model release notes for Rails 6 [ci skip] (#35790) 2019-03-29 22:22:56 +05:30
Prathamesh Sonpatki d8ba2f7c56
Rename `i18n_full_message` config option to `i18n_customize_full_message` 
- I feel `i18n_customize_full_messages` explains the meaning of the
  config better.
- Followup of https://github.com/rails/rails/pull/32956
 2019-03-29 21:38:48 +05:30
George Claghorn da2c92377c Add load hook for ActiveStorage::Attachment 2019-03-28 18:52:02 -04:00
Shailesh Kalamkar fbb9a3fc01 [ci skip] Fixed testing guides typo `fourty` -> `forty` 2019-03-28 09:41:04 +05:30
Ken Greeff 00690b27e5 Schema version documentation (#35762) 
* Update active_record_migrations.md

* Change year to match others

[Ken Greeff + Rafael Mendonça França]
 2019-03-26 20:57:33 -04:00
Prathamesh Sonpatki d2f0cb1615
Remove useless = [ci skip] 2019-03-26 23:48:20 +05:30
Sergio 3c7ab1a45a
Spelling error 2019-03-26 02:04:04 -06:00
soartec-lab e1865d70ec Add default value `ActiveSupport::Deprecation.silenced` [ci skip] 2019-03-25 21:29:12 +09:00
Vipul A M 6a5c8b9199
Cleanup guide for configuring config.disable_sandbox and related changelog [ci skip] (#35733) 2019-03-25 03:14:51 +05:30
Guillermo Iguaran b4ca05ea43
Merge pull request #35723 from sikachu/disable-sandbox-flag 
Add config.disable_sandbox option to Rails console
 2019-03-24 16:22:21 -05:00
Ryuta Kamizono 4ec4861452
Merge pull request #35690 from soartec-lab/update_guide_sending_log_messages 
Add `unknown` method to list of methods to write current log [ci skip]
 2019-03-24 15:29:02 +09:00
soartec-lab 44316b60e2 Add default `config.action_view.raise_on_missing_translations` [ci skip] 2019-03-24 01:53:39 +09:00
Prem Sichanugrist b27105252b Add config.disable_sandbox option to Rails console 
A long-running `rails console --sandbox` could cause a database server
to become out-of-memory as it's holding on to changes that happen on the
database.

Given that it's common for Ruby on Rails application with huge
traffic to have separate write database and read database, we should
allow the developers to disable this sandbox option to prevent someone
from accidentally causing the Denial-of-Service on their server.
 2019-03-23 19:31:03 +09:00
Ali Ibrahim 7237c7be74 Update instrumentation guides w/optional block 2019-03-22 13:20:32 -04:00
Matt Yoho f41825809c Add Relation#annotate for SQL commenting 
This patch has two main portions:

1. Add SQL comment support to Arel via Arel::Nodes::Comment.
2. Implement a Relation#annotate method on top of that.

== Adding SQL comment support

Adds a new Arel::Nodes::Comment node that represents an optional SQL
comment and teachers the relevant visitors how to handle it.

Comment nodes may be added to the basic CRUD statement nodes and set
through any of the four (Select|Insert|Update|Delete)Manager objects.

For example:

    manager = Arel::UpdateManager.new
    manager.table table
    manager.comment("annotation")
    manager.to_sql # UPDATE "users" /* annotation */

This new node type will be used by ActiveRecord::Relation to enable
query annotation via SQL comments.

== Implementing the Relation#annotate method

Implements `ActiveRecord::Relation#annotate`, which accepts a comment
string that will be appeneded to any queries generated by the relation.

Some examples:

    relation = Post.where(id: 123).annotate("metadata string")
    relation.first
    # SELECT "posts".* FROM "posts" WHERE "posts"."id" = 123
    # LIMIT 1 /* metadata string */

    class Tag < ActiveRecord::Base
      scope :foo_annotated, -> { annotate("foo") }
    end
    Tag.foo_annotated.annotate("bar").first
    # SELECT "tags".* FROM "tags" LIMIT 1 /* foo */ /* bar */

Also wires up the plumbing so this works with `#update_all` and
`#delete_all` as well.

This feature is useful for instrumentation and general analysis of
queries generated at runtime.
 2019-03-21 20:30:56 -07:00
soartec-lab e1e6b18e95 Add `unknown` method to list of methods to write current log [ci skip] 2019-03-21 23:49:53 +09:00
bogdanvlviv f8554e250c
Add mention about `process_middleware.action_dispatch` in the guide [ci skip] 
We added ActiveSupport::Notifications instrumentation of the processing of each middleware in the stack,
See 04ae0b0b5e.
 2019-03-20 05:20:15 +00:00
Nicholas La Roux 49f4625b70
Revert "Revert "Remove `javascripts` and `javascript_engine` options for generators"" 2019-03-20 09:48:51 +09:00
Nicholas La Roux d82839b0ee
Revert "Remove `javascripts` and `javascript_engine` options for generators" 2019-03-19 08:22:07 +09:00
प्रथमेश Sonpatki 0e94a513fe
Added release notes for changes in Railties [ci skip] (#35622) 
[Alex Kitchens, Prathamesh Sonpatki]
 2019-03-18 22:41:53 +05:30
Ryuta Kamizono 304d82597b Add `:reselect` and `:optimizer_hints` to the list of finder methods 
These are introduced after Rails 6.0.0 beta2.

[ci skip]
 2019-03-18 01:55:17 +09:00
Ryuta Kamizono 6486f80d3a `ActiveRecord::Result#to_hash` has been renamed to `to_a` [ci skip] 
See #33912.
 2019-03-17 03:41:12 +09:00
Vipul A M 7ed1302cd2
Merge pull request #35530 from Rodrigora/patch-1 
Add note about has_many associations callbacks [ci skip]
 2019-03-12 16:09:04 +05:30
Rodrigo 7515afcbbd Add note about has_many associations callbacks [ci skip] 
Add a note explaining when the has_many associations callbacks will be called or not.
 2019-03-12 10:28:31 +00:00
Kasper Timm Hansen 3a42c2305e
Merge pull request #34955 from bogdanvlviv/follow-up-33962 
Add `config.credentials.content_path` and `config.credentials.key_path` to the guide
 2019-03-11 21:08:20 +01:00
Shailesh Kalamkar 4a39a8da2f [ci skip] Removed extra hyphens 2019-03-11 19:31:36 +05:30
Prathamesh Sonpatki 3b953d9698
Add example of the output of `rails routes --expanded` in the routing guide [ci skip] 
- Instead of the note at the end, added an example of how the output
  looks by using the expanded switch.
 2019-03-11 17:46:30 +05:30
Abhay Nikam 027e492b6f Fix links in gemspec and docs from http to https. 2019-03-09 19:42:35 +05:30
Ryuta Kamizono b7fa01bb2f
Merge pull request #35529 from abhaynikam/35492-follow-up-to-updates-links-to-https 
Updated links from http to https in guides, docs, etc
 2019-03-09 20:49:27 +09:00
Abhay Nikam 476abd403b Updated links from http to https in guides, docs, etc 2019-03-09 16:43:47 +05:30
Shailesh Kalamkar 70192cec42 [ci skip] Minor documentation fixes for consistency 2019-03-09 12:15:00 +05:30
Sean Abrahams 6ef90c40f2 Guides: Fix parent class of model test example (#35065) 
* Fix parent class of model test example
* include ActiveJob::TestHelper

[ci skip]
 2019-03-09 11:24:48 +05:30