be211227a0
Remove deprecated `#to_default_s` from `Array`, `Date`, `DateTime` and `Time`
2024-05-01 18:45:41 +00:00
c33e2d2e49
Remove deprecated support to passing `Dalli::Client` instances to `MemCacheStore`
2024-05-01 18:45:40 +00:00
21f38d3d40
Remove deprecated `config.active_support.use_rfc4122_namespaced_uuids`
2024-05-01 18:45:37 +00:00
e73e67ee99
Remove deprecated `config.active_support.remove_deprecated_time_with_zone_name`
2024-05-01 18:44:53 +00:00
0e6859a237
Remove deprecated `config.active_support.disable_to_s_conversion`
2024-05-01 18:44:52 +00:00
c4fdfc55fa
Remove deprecated support to bolding log text with positional boolean in `ActiveSupport::LogSubscriber#color`
2024-05-01 18:44:51 +00:00
75981ade29
Remove deprecated constants `ActiveSupport::LogSubscriber::CLEAR` and `ActiveSupport::LogSubscriber::BOLD`
2024-05-01 18:44:50 +00:00
38bfbcfbea
Remove deprecated support for `config.active_support.cache_format_version = 6.1`
2024-05-01 18:44:49 +00:00
a3d6a9f5fc
Remove deprecated `:pool_size` and `:pool_timeout` options for the cache storage
2024-05-01 18:44:45 +00:00
b1b2c6d59c
Remove deprecated support for the pre-Ruby 2.4 behavior of `to_time`
...
When `to_time_preserves_timezone` was set to `false`, `to_time`
would return a `Time` object with local timezone. This behavior
has been removed.
2024-05-01 18:44:31 +00:00
0cf8444d61
Remove deprecated `config.active_storage.silence_invalid_content_types_warning`
2024-05-01 18:44:30 +00:00
b06252e2a7
Remove deprecated `config.active_storage.replace_on_assign_to_many`
2024-05-01 18:44:29 +00:00
cf64895067
Merge pull request #50744 from takatea/fix-docs-form_for-to-form_with-in-form_helper
...
docs: Update FormHelper comments to use `form_with` instead of `form_for` [ci skip]
2024-05-01 12:57:11 -04:00
013667fa4e
docs: Update FormHelper comments to use `form_with` instead of `form_for`
...
This commit updates the comments in ActionView::Helpers::FormHelper, replacing instances of `form_for` with `form_with` as the recommended approach. The Rails guide has already documented the usage of `form_with` on the form_helpers page.
Ref: https://guides.rubyonrails.org/form_helpers.html
Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>
2024-05-01 12:39:41 -04:00
cbbc64788a
Avoid seed data execution in CI by replacing `db:setup` with `db:test:prepare`
2024-05-01 18:20:19 +02:00
61090b1f3f
Add rake guides:lint task to raise error on broken anchor links
...
Co-authored-by: zzak <zzakscott@gmail.com>
2024-05-01 17:29:35 +05:30
325c04c1af
Merge pull request #51693 from fatkodima/assertionless-tests
...
Enable raising for assertionless tests for internal framework tests
2024-04-30 20:43:33 -03:00
b7d1ff71b9
Merge pull request #51671 from akhilgkrishnan/update-gh-action-versions
...
Upgrade the docker-login and checkout action versions
2024-04-30 20:34:56 -03:00
eb84ca3546
Merge pull request #51698 from zzak/note-docs-preview
...
Note docs preview
2024-04-30 20:31:58 -03:00
702638291c
Fix tests without assertions in the framework
2024-04-30 23:29:30 +00:00
6904f03e5f
Ignore tarball from rake preview_docs
2024-05-01 08:05:42 +09:00
c8967521e5
Document buildkite/docs-preview pipeline
2024-05-01 08:05:36 +09:00
90b3f57f17
Merge pull request #51694 from Shopify/deduplicate-watched-files-in-FileUpdateChecker
...
Deduplicate watched filenames in `FileUpdateChecker`
2024-04-30 19:15:21 -03:00
3e68225b72
Merge pull request #51685 from fffx/record_not_saved_doc
...
[Fix #51672 ] Update RDoc comments for ActiveRecord::RecordNotSaved [ci skip]
2024-04-30 19:08:07 -03:00
894f0797ad
Merge pull request #51696 from kaylareopelle/fix-anchor-links-in-instrumentation-guide
...
[ci skip] Replace — with : in instrumentation subheadings
2024-04-30 18:50:41 -03:00
6a6c7e64f5
Remove configuration to control what we do with tests without assertions
...
This is too much complexity for something low value. Let's just always
warn when a test doesn't have any assertions.
If people want to raise an error or ignore them, they can do so by
overriding `Warning.warn`.
2024-04-30 21:43:54 +00:00
64ab211892
Revert "Rails 8 will target Ruby 3.3+ only for new apps"
...
This reverts commit c78a6fa097
2024-04-30 21:35:16 +00:00
d59d11903c
Replace — with : in instrumentation subheadings
...
When — is used in a subtitle, the anchor links use -%E2%80%94-
instead of —. This prevents the browser jumping to the anchor link.
Replacing — with : fixes the problem.
Co-authored-by: James Bunch <fallwith@gmail.com>
2024-04-30 14:27:06 -07:00
541681b2d9
Update Doc for ActiveRecord::RecordNotSaved to be consistent
2024-04-30 23:32:14 +03:00
2601415c8a
Merge pull request #51692 from Shopify/require-debug-prelude-in-gemfile-template
...
Add `require: "debug/prelude"` after `debug`'s Gemfile entry
2024-04-30 17:17:50 -03:00
3b5ab678fc
Deduplicate watched filenames in `FileUpdateChecker`
2024-04-30 18:23:11 +00:00
7254549dcd
Add `require: "debug/prelude"` after `debug`'s Gemfile entry
...
In https://github.com/ruby/debug/issues/797 , we found that requiring
`debug` automatically activates it, which could introduce runtime overhead
and cause memory bloat. And I think many users aren't aware of this and
could be taxed by this unnecessarily (e.g. having longer builds on CI).
Therefore, I propose to add `require: "debug/prelude"` after `debug`'s
Gemfile entry in the default Gemfile template. This way, users can
still use breakpoint methods like `debugger`, `binding.break`, and `binding.b`,
but the debugger won't be activated until a breakpoint is hit.
2024-04-30 18:59:33 +01:00
6a38d3ac6c
Merge pull request #51483 from JoeDupuis/add-date-text-decoder-postgresql-adapter
...
Add a Date decoder to the pg adapter
2024-04-30 13:32:07 +02:00
f963d4a7f2
Merge pull request #50487 from nubinary/fix/unneccesary-readonly-attributes-to-a
...
Remove unnecessary to_a conversion for readonly_attributes method call
2024-04-30 19:50:17 +09:00
35e3ff3667
Fix minor typo in `ActiveSupport::ProxyObject` deprecation logs ( #51688 )
2024-04-29 20:50:27 -07:00
2c88c80fc7
Add a Date decoder to the pg adapter to type cast dates
...
at the connection level
Fix #51448
Type cast columns of type `date` to ruby `Date` when running a raw
query through `ActiveRecord::Base.connection.select_all`.
2024-04-29 19:16:18 -07:00
cc7f0b0d4c
Add period to end of comment sentences in env templates for consistency ( #51677 )
...
Add periods to comments in development.rb.tt and test.rb.tt for consistency.
[ci skip]
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
2024-04-29 11:46:50 -03:00
258796693b
Merge pull request #51684 from fatkodima/raise-relation-with
...
Raise when a block is passed to `ActiveRecord::Relation#with`
2024-04-29 13:50:53 +02:00
127808841b
Remove unnecessary to_a conversion for readonly_attributes method call
2024-04-29 07:44:00 -04:00
74275accb8
Raise when a block is passed to `ActiveRecord::Relation#with`
2024-04-29 14:34:09 +03:00
36b7c1df9b
Merge pull request #51682 from Shopify/fix-active-support-test-case-loading-early
2024-04-29 12:56:04 +02:00
a94938f10c
Usage not common enough to warrant top-line recommendation
2024-04-28 17:23:36 -07:00
c78a6fa097
Rails 8 will target Ruby 3.3+ only for new apps
2024-04-28 17:20:48 -07:00
53a9923b35
No need to recommend spring any more as a common option
2024-04-28 17:16:52 -07:00
3fc58e52de
Fix ActiveSupport::TestCase being loaded too early
...
rails/rails@76966f9 implemented configuration to report assertionless tests. But the configuration causes ActiveSupport::TestCase to be loaded too early in the boot process. It causes issues when other engines define load hooks on :active_support_test_case because they are run immediately. Instead, we should wrap the configuration in a load hook so it gets set at the appropriate time.
2024-04-28 18:49:44 -04:00
d366a99bf3
Merge pull request #51680 from bensheldon/patch-1
2024-04-28 21:13:59 +02:00
20ef7c3b73
Update production.rb template to provide example to exclude healthcheck from force_ssl redirect
...
Instructions for disabling specific endpoints from http-to-https redirects live in the SSL middleware:
fc4407eed0/actionpack/lib/action_dispatch/middleware/ssl.rb (L20)fc4407eed0/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt (L110)
2024-04-28 08:46:41 -07:00
fc4407eed0
Merge pull request #51655 from fatkodima/fix-cpk-references-count
...
Fix count queries on `includes+references` for models with composite primary keys
2024-04-28 12:03:48 +02:00
4d35717844
Upgrade the docker-login and checkout action versions
2024-04-26 23:08:53 +05:30
0a9e39d14e
Merge pull request #51670 from Shopify/fix-backtrace-cleaner
...
Fix backtrace cleaner
2024-04-26 14:21:49 -03:00
Rafael Mendonça França