mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
82,904 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

839 Commits

Author SHA1 Message Date
Claudio B b9f0eb24ed Fix tests for AWS buckets that include a . (#30059) 
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical
URL for an object will start with "https://s3.amazonaws.com/bucket.name/"
and not with "https://bucket.name.s3.amazonaws.com/".

The URL tests have now been separated into two separate asserts, to ensure
that both the "s3.amazonaws.com" and the "bucket.name" components are included,
but not specifically in that order.
 2017-08-04 17:56:14 -05:00
Rafael Mendonça França 77be872819 Do not change the entire codebase style only because of active_storage 
We are already removing the braces around hash parameters in the last
argument in other places so we should not change the entire codebase
because of two places.
 2017-08-03 17:45:58 -04:00
Rafael Mendonça França b76f4e47e8 Fix all rubocop violations 2017-08-03 17:32:59 -04:00
Rafael França 66e5bf9d07 Merge pull request #30061 from claudiob/ast-rubocop 
Make Rubocop happy about ActiveStorage
 2017-08-03 17:24:45 -04:00
Rafael Mendonça França 5bfff1de54 We need to require the top file before individual one 2017-08-03 17:02:43 -04:00
Rafael Mendonça França f601a01b2c Do not eager load ActiveRecord::Base 
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
 2017-08-03 16:57:48 -04:00
Rafael Mendonça França da44e858ca There is no reason to single line methods here 
I know those methods are unlikely to change but having one line method
is hard to read and also hard to modify.
 2017-08-03 15:23:28 -04:00
claudiob 9d636c9e2f Make Rubocop happier about ActiveStorage 
Running `rubocop activestorage` before this commit resulted in 20 offenses.
This commit only fixes:

- Trailing whitespace detected
- Space inside } missing
- Put one space between the method name and the first argument.

The other offenses are left since they are intentional according to
@georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
 2017-08-03 11:43:08 -07:00
David Heinemeier Hansson 624b6c210f Can't initialize a message verifier without a key base 2017-08-03 10:01:35 -05:00
Mike Gunderloy c5ae4e52e3 Tweak requires 
Omit azure-core (it's required by azure-storage), remove require:false to match other points.
 2017-08-02 20:47:58 -05:00
Mike Gunderloy d4f0b10319 Use release azure-core gem 2017-08-02 20:32:09 -05:00
Mike Gunderloy 0f2d3fb6da Update README.md 2017-08-02 19:55:10 -05:00
Mike Gunderloy 8aa742ff52 Add Azure gems to README 2017-08-02 18:29:51 -05:00
Ryuta Kamizono 815d1abf39 Fix `Style/StringLiterals` violations for Active Storage 
```
% be rubocop -a --only Style/StringLiterals activestorage
Inspecting 74 files
........................................CCCCCCCCCC.C........CC.......C.C..

(snip)

74 files inspected, 31 offenses detected, 31 offenses corrected
```
 2017-08-03 03:13:11 +09:00
Rolandas Barysas b334ac80cf Add Azure to the available services list 2017-08-02 10:28:51 +03:00
Bryan Lim f927de6fef Add Azure to readme 
previously https://github.com/rails/activestorage/pull/86
 2017-08-02 09:57:19 +08:00
David Heinemeier Hansson ff3dad07ba Skip if credentials aren't provided 2017-08-01 17:22:20 -05:00
David Heinemeier Hansson 4f8be04f4e Fix dummy app for inclusion in Rails 2017-08-01 17:22:10 -05:00
David Heinemeier Hansson 13882d0067 Remove circular dependency 2017-08-01 17:12:57 -05:00
David Heinemeier Hansson 1ea49d68ff Follow same format as action_cable 2017-08-01 16:50:53 -05:00
David Heinemeier Hansson b807b5b7e8 Cut down on installation advice 2017-08-01 16:28:05 -05:00
David Heinemeier Hansson c622e532fc Drop README terms no longer relevant 2017-08-01 16:26:13 -05:00
David Heinemeier Hansson e98eceb076 Rely on top-level files 2017-08-01 16:23:37 -05:00
Guillermo Iguaran d66fadeb67 Merge pull request #30030 from claudiob/only-disk 
Let ActiveStorage tests pass only for Disk
 2017-08-01 13:05:23 -05:00
claudiob 98bb99ef61 Don't depend on HTTParty 
"httparty" is only added in #30020 to write two tests to make PUT requests
against S3 and GCS.

The same requests can be made with net/http, removing a dependency from the Gemfile.
 2017-08-01 10:56:39 -07:00
claudiob 8b20789cfc Let ActiveStorage tests pass only for Disk 
If you have a "service/configurations.yml" file, but every single line is
commented out, then an error occurs when running tests:

```
git:active-storage-import~/code/rails/activestorage$ rake
~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError)
	from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require'
```

The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`.

This PR fixes this behavior so tests can also run when no remote service
is available.
 2017-08-01 09:06:39 -07:00
David Heinemeier Hansson a9cb1968b6 Setup travis to be able to run CI tests against S3 2017-07-31 17:51:16 -05:00
David Heinemeier Hansson ba12811db2 Move the direct_upload: true convenience option from the activestorage helper into actionview 2017-07-31 16:23:37 -05:00
David Heinemeier Hansson 5beb87c7b1 Move to new storage.yml location 2017-07-31 16:18:39 -05:00
David Heinemeier Hansson bb69b3e047 Directory and config installation now done by app_generator 2017-07-31 16:12:39 -05:00
David Heinemeier Hansson 9d1268375c Fix gitignore to be relative 2017-07-31 15:59:04 -05:00
David Heinemeier Hansson a1a363a8aa Follow form from actioncable 2017-07-31 15:57:56 -05:00
David Heinemeier Hansson 90a8e0698d Use config/storage.yml as part of the skeleton and loading 2017-07-31 15:57:37 -05:00
David Heinemeier Hansson 54663f55ef Resolve gemspec typo 2017-07-31 15:55:55 -05:00
David Heinemeier Hansson 9e502959c0 No longer used 2017-07-31 15:54:17 -05:00
David Heinemeier Hansson 16d00247f3 Bring activestorage dependencies into the general Gemfile 2017-07-31 15:53:09 -05:00
David Heinemeier Hansson 253757ddcb Initialize changelog 2017-07-31 15:52:39 -05:00
David Heinemeier Hansson 4b5e042d79 Use standard Rails layout for gemspec 2017-07-31 15:52:31 -05:00
Rafael Mendonça França 9330d01ada Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58' 
git-subtree-dir: activestorage
git-subtree-mainline: 0d58e7e478
git-subtree-split: 3f4a7218a4
 2017-07-31 15:21:22 -04:00