Commit Graph

622 Commits

Author SHA1 Message Date
Matthew Draper bb7775736c Add stopgap_13632 workaround
I'm not sure this is the problem we're seeing on Travis (occasional
unexpected IOError exceptions), but it's worth a try.
2017-08-29 21:10:49 +09:30
Robin Dupret 6db4cf9beb Temporarily point to a fork of SDoc
This fork brings:

* A tiny refresh of the default theme.
* SEO tags to class files.
* The removal of HTML tags from search results.
* Some general template clean-up (HTML 5, removal of the jQuery
  effect library, etc.).
* A speed up of the generation time (by ~30 seconds).
2017-08-17 14:49:31 +02:00
Rafael Mendonça França d2f493c7ed Test with released thor
thor 0.20.0 was released so we can test with the released version.
2017-08-16 14:03:24 -04:00
Koichi ITO d17264d93f Use frozen string literal in root files 2017-08-13 22:14:24 +09:00
Koichi ITO 7f33b8afa2 Simplify `git_source` in Gemfile
Follow up of 0b8441bd41
2017-08-07 17:46:48 +09:00
dixpac 053e556df1 Depend on offical azure-core
No need to depend on my fork anymore, they've just release fix
officially.
2017-08-03 12:12:58 +02:00
Ryuta Kamizono 815d1abf39 Fix `Style/StringLiterals` violations for Active Storage
```
% be rubocop -a --only Style/StringLiterals activestorage
Inspecting 74 files
........................................CCCCCCCCCC.C........CC.......C.C..

(snip)

74 files inspected, 31 offenses detected, 31 offenses corrected
```
2017-08-03 03:13:11 +09:00
David Heinemeier Hansson c6974229d0 Merge branch 'master' into active-storage-import 2017-08-02 09:52:14 -05:00
Rafael Mendonça França feb1ddae02 Merge remote-tracking branch 'origin/master' into unlock-minitest 2017-08-01 17:34:14 -04:00
claudiob 98bb99ef61 Don't depend on HTTParty
"httparty" is only added in #30020 to write two tests to make PUT requests
against S3 and GCS.

The same requests can be made with net/http, removing a dependency from the Gemfile.
2017-08-01 10:56:39 -07:00
David Heinemeier Hansson 16d00247f3 Bring activestorage dependencies into the general Gemfile 2017-07-31 15:53:09 -05:00
David Rodríguez 0c2c32d3d6 Fix warnings in railties tests
This warning has been fixed in sass-rails. This change picks up the fix.
2017-07-24 12:55:08 +02:00
Kasper Timm Hansen 5c16dd35a2 Move back to @matthewd's close io fixed rb-inotify. 2017-07-19 19:45:42 +02:00
Burke Libbey 0312a5c67e
Add bootsnap to default Gemfile:
Bootsnap precomputes load path resolution and caches ruby ISeq
and YAML parsing/compilation, reducing application boot time by
approximately 50% on supported configurations.
2017-07-17 13:17:45 -04:00
Kasper Timm Hansen 0391bbc01b Bump minitest; Use double quotes 2017-07-15 21:19:13 +02:00
Kasper Timm Hansen aad42dce10 Merge branch 'master' into unlock-minitest 2017-07-15 21:17:27 +02:00
Rafael Mendonça França 44f3ecbe5f Test thor master 2017-07-07 15:16:39 -04:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Matthew Draper 67a579419b Merge pull request #29488 from utilum/update_gemfile
Fixes FIXME: rb-inotify 0.99 has been released
2017-06-18 05:23:53 +09:30
utilum 96d58433c9 Fixes FIXME: rb-inotify 0.99 has been released 2017-06-17 18:59:41 +02:00
Rafael Mendonça França 62d316c6d8
Merge branch 'master' into unlock-minitest 2017-06-02 12:24:31 -04:00
Rafael França eb804ad5a7 Merge pull request #29187 from robin850/remove-mathn
Remove requirement on mathn
2017-05-30 11:37:15 -04:00
Robin Dupret ba84867549 Remove requirement on mathn
The test using mathn was first introduced in f1d9179 to check that the
`distance_of_time_in_words` properly doesn't use the `Fixnum#/` method
by explicitly requiring this library as it redefines this method.

Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since
version 2.2, we can certainly safely assume that people will most-likely
not require this library in their application.

However, to make sure that we don't regress, let's add a test similar to
the one before f1d9179.
2017-05-30 13:46:21 +02:00
Kasper Timm Hansen e1758b5e8c Merge branch 'master' into unlock-minitest 2017-05-29 20:37:35 +02:00
Matthew Draper d93cd4357b Switch to rb-inotify master
https://github.com/guard/rb-inotify/pull/49 has been merged.
2017-05-27 09:38:08 +09:30
bogdanvlviv 40bdbce191
Define path with __dir__
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
2017-05-23 00:53:51 +03:00
Akira Matsuda 45d7d80ea6 mathn has been gemified in ruby 2.5 2017-05-19 18:42:43 +09:00
Justin Coyne 673a5644ac Allow capybara minor releases
Capybara 2.14.0 was released. Loosen the tight constraint in the
generated Gemfile, so that Rails applications can take advantage of the
new version
2017-05-05 10:26:59 -05:00
Rafael Mendonça França 1421950512
Add minitest-bisect as part of the gemfile 2017-04-26 22:54:54 -07:00
Rafael Mendonça França 2883d2dff6
Release minitest lock so we can fix the order dependent tests 2017-04-26 22:53:55 -07:00
Zachary Scott 8e98cdfe63 Ask for a sane version of SDoc
This will allow me to push a release, including bug fixes,
without having to update Rails everytime.
2017-04-23 16:32:57 +09:00
Matthew Draper 19ae6597b8 Revert "Avoid broken faraday 0.12.0 release"
This reverts commit 82a7593e3a.
2017-04-02 21:32:33 +09:30
Matthew Draper 82a7593e3a Avoid broken faraday 0.12.0 release 2017-04-02 18:18:52 +09:30
Matthew Draper 6c08d480f1 Start Rails 5.2 development 2017-03-22 10:11:39 +10:30
eileencodes eadbc82c47 Bump Capybara and include Minitest::Assertions
Capybara was updated in teamcapybara/capybara#1841 to use Minitest style
assertions so that system test output shows x number of assertions, x
numbe of failures, etc.

Before:

```
6 runs, 0 assertions, 0 failures, 0 errors, 0 skips
```

After:

```
6 runs, 7 assertions, 1 failures, 0 errors, 0 skips
```

This change bumps Capybara from 2.7.0 to 2.13.0 and includes the
required minitest assertion file in the test case. 🎉
2017-03-17 08:22:22 -04:00
Javan Makhmali 2d2b3025ec Restore action_cable.js UMD module support. Fixes #28366 2017-03-11 16:12:36 -05:00
Rafael Mendonça França ea9566f6cd
Use released arel 2017-02-21 11:46:42 -05:00
eileencodes 1a0ca84a06 Move and rename system tests
* Move system tests back into Action Pack
* Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase`
* Remove private base module and only make file for public
`SystemTestCase` class, name private module `SystemTesting`
* Rename `ActionSystemTestCase` to `ApplicationSystemTestCase`
* Update corresponding documentation and guides
* Delete old `ActionSystemTest` files
2017-02-20 15:07:35 -05:00
yuuji.yaginuma 4a694c19e2 Use released resque 2017-02-10 15:31:41 +09:00
Akira Matsuda 6a1c0218df delayed_job and delayed_job_active_record gems with AR5 support are available 2017-01-29 09:05:06 +09:00
Jeremy Evans 7da8d76206
Change ActionView ERB Handler from Erubis to Erubi
Erubi offers the following advantages for Rails:

* Works with ruby's --enable-frozen-string-literal option
* Has 88% smaller memory footprint
* Does no freedom patching (Erubis adds a method to Kernel)
* Has simpler internals (1 file, <150 lines of code)
* Has an open development model (Erubis doesn't have a
  public source control repository or bug tracker)
* Is not dead (Erubis hasn't been updated since 2011)

Erubi is a simplified fork of Erubis that contains just the
parts that are generally needed (which includes the parts
that Rails uses).  The only intentional difference in
behavior is that it does not include support for <%=== tags
for debug output.  That could be added to the ActionView ERB
handler if it is desired.

The Erubis template handler remains in a deprecated state
so that code that accesses it directly does not break.  It
can be removed after Rails 5.1.
2017-01-25 01:41:27 -07:00
Akira Matsuda 641a490e56 Revert "I guess we're ready for the randomized tests now"
This reverts commit 8c155c932f.

Not really 😢
2017-01-18 20:52:21 +09:00
Akira Matsuda 8c155c932f I guess we're ready for the randomized tests now 2017-01-18 18:27:05 +09:00
toshimaru 6e30114c0a update rubocop to 0.47 2017-01-16 15:34:30 +09:00
Akira Matsuda 46fdbc5290 Revert "bundle u mocha"
This reverts commit 66e5b9d3f4.

We're seeing some test failures in AR postgresql tests
2017-01-16 00:16:41 +09:00
Akira Matsuda 66e5b9d3f4 bundle u mocha
I see no reason not to use the newest stable version.
2017-01-15 22:58:40 +09:00
Rafael Mendonça França e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
Matthew Draper 774be3ea3b bundle update 2016-12-26 23:17:54 +10:30
Zachary Scott eeb1926158 Bump sdoc to rc1 which includes zzak/sdoc#98 2016-12-25 17:55:21 +09:00
Bian Jiaping 88792b1b2e Fix rake guides:generate:kindle error 2016-12-18 23:13:50 +08:00
Guillermo Iguaran ffb81ad6e3 rails-ujs is now shipped with Action View 2016-11-29 09:48:19 -05:00
Rafael França 06d2049618 Merge pull request #27196 from kirs/rubocop-gem
Add rubocop to Gemfile
2016-11-28 17:32:48 +01:00
Kir Shatrov 61fa0a8675 Add rubocop to Gemfile 2016-11-28 10:28:21 -05:00
Guillermo Iguaran 277b5f9af8 Add rails-ujs as dependency in the rails Gemfile 2016-11-21 18:58:36 -05:00
Jon Moss 3256dcd8b9 Install libxml-ruby gem so full XMLMini test suite can be run 2016-11-19 10:46:28 -05:00
Akira Matsuda 3a558aa2bc Make sure to bundle json 2.x on CI
Without this, bundler tries to bundle json 1.8 on Ruby 2.4 in some cases
https://travis-ci.org/rails/rails/jobs/175874852
2016-11-15 09:26:03 +09:00
Gaurav Sharma f0bacbc2c4 update kindlerb gem
Ruby Kindle periodical-format ebook generator
2016-10-21 09:37:24 +05:30
Zachary Scott db85fa1db4 Include sdoc 1.0.0.beta2 which includes updated rdoc w/o hard json dep 2016-10-07 18:51:27 +09:00
Zachary Scott 91efc4fc0b Bump sdoc to 1.0.0.beta1 which includes fix to support Ruby 2.4 2016-10-07 18:42:22 +09:00
Matthew Draper acd7ba795e Use a branch of websocket-client-simple, to work around read/close race 2016-10-06 12:51:26 +10:30
Esteban Santana Santana ddddedc487 Allow the use of listen's 3.1.x branch.
When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.
2016-10-03 16:58:17 +05:30
Matthew Draper 7c812c2401 Use websocket-client-simple instead of Faye as a websockets client
Mostly, this is just to avoid EventMachine. But there's also an argument
to be made that we're better off using a different protocol library for
our test suite than the one we use to implement the server.
2016-10-02 12:25:33 +10:30
Rafael Mendonça França 12d5c21031
Override the github git source instead of changing manually all entries 2016-09-14 10:58:21 -03:00
Prathamesh Sonpatki cc769d03dc
Use :git for specifying dependencies from github with https protocol
- This is required for bundler 1.13.0 because of which lot of specs are
  failing on Travis CI.
- Similar to https://travis-ci.org/rails/rails/jobs/158905576#L559
2016-09-10 20:15:53 +05:30
Xavier Noria 9ed7404498 applies new string literal convention in Gemfile
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:23:19 +02:00
Sean Griffin ca0b6d0d41 Don't require C dependencies on Windows/JRuby 2016-08-03 10:14:26 -04:00
Rafael Mendonça França ab503f72c5
Do not require rb-inotify 2016-07-27 23:47:26 -03:00
Rafael Mendonça França 5859cbddc3
Use a form of rb-inotify to fix broken tests with Ruby 2.2.5
See https://github.com/nex3/rb-inotify/pull/49
2016-07-27 23:39:10 -03:00
yuuji.yaginuma 8c46abfd70 test with latest resque
When run test of Active Job with resque 1.26, occurs following error.

```
QueuingTest#test_current_locale_is_kept_while_running_perform_later:
NoMethodError: undefined method `current_tags' for #<Resque::QuietFormatter:0x0055b44f63ed50>
    /home/yaginuma/program/rails/master_y_yagi/rails/activejob/lib/active_job/logging.rb:51:in `logger_tagged_by_active_job?'
```

This was happening for the formatter class of resque not the formatter class of
Rails is they've been used to logger.formatter.
This was happening because become fomatter is changed during the instantiation
of worker in the resque 1.26.
In the master, unless the environment variable is set, fomatter is so as not to
be changed, test will pass.

Ref: https://github.com/resque/resque/pull/1439
2016-07-05 10:02:41 +09:00
Rafael Mendonça França 14dc9b9cd9
Use sass-rails in our test suite 2016-06-30 19:39:37 -03:00
Rafael Mendonça França 19ba6b8d4e
Merge pull request #25607 from sstephenson/turbolinks-5-final
Update to Turbolinks 5.0.0 final
2016-06-30 14:39:36 -03:00
Rafael Mendonça França e4c8aae643
Point to released coffee-rails 2016-06-30 14:35:25 -03:00
Sam Stephenson 10ba790124 Update to Turbolinks 5.0.0 final 2016-06-30 12:22:16 -05:00
Jon Moss 0c330888d6
Require Nokogiri >= 1.6.8
per security release today --> https://groups.google.com/forum/#!topic/ruby-security-ann/RCHyF5K9Lbc
2016-06-06 23:10:37 -04:00
Javan Makhmali 0e9c340d6f Update Blade and its Sauce Labs plugin for EventMachine 1.2 compatibility 2016-06-04 18:54:34 -04:00
Javan Makhmali 20c14c5f13 Lock Faye version to avoid bug with its Promise polyfill, use mainline blade-sauce_labs_plugin gem 2016-05-31 10:44:09 -04:00
Jon Moss 8cfce058d9
CI: run Action Cable browser tests in Sauce Labs
Allow failures until test runs are consistently stable, not hanging.

Closes #24943.

Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
2016-05-25 09:21:28 -07:00
Javan Makhmali 11078dddbb Build action_cable.js with Blade 2016-05-24 13:11:10 -04:00
Vipul A M 61483b18bc
Remove Blade gem dependency
Apps that depend on Action Cable don't need Blade for app development,
so we can remove the gem dependency.

We do need Blade for Action Cable dev, so we bundle it in the Gemfile.

Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
2016-05-21 12:41:01 -07:00
Rafael Mendonça França 8ecc5ab1d8 Start Rails 5.1 development 🎉 2016-05-10 03:46:56 -03:00
Jeremy Daer ab56c92f3c
Merge pull request #23461 from kamipo/prepared_statements_for_mysql2_adapter
Add prepared statements support for `Mysql2Adapter`
2016-04-23 22:28:52 -07:00
Sean Griffin 1f47c4b0df Make file update checker tests more resilient on Windows
Without the `wdm` gem, it appears that `listen` keeps an open handle to
each of these files, causing them not to be removed when the tempdir
tries to clean iteslf up, and then directory to fail to unlink. In
addition to fixing that particular failure, we now construct OS agnostic
paths, and capture exceptions if the directory fails to unlink so that
minitest will report it rather than crash
2016-04-21 10:54:54 -06:00
Ryuta Kamizono 3f6574efb1 Add prepared statements support for `Mysql2Adapter` 2016-04-21 09:17:42 +09:00
Benjamin Fleischer 3027970464 Run latest precompiled JRuby on CI only against ActionPack
Uses latest precompiled JRuby so that
we don't spend time downloading versions Travis has
not already compiled. http://rubies.travis-ci.org/

Uses latest jdk: oraclejdk8
per
https://docs.travis-ci.com/user/build-environment-updates/2015-02-03/#Ruby-VM
and
https://docs.travis-ci.com/user/languages/ruby/#Supported-Ruby-Versions-and-RVM

Follows on work in https://github.com/rails/rails/pull/23927 which was reverted
26fe5fa08d

JRUBY_OPTS minimize GC, disable JIT, for max test speed
  - https://github.com/rails/rails/pull/16613
  - https://github.com/rails/rails/pull/17088

Have Rails use JRuby-compatible Rake 11.1
  - The Rake task was passing --verbose, an invalid option, to contemporary JRuby
  - https://github.com/ruby/rake/pull/120
  - https://github.com/rails-api/active_model_serializers/pull/1585
  - https://github.com/jruby/jruby/issues/3653#issuecomment-195883717

No advantage to directly mounting JRuby over installing from cache; both on S3
  - b2d5b336b5
  - f4fad041b2
2016-03-30 02:11:45 -05:00
Rafael Mendonça França 92f869a0c8 Ping the resque version while we can't investigate the failure 2016-03-11 17:11:59 -03:00
T.J. Schuck efbfdd4049 Version 3.1.11 works on Windows again
This undoes 7241498e51

https://github.com/codahale/bcrypt-ruby/issues/128 is fixed and closed.
2016-03-10 14:13:21 -05:00
Sarah A f667f0aa04 Update Gemfile
Changes "as has to be loaded" to "as it has to be loaded"
2016-03-03 23:42:53 -08:00
Prathamesh Sonpatki 2669f3753d Update turbolinks-rails for passing railties test
Ref - https://github.com/turbolinks/turbolinks-rails/pull/3
2016-02-05 17:02:22 +05:30
Rafael Mendonça França dd67df6136 Test with Turbolinks 5 2016-02-04 14:24:36 -02:00
Mike Perham f3433f7c75 Remove json gem dependency
All modern Rubies ship JSON as part of stdlib.  Using the gem actually hurts multi-platform support due to build difficulties on Windows.
2016-02-03 10:49:14 -08:00
Matthew Draper e77368637e Switch the default redis adapter to a single-stream model
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
2016-02-01 01:56:47 +10:30
Matthew Draper ce37de4a19 Add a couple of tests that connect with a WS client 2016-01-30 03:46:37 +10:30
Rafael Mendonça França 2c131141ca Remove celluloid from the Gemfile 2016-01-27 15:44:26 -05:00
Jon Moss a9a64c490d Update ActiveJob adapter for sucker_punch 2.0
This PR includes two changes for 2.0.0:

- Breaking API change around `async.perform` --> `perform_async`
- New addition of `perform_in`, which now allows end users of the
  adapter to use the `enqueued_at` public API method.
2016-01-27 12:49:35 -05:00
Matthew Draper 9ff28c10eb Add tests for the ActionCable adapters 2016-01-24 21:13:40 +10:30
Brandon Hilkert bc194937ad Ensure sucker_punch < v2 is installed due to the change in public API 2016-01-02 14:54:15 -05:00
Rafael Mendonça França 477bed8871 Use released rack 2015-12-18 04:54:50 -02:00
Rafael Mendonça França 8f8cb1baa3 Install jquery-rails
It will make sure that the generated application in the tests get the
gem.
2015-12-18 04:13:53 -02:00
Matthew Draper 4a58aef7e3 Merge pull request #22642 from seuros/remove-mysql-adapter
Remove legacy mysql adapter
2015-12-18 13:51:04 +10:30