mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
90,558 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

200 Commits

Author SHA1 Message Date
Eugene Kenny ee525ff663 Load framework test files in deterministic order 
`Dir.glob` doesn't guarantee the order of its results:

https://ruby-doc.org/core-2.6.5/Dir.html#method-c-glob

> Case sensitivity depends on your system (File::FNM_CASEFOLD is
> ignored), as does the order in which the results are returned.

Minitest stores a list of all test cases in the order that they were
defined; it shuffles them before they're run, but doesn't sort them:

https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L1048
https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L156

This means that the order in which framework tests run is platform
dependent, and running a test command that failed in CI locally won't
necessarily reproduce the error, even when the same seed is provided.

`Rake::FileList` resolves glob patterns to a sorted list of files:

https://github.com/ruby/rake/blob/v13.0.1/lib/rake/file_list.rb#L408

By using `Rake::FileList` instead of `Dir.glob`, framework tests will
always run in the same order when given the same seed, and reproducing
order dependent CI failures will be easier.
 2019-12-16 16:55:06 +00:00
Yoshiyuki Hirano 6aaeb8ef10 Improve redundancy in line tasks 
* Remove needless concat from actionpack/Rakefile
* Remove neesless File.join from actionview/Rakefile
 2018-04-19 23:45:28 +09:00
Kir Shatrov dfcc766163 Use frozen string literal in actionpack/ 2017-07-29 14:02:40 +03:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
 2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
bogdanvlviv 40bdbce191
Define path with __dir__ 
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
 2017-05-23 00:53:51 +03:00
Xavier Noria bb1ecdcc67 fixes remaining RuboCop issues [Vipul A M, Xavier Noria] 2016-09-01 23:41:49 +02:00
Xavier Noria 5b6eb1d58b modernizes hash syntax in actionpack 2016-08-06 19:35:13 +02:00
Xavier Noria e6ab70c439 applies new string literal convention to the rest of the project 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:28:46 +02:00
Javan Makhmali d12209cad2 Remove package:clean task 
Introduced in d6f2000a67 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
 2016-05-24 13:11:28 -04:00
Matthew Draper d6f2000a67 Wrangle the asset build into something that sounds more general 2016-02-01 05:03:03 +10:30
Arun Agrawal 21b6b68f63 Remove unused package tasks 
We are using `all:build` now.
 2015-05-28 09:06:10 +02:00
Arun Agrawal 4194d052d8 Remove broken and unused release task 
- We do release with release.rb
- There is no `rake/gemcutter`
 2015-05-22 14:30:30 +02:00
Matthew Draper e462021396 Revert "For now, we will keep sorting the tests." 
This reverts commit 7025d7769d.
 2015-03-06 04:39:20 +10:30
Robin Dupret 1fac7b79f3 Follow up to #16613 
Since we want this flag to be enabled anytime we are running the tests
under JRuby, let's enable this at the Rakefile level so people get the
performance boost on their local checkout.

Moreover, we avoid having to update this particular line anytime the
option changes on the JRuby side.

The only drawback is that we have to define it in every Rakefile but
there's no big deal, this is already the case for other options.
 2014-09-28 12:04:06 +02:00
Matthew Draper 7025d7769d For now, we will keep sorting the tests. 
This reverts commits e969c92846 and
bd2b3fbe54.
 2014-09-05 23:33:27 +09:30
Akira Matsuda b7d649d2ff Test everything 
This actually was testing test everything, so why not do it simpler?
 2014-08-28 14:40:54 +09:00
Akira Matsuda e969c92846 AP test files does no more need to be alphabetically sorted here 2014-08-28 14:38:42 +09:00
Benjamin Fleischer 91d199259b Encapsulate rake lines from ActiveRecord/ActionPack as CodeTools::LineStatistics 
[ci skip]
 2014-07-25 13:41:18 -05:00
Arun Agrawal f52832de2a grab executable from rubygems 
As done here d7fc97d3f9
 2013-07-26 11:07:25 +02:00
Arun Agrawal 96310f69e1 Added routing in test for actionpack 2013-07-17 08:55:24 +01:00
Arun Agrawal cbaf71b7dc Running isolated test for assertions and journey 
in actionpack
 2013-07-06 23:06:05 +02:00
Arun Agrawal c4f588213b Minor changes to actionpack/actionview Rakefile 2013-06-26 10:22:10 +02:00
Carlos Antonio da Silva f02d4ddc99 Merge pull request #11046 from arunagw/verbose_mode_on 
Verbose mode on when running tests
 2013-06-25 15:15:43 -07:00
Arun Agrawal d88b390dfd Adding verbose in isolated test. 2013-06-21 14:14:36 +02:00
Arun Agrawal 67f668845e Saying gemcutter => rubygems [ci skip] 2013-06-21 11:04:52 +02:00
Łukasz Strzałkowski f5305e7c5f Template test were moved to AV 2013-06-20 17:23:17 +02:00
Piotr Sarnacki eb23754ebb Move template tests from actionpack to actionview 2013-06-20 17:23:16 +02:00
Arun Agrawal a84a08ecea No need to load 'rake/packagetask' as it's already 
in 'rubygems/package_task'
 2013-06-02 20:41:21 +02:00
Arun Agrawal 5eaa30e47c Running isolated tests 
These stopped running don't know when. 
But these should be running now.
 2013-05-28 19:59:55 +02:00
Francesco Rodriguez eb493f5ac8 update AD::Journey to follow Rails coding conventions 2012-12-20 15:42:39 -05:00
Andrew White 56fee39c39 Integrate Journey into Action Dispatch 
Move the Journey code underneath the ActionDispatch namespace so
that we don't pollute the global namespace with names that may
be used for models.

Fixes rails/journey#49.
 2012-12-19 22:13:08 +00:00
Santiago Pastorino fbf1858ed9 Add test directory to TestTask's libs 2012-05-11 19:25:19 -03:00
Roman V. Babenko 84feca4aaa Rakefile executable attributes and shebang lines has been removed 2012-05-02 13:38:13 +03:00
Arun Agrawal bfb84cfb3e Verbose output for tests. 
See #3892
 2012-02-03 08:01:24 -05:00
Arun Agrawal 1d3bc506f4 No verbose the output for tests. 2012-02-01 07:21:38 -05:00
Nathan Broadbent bf928bc732 Use block form of 'File.open' so that File object is auto closed at end 2012-01-30 03:15:51 +08:00
Nathan Broadbent b31eac5609 Replaced all 'for' loops with Enumerable#each 2012-01-30 03:15:49 +08:00
Aaron Patterson 01d17943ec test response assertions 2012-01-06 11:20:26 -08:00
Nick Sutterer 41bca5d466 Add rake test:template. 2011-09-22 14:00:53 +02:00
Vijay Dev 79e9a2983a fixes Rake::GemPackageTask deprecation warnings from rake 0.9.0 2011-05-24 23:39:24 +05:30
raggi cb1570936d Rakefiles are executables, and rake loads rake, not rakefile code 2010-11-25 06:49:55 +08:00
Emilio Tagua 17599abc9c Enable warnings now that they can be readed. 2010-09-28 18:50:46 -03:00
Aaron Patterson 38f6533792 argument error is done for us 2010-09-18 14:00:00 -07:00
Xavier Noria 43291469cb deletes the rdoc task of each component, they are no longer published separately 2010-08-20 13:30:31 +02:00
Santiago Pastorino cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Aaron Patterson b50635a59f update Rakefiles for RDoc 2.5 2010-07-23 21:11:29 +02:00
Santiago Pastorino b378b19430 Makes Rakefile activate rdoc >= 2.5.9 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-23 00:04:06 +02:00
José Valim 508fba9e07 Add .rdoc extension to README files. 2010-07-21 12:51:14 +02:00
Xavier Noria 01f3f0dbae use RDoc 2.2 to generate the documentation of individual components 2010-06-16 22:30:06 +02:00