mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
51,001 Commits 56 Branches 544 Tags 410 MiB
Commit Graph

51001 Commits

Author SHA1 Message Date
Tushar Maroo 1711c091e9 Changed 'ask the rubyonrails-talk mailing list.' to 'ask it on the rubyonrails-talk mailing list.' 2015-05-03 16:16:03 +05:30
eileencodes 76836ef7db Use `def before_setup` instead of `setup do` 
`setup do` creates unnecessary allocations of proc objects in test
callbacks. This prevents that from happening and results in faster code.

Originally I had done this as `def setup` and all Railties tests passed.
See 044f9ab. Later it was reported there was an issue with this that
caused routes in tests to be nil because devs don't generally call
`super` in their test setups. Because of that I reverted the commit
until I could find a suitble replacement.

`before_setup` esentially does the same thing but without the
requirement that applications call `super` in their test setups.
 2015-05-02 10:45:17 -04:00
eileencodes e260975baf Use `args` instead of `*args` in `kwargs_request?` method 
`*args` is not required here and should be avoided when not necessary
because `*args` are slower than `args` and create unnecessary array
allocations.
 2015-05-02 09:31:03 -04:00
Zachary Scott 1e7640e68d Fix method call typo [ci skip] 2015-05-02 00:50:14 -07:00
Zachary Scott 1a02de7098 Merge pull request #19973 from trosborn/master 
Clean up debugging guide and fix minor grammatical errors[ci skip]
 2015-05-02 00:49:21 -07:00
Zachary Scott 546f7ca73c Merge pull request #19974 from yui-knk/fix/form_for_examples_2 
[ci skip] Fix example codes of form_for method
 2015-05-02 00:44:19 -07:00
Zachary Scott 57b9ef1be8 Merge pull request #19975 from prathamesh-sonpatki/engine-minor-changes 
Added missing fullstop in engine API docs [ci skip]
 2015-05-01 23:51:15 -07:00
Prathamesh Sonpatki 3110c98ab1 Added missing fullstop in engine API docs [ci skip] 2015-05-02 09:53:38 +05:30
yui-knk de397954e6 [ci skip] Fix example codes of form_for method 2015-05-02 09:09:49 +09:00
Thomas Osborn 1beff7cbe6 Clean up debugging guide and fix minor grammatical errors[ci skip] 2015-05-01 15:34:09 -07:00
Yves Senn 2e7fd4a866 Merge pull request #19971 from thiagoaugusto/improve-activerecord-changelog 
Improvement on Activerecord CHANGELOG.md [ci skip]
 2015-05-01 17:24:47 +02:00
thiagoaugusto 361f1bc7c5 Improvement on Activerecord CHANGELOG 2015-05-01 11:34:19 -03:00
Kasper Timm Hansen 76bb6cb722 Merge pull request #19970 from robertomiranda/patch-3 
Update documentation to contain a 24 char token [ci skip]
 2015-05-01 14:59:18 +02:00
Roberto Miranda 6541fef8de Update documentation to contain a 24 char token [ci skip] 2015-05-01 07:23:59 -05:00
Yves Senn e38dd7bfa4 add test-case for `link_to_if` behavior with a block. 
This illustrates the purpose of the block for `link_to_if` and
`link_to_unless` helper methods.

It should help to prevent further mistakes like #19844.
 2015-05-01 11:12:56 +02:00
Yves Senn 14d0e07026 Revert "Merge pull request #19844 from stevenspiel/link_to_if_block_helper_addition" 
This reverts commit d459b001b4, reversing
changes made to 4d4950fae9.

😓

The block is not supposed to be passed to `link_to`. It's used for a
customized behavior of the `condtion = false` case. The docs
illustrate that like so:

```
<%=
   link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do
     link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user })
   end
%>
```
 2015-05-01 11:02:56 +02:00
Yves Senn d459b001b4 Merge pull request #19844 from stevenspiel/link_to_if_block_helper_addition 
Update url_helper.rb
 2015-05-01 10:54:23 +02:00
Yves Senn 4d4950fae9 Merge pull request #19969 from y-yagi/fix_job_helper_method 
match a expected value with message of `assert_equal` in AJ helper methods
 2015-05-01 08:59:58 +02:00
yuuji.yaginuma 9150866698 match a expected value with message of `assert_equal` in AJ helper methods 2015-05-01 07:34:37 +09:00
Yves Senn 8fd4633009 Merge pull request #19962 from prathamesh-sonpatki/nodoc-validate-index-length 
Nodoc validate_index_length! method
 2015-04-30 15:17:52 +02:00
Richard Schneeman a000e5c455 Merge pull request #19961 from prathamesh-sonpatki/pg-docs 
Added documentation for PostGreSQL database_statements [ci skip]
 2015-04-30 06:47:27 -05:00
Prathamesh Sonpatki 84baa027d2 Nodoc validate_index_length! method 
- This method is used only by adapters to validate length of new index names.
 2015-04-30 13:29:20 +05:30
Prathamesh Sonpatki 8e73f97459 Added documentation for PostGreSQL database_statements [ci skip] 
- Added documentation for index_name_exists? and rename_index.
 - Also changed rails to \Rails in documentation of
   allowed_index_name_length.
 2015-04-30 13:23:02 +05:30
Zachary Scott 79c4aac552 Merge pull request #19959 from imtayadeway/tw/caching-docs 
Fix style/grammar/typos in Caching guide.
 2015-04-29 23:52:50 -07:00
Tim Wade ae5c5b2237
Fix style/grammar/typos in Caching guide. 
* avoid using unnecessary commas
* fix some typos
 2015-04-29 23:36:35 -07:00
Zachary Scott b66dcc1f86 Add doc for original_exception in ActiveJob::DeserializationError [ci skip] 2015-04-29 18:46:25 -07:00
Zachary Scott 785cb9fe75 Add initial doc for Core in AJ [ci skip] 2015-04-29 18:46:12 -07:00
Zachary Scott 56bcd69ade Add initial doc for Enqueuing module [ci skip] 2015-04-29 18:45:53 -07:00
Zachary Scott 80ee55f3b8 Rails should be nodoc'd here [ci skip] 2015-04-29 18:44:37 -07:00
Zachary Scott 8cf22cefd4 Merge pull request #19957 from rywall/patch-2 
Document :tld_length option for cookies.
 2015-04-29 16:47:52 -07:00
Ryan Wallace d5a6297178 Document :tld_length option for cookies. 2015-04-29 14:15:18 -07:00
Yves Senn 8b9e8a3f6f Merge pull request #19952 from vngrs/activejob_missing_error_messages 
Add missing error messages for sucker_punch, sneakers and qu
 2015-04-29 13:55:03 +02:00
Mehmet Emin İNAÇ 6528b01942 Add missing error messages for sucker_punch, sneakers and qu activejob adapters [ci skip] 
fix error message

change raise to use rails conventions

fix misspells
 2015-04-29 14:51:54 +03:00
Yves Senn 4e6f0053db Merge pull request #19949 from thiagoaugusto/create-thiago-punctuation-fix 
CHANGELOG punctuation fix
 2015-04-29 09:01:44 +02:00
Godfrey Chan a1c7f1b446 Revert "Merge pull request #19817 from tpitale/4_2-release-notes-fix" 
This reverts commit 00aa1afae3, reversing
changes made to b584cc68fc.

Reason:

As far as we can tell, this should not be the case. Both localhost, 127.0.0.1
and ::1 is "supposed to work", so this is probably a bug somewhere.

Reopening #19815 instead.
 2015-04-28 20:58:05 -07:00
Thiago Augusto 88f429c83f CHANGELOG punctuation fix 
Punctuation fix
 2015-04-29 00:42:47 -03:00
Zachary Scott 8979a5a4bd Merge pull request #19945 from thenickcox/migration_generator_docs 
[ci skip] Correct grammar, add docs to ActiveRecord migration generator
 2015-04-28 14:00:45 -07:00
Nick Cox f63d141eaf [ci skip] Correct grammar, add docs to ActiveRecord migration generator 2015-04-28 13:34:13 -07:00
Rafael Mendonça França f4b8b58f72 Merge pull request #19941 from javan/actionmailer-cache-noop 
Make ActionMailer #cache helper a no-op, not an exception
 2015-04-28 16:58:34 -03:00
Javan Makhmali 20f6f646d1 Make ActionMailer #cache helper a no-op, not an exception 2015-04-28 13:56:42 -06:00
Rafael Mendonça França 7bc45df182 Merge pull request #19939 from artofhuman/remove-mocha-from-some-tests 
Remove use of mocha in the named base tests
 2015-04-28 16:41:01 -03:00
Zachary Scott 9822ce2eb3 Merge pull request #19942 from earthrid/master 
Rewording
 2015-04-28 11:22:54 -07:00
Kevin Busby 1856899364 Rewording 
Rewording in accordance with the documentation guidelines (‘Prefer
wordings that avoid "you"s and "your”s.’) and to remove in particular
“if you'd call”.
 2015-04-28 17:00:50 +01:00
Yves Senn 9e84c0096f Merge pull request #19917 from senny/preview_null_mail 
Previews when `mail` wasn't called (NullMail instances).
 2015-04-28 16:24:44 +02:00
Yves Senn 767d60156b mailer previews for `NullMail` instances. Closes #19849. 2015-04-28 16:00:08 +02:00
Yves Senn d704f8f808 mailer previews, make sure labels and values line up. 
While this was true before when every `dd` had a value,
this patch makes sure that everything keeps lining up even
when the `dd` node is blank.
 2015-04-28 16:00:07 +02:00
Semyon Pupkov 3ca5ae57b5 Remove use of mocha in the named base tests 2015-04-28 18:16:43 +05:00
Yves Senn 6ccf3bfa6e Merge pull request #19932 from axilleas/api_docs_guidelines 
Make sure you execute rake rdoc from rails root directory [ci skip]
 2015-04-28 14:34:51 +02:00
Achilleas Pipinellis 86b6c77337 Update instructions to build guides locally [ci skip] 
1. Make clear where rake rdoc is executed
2. Make clear where the generated HTML files for the guides are stored
3. Use bundler 1.3.5 or later
 2015-04-28 15:33:13 +03:00
Carlos Antonio da Silva 76fc205f99 Merge pull request #19935 from eliotsykes/clarify-configuring-default-test-order 
Clarify test_order default configuration behaviour [ci skip]
 2015-04-28 09:12:39 -03:00