6149444685
Make silence a warning inserted by commit #4b3f8ac
2015-07-30 00:42:19 +09:00
062cbd18dd
Revert "Merge pull request #20758 from xijo/action_mailer_message_delivery_respects_i18n_locale"
...
This reverts commit f2a8c236543046c9bbe1
2015-07-07 22:11:20 +02:00
ca2387eb01
ActionMailer::MessageDelivery respects current I18n.locale
...
When #deliver_now is called all translations within the
generated email will be looked up for the current I18n
locale.
I18n.locale = ‘de’
mail.deliver_now # Generates german email, correct
In #enqueue_delivery the locale was not considered and
the resulting job uses the default locale.
I18n.locale = ‘de’
mail.deliver_later # Generate english email, incorrect
In order to achieve a consistent behaviour the current locale
is now always passed to `ActionMailer::DeliveryJob`.
2015-07-05 20:21:25 +02:00
9946788775
select the AR adapter through `bin/test`.
2015-06-11 14:24:56 +02:00
54d84cbb77
use our runner (`bin/test`) for framework components.
...
This adds a script `bin/test` to most Rails framework components. The
script uses the rails minitest plugin to augment the runner.
See https://github.com/rails/rails/pull/19571 for details about the
plugin.
I did not yet add `bin/test` for activerecord, activejob and railties.
These components rely on specific setup performed in the rake-tasks.
2015-06-11 14:12:15 +02:00
0b57f090c9
Tiny documentation edits [ci skip]
2015-06-09 11:49:33 +02:00
ae5f2b4e79
Document config.action_mailer.deliver_later_queue_name
...
Also add a CHANGELOG entry for #18587
[ci skip]
2015-06-03 13:28:21 -03:00
cecbf9ed32
Merge pull request #18587 from chrismcg/allow_deliver_later_queue_name_to_be_configured
...
Allow configuration of ActionMailer queue name
2015-06-03 13:25:32 -03:00
f5a131aaea
Allow configuration of ActionMailer queue name
2015-06-02 10:49:49 +01:00
b42d770b3b
Make the wording less confusing
...
This partially reverts commit ac02df5c78
2015-05-29 15:24:13 -03:00
9575f4fdca
minor text change
2015-05-29 13:50:12 -04:00
ac02df5c78
Update inline_preview_interceptor.rb
2015-05-29 13:44:46 -04:00
baa773a520
not require mail file
...
```
it added in this commit (2a25c4ce6d
2015-05-29 21:25:28 +05:30
21b6b68f63
Remove unused package tasks
...
We are using `all:build` now.
2015-05-28 09:06:10 +02:00
4194d052d8
Remove broken and unused release task
...
- We do release with release.rb
- There is no `rake/gemcutter`
2015-05-22 14:30:30 +02:00
4547d87853
formatting changes [ci skip]
2015-05-17 10:41:27 -07:00
0080a886b2
[ci skip] Don’t encourage `sudo gem install`
...
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? 😁
2015-05-12 14:51:19 -07:00
0e6a67644a
not needed require's
...
- as core_ext is not used and test pass locally
- mail is already required in abstract_unit
2015-05-10 08:42:30 -04:00
49a59cc6a5
`assert_emails` in block form use the given number as expected value
2015-05-09 18:59:59 +09:00
faaed863dd
Document inline image mailer preview interceptor
...
Explain what the interceptor is used for and how to remove it.
2015-05-04 19:46:51 +01:00
60239f3e5a
Add support for inline images to mailer previews
...
Use a preview interceptor to search for inline cid: urls in src
attributes and convert them to data urls.
2015-05-04 10:56:59 +01:00
f5132c19d5
Mailer preview now uses `url_for` to fix links to emails for apps running on a subdirectory, closes #19092 .
2015-04-30 10:12:00 -04:00
20f6f646d1
Make ActionMailer #cache helper a no-op, not an exception
2015-04-28 13:56:42 -06:00
767d60156b
mailer previews for `NullMail` instances. Closes #19849 .
2015-04-28 16:00:08 +02:00
d704f8f808
mailer previews, make sure labels and values line up.
...
While this was true before when every `dd` had a value,
this patch makes sure that everything keeps lining up even
when the `dd` node is blank.
2015-04-28 16:00:07 +02:00
e7d2cef1f4
AUTH PLAIN is Base64 encoded [ci skip]
...
Contrary to what the name suggests, PLAIN SMTP authentication is not
sent in plain text but is Base64 encoded like the LOGIN method. Their
difference is described in the third link below.
* https://tools.ietf.org/html/rfc4954
* https://en.wikipedia.org/wiki/SMTP_Authentication
* http://www.samlogic.net/articles/smtp-commands-reference-auth.htm
2015-04-28 11:49:13 +03:00
33ea933d7b
Merge pull request #19753 from jonatack/use-ruby-2-2-2
...
Upgrade to Ruby 2.2.2
2015-04-13 22:56:47 -05:00
32f7491808
Upgrade to Ruby 2.2.2
...
and fix the grammar in the ruby_version_check.rb user message.
2015-04-14 08:41:56 +05:30
a647277fb9
Since the delegator wasn't identified earlier, we should here [ci skip]
2015-04-12 13:29:58 -07:00
1ffd603712
Merge branch 'action-mailer-async-doc-fixes' of https://github.com/mfazekas/rails into mfazekas-action-mailer-async-doc-fixes
...
Conflicts:
actionmailer/lib/action_mailer/base.rb
2015-04-12 13:28:10 -07:00
91744696a4
[skip ci] Fix typo in actionmailer documentation
2015-03-15 23:32:24 +03:00
f0768eba28
Target Ruby 2.2.1 in gemspecs
...
This is a follow-up to #19257
2015-03-09 09:56:26 +01:00
b5eb0b6cc3
Revert "Leave all our tests as order_dependent! for now"
...
This reverts commit 2f52f96988
2015-03-06 04:38:54 +10:30
9f4210cd80
Merge pull request #19133 from davydovanton/update-doc-example-mail-block-format
...
[ci skip] Add code example for MailHelper#block_format documentation
2015-03-02 13:10:30 +01:00
435aa7e34f
[ci skip] Add code example for MailHelper#block_format documentation
2015-03-02 15:01:57 +03:00
bc970e8335
Removing unused mailer templates
2015-03-01 16:07:24 -03:00
5ef18712c5
update docs to reflect that mailer generator add suffix to generated classes [ci skip]
2015-02-25 19:22:33 +09:00
39c936b760
Merge pull request #18393 from y-yagi/fix_mailer
...
follow up to #18074
2015-02-18 19:05:07 -02:00
44a49e5534
Added default values for #format_paragraph docs [skip ci]
2015-02-15 20:29:58 +03:00
7b58423251
remove noise from AM tests
2015-02-07 13:38:18 +05:30
6eced6a1fe
Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 onwards.
2015-02-03 20:51:40 +05:30
ce8efcf296
Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846
...
ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
2015-01-31 23:12:41 -05:00
afe402dac7
unify CHANGELOG format. [ci skip]
2015-01-31 11:54:00 +01:00
855cca0662
Merge pull request #18521 from andrewvida/master
...
Correct the views that the mail method sends in API docs.
2015-01-14 17:47:52 -02:00
29a2977af5
Correct views mail method sends in API docs
2015-01-14 14:43:58 -05:00
e4613c97c3
Fix assertion that was never run
...
In order to run whether the `welcome` method of the ActionMailer::Base
subclass raises an error, `message` must be called, otherwise the method
is not executed at all.
You could just replace with `def welcome; raise StandardError; end` and you
would still see a passing test.
This commit fixes the test so the assertion is actually executed, just like
any other tests in the file, where `.message` is called.
2015-01-11 11:50:29 -08:00
6870d48d19
Add _mailer suffix to i18n path
...
For mailers created via generators
Follow up to #18074
2015-01-08 22:24:22 -05:00
3f17fbd68d
Add assert_enqueued_emails and assert_no_enqueued_emails
2015-01-08 09:41:22 -05:00
af3eb5961e
follow up to #18074
...
* ignore mailer suffix when generate test files
* add mailer suffix to view files
2015-01-08 22:21:54 +09:00
f9e0ec5449
Move changelog entry to the top [ci skip]
2015-01-07 07:44:57 -02:00
yui-knk